Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1622528ybv; Fri, 21 Feb 2020 00:28:28 -0800 (PST) X-Google-Smtp-Source: APXvYqy0oe5jKOcursSaifhNuE/DepiZdYf4PbRbQyqxy3dTIqdslwGk96vPijvVzrRUyGj4U7Id X-Received: by 2002:a05:6830:1305:: with SMTP id p5mr25261712otq.124.1582273708020; Fri, 21 Feb 2020 00:28:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582273708; cv=none; d=google.com; s=arc-20160816; b=qLeX/TiE+YzYYoPIAw0sa79ZERjNhxbiASiFxZLyFVMUYPjGO6THk7Uk5X3TDCCRRU s5PJCj+i2FK0fkxyk4rS+tlRY0rqrt5DrZcS7rJGFIQHaLranJ8TaTMlrvme874Zrxc4 vZKPK/QmtscGlddAnQImPrpnEYEUj7fcbCLEVX/tak/KOFx4vDepQP1PT9tsnoqBPeAh VSkqhgpqUkBG/JINKX61Ls2x2CBv3xgXqi79YSrPPOrW3hVX95j2Uslo/Ye5eVbxzJrd eG4lQNw9MJpILwPjhISjhQwntNMbkgR3S8WW/MlMvk/R2lpCx15rUOB43xWJc7oisWr+ R4ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=970W3qhvPZR5lumgNjBYtW+e0QQ6Q0O3PTPHpXYCmvE=; b=z1qAePYwnlfoNL1GI6ctdZuYytVq/BRmB8Inoul9O+U4Md9OyiR2cTy7Qk8BkyCOEg /8GXyTzq+nziebb3adsK7jV5CRapsXXBXOLuV4RbhyELSxSpyYGODOr9iK21lCZxH8VA bp0LpTZYSXK8U7gPgwxmsM+BeI7pDzNc/WWB5n4hN4JmYShYVox436COyvUbJxJCdEm+ hyI1afy+l8Hy1gz/s/GdyE1hMDSVPm+fkdCls24HW6kmE1jQhyw7SZzkuX3SOJnnVpB9 Q4sOMnnssSnFsAPITanLxb+kWczLyVl06mFOsD+k6ynbJRreJE69t8YRZh0fbQEGqcMQ JSzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1NfHcSMC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g5si1127385otn.232.2020.02.21.00.28.14; Fri, 21 Feb 2020 00:28:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1NfHcSMC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730725AbgBUIVr (ORCPT + 99 others); Fri, 21 Feb 2020 03:21:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:32972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388104AbgBUIVj (ORCPT ); Fri, 21 Feb 2020 03:21:39 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB32920578; Fri, 21 Feb 2020 08:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582273298; bh=48rndanHeY2dcGba9Bsm/+w3uG3i86oxuqKXUO1c+oc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1NfHcSMC6IeQDmQUXxIv6Xze8hSO4RLUE8l5VK/aPe4R+qVGa++IB7SWXkymD5Fv5 doLT4R4f0gCHEZ6J/yRfw+3V2/aKj3+F5HGZbqA7HfVMQg5EsHwuRC29kPr36S+qwK 0bpiv/Uyn5yx3gL/lhPdEd2mvPySvPsrhsqgUrFE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nathan Chancellor , Sasha Levin Subject: [PATCH 4.19 117/191] tty: synclink_gt: Adjust indentation in several functions Date: Fri, 21 Feb 2020 08:41:30 +0100 Message-Id: <20200221072304.954841377@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072250.732482588@linuxfoundation.org> References: <20200221072250.732482588@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Chancellor [ Upstream commit 446e76873b5e4e70bdee5db2f2a894d5b4a7d081 ] Clang warns: ../drivers/tty/synclink_gt.c:1337:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] if (C_CRTSCTS(tty)) { ^ ../drivers/tty/synclink_gt.c:1335:2: note: previous statement is here if (I_IXOFF(tty)) ^ ../drivers/tty/synclink_gt.c:2563:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] if (I_BRKINT(info->port.tty) || I_PARMRK(info->port.tty)) ^ ../drivers/tty/synclink_gt.c:2561:2: note: previous statement is here if (I_INPCK(info->port.tty)) ^ ../drivers/tty/synclink_gt.c:3221:3: warning: misleading indentation; statement is not part of the previous 'else' [-Wmisleading-indentation] set_signals(info); ^ ../drivers/tty/synclink_gt.c:3219:2: note: previous statement is here else ^ 3 warnings generated. The indentation on these lines is not at all consistent, tabs and spaces are mixed together. Convert to just using tabs to be consistent with the Linux kernel coding style and eliminate these warnings from clang. Link: https://github.com/ClangBuiltLinux/linux/issues/822 Signed-off-by: Nathan Chancellor Link: https://lore.kernel.org/r/20191218023912.13827-1-natechancellor@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/synclink_gt.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/tty/synclink_gt.c b/drivers/tty/synclink_gt.c index b88ecf102764e..e9779b03ee565 100644 --- a/drivers/tty/synclink_gt.c +++ b/drivers/tty/synclink_gt.c @@ -1335,10 +1335,10 @@ static void throttle(struct tty_struct * tty) DBGINFO(("%s throttle\n", info->device_name)); if (I_IXOFF(tty)) send_xchar(tty, STOP_CHAR(tty)); - if (C_CRTSCTS(tty)) { + if (C_CRTSCTS(tty)) { spin_lock_irqsave(&info->lock,flags); info->signals &= ~SerialSignal_RTS; - set_signals(info); + set_signals(info); spin_unlock_irqrestore(&info->lock,flags); } } @@ -1360,10 +1360,10 @@ static void unthrottle(struct tty_struct * tty) else send_xchar(tty, START_CHAR(tty)); } - if (C_CRTSCTS(tty)) { + if (C_CRTSCTS(tty)) { spin_lock_irqsave(&info->lock,flags); info->signals |= SerialSignal_RTS; - set_signals(info); + set_signals(info); spin_unlock_irqrestore(&info->lock,flags); } } @@ -2561,8 +2561,8 @@ static void change_params(struct slgt_info *info) info->read_status_mask = IRQ_RXOVER; if (I_INPCK(info->port.tty)) info->read_status_mask |= MASK_PARITY | MASK_FRAMING; - if (I_BRKINT(info->port.tty) || I_PARMRK(info->port.tty)) - info->read_status_mask |= MASK_BREAK; + if (I_BRKINT(info->port.tty) || I_PARMRK(info->port.tty)) + info->read_status_mask |= MASK_BREAK; if (I_IGNPAR(info->port.tty)) info->ignore_status_mask |= MASK_PARITY | MASK_FRAMING; if (I_IGNBRK(info->port.tty)) { @@ -3193,7 +3193,7 @@ static int tiocmset(struct tty_struct *tty, info->signals &= ~SerialSignal_DTR; spin_lock_irqsave(&info->lock,flags); - set_signals(info); + set_signals(info); spin_unlock_irqrestore(&info->lock,flags); return 0; } @@ -3204,7 +3204,7 @@ static int carrier_raised(struct tty_port *port) struct slgt_info *info = container_of(port, struct slgt_info, port); spin_lock_irqsave(&info->lock,flags); - get_signals(info); + get_signals(info); spin_unlock_irqrestore(&info->lock,flags); return (info->signals & SerialSignal_DCD) ? 1 : 0; } @@ -3219,7 +3219,7 @@ static void dtr_rts(struct tty_port *port, int on) info->signals |= SerialSignal_RTS | SerialSignal_DTR; else info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR); - set_signals(info); + set_signals(info); spin_unlock_irqrestore(&info->lock,flags); } -- 2.20.1