Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1638772ybv; Fri, 21 Feb 2020 00:47:45 -0800 (PST) X-Google-Smtp-Source: APXvYqzal8pZWMaezDPbBaAsuocc2sDYRqW3Kulf/3hjDZ8faqzUkXs7dvSl7oe33Q7zFMwxsE6W X-Received: by 2002:a05:6808:9b4:: with SMTP id e20mr1047386oig.37.1582274864888; Fri, 21 Feb 2020 00:47:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582274864; cv=none; d=google.com; s=arc-20160816; b=qYX+X2wcMvxh7xe890ZG+mS6prQwnM7JZ/l0R0qYdAvS8FFtxepc5xUd4MiiicIFzr 2y90zDiWceqG7mQcOH+dVKe+shzO4J4qGP4E5KrQRFVck5KoFywfemdE3x1TmxNoktK8 zGxXD/NKWd6mx+rBG7yzvo/MaHnjHc3VD5irp6GM8DxUziUEUQ9dg5WidiGTH6Tl7uhd 0/mTmpylf6rTPgkbGfhN1IGUX3bA0wTnOIAwbwOM4lYsR9PgtrmcMNi2zZBnJj55xQQi CC0QQneSfdNO6v0PqwS5CJmB3AqnT0WKP8B9kYfvW6eCAdQ5RCa7dfZ1UmIJKTEaXSaD XN9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0gAT38wnbRnZGOfukPUkPAOpb0H6tneTljx+KHs/qA0=; b=KwgCyazfS148BQ+CGTcVmEvuSkZNHKDBdRob4wPGSjh1oajiAFFYA0pfqb1oo+v5nl tBhk6bTgYJnBoyXNUOWu68twcXKk8EaF3gBLqpbUH2CAEnSil/wDb9oQaAo3XrTcoR1u HXLbgzQ88nwQ/K7NZiqQsbvG3Kx5tVK5Ih0p/mwPxUNs0/pARGRrQ73ZVjqHGrcDo/lZ oreBmXPLh/IFVrtuTenvtKC6vFZ0MlQ/6SPgpTJuQatALhjsWxKaOfya4Gl9cOLEZnTG 3UTho0tmCzgPiDzfOnnl/7969Wh7WxpN7y6SaYdkD/sBuwfZOuy4P3k34a7tPxJTI52e R18A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vJAfNnHG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b21si1541919ots.38.2020.02.21.00.47.33; Fri, 21 Feb 2020 00:47:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vJAfNnHG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729182AbgBUHtP (ORCPT + 99 others); Fri, 21 Feb 2020 02:49:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:45520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729216AbgBUHtK (ORCPT ); Fri, 21 Feb 2020 02:49:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5E1D3207FD; Fri, 21 Feb 2020 07:49:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582271349; bh=Ni2uE3UrzUOKeHuUBp47BRf/YTw6+RTDvh2UjhiuMWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vJAfNnHGhd1GfWZ1pvvzkEp75RfaRNDMwkArKaGS28OHAtvWdvl138nNDlIK6GPCL WJlspvrVKFWBr/if3cNod4GAof2chTX3I9SiqEKlICA4ckMjmqS+5iwkWgHsYhuxmG OC1V2iIEkQU4rHa5/sAI0xbJuYdKEpcqXhjKcvvg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lakshmi Ramasubramanian , Mimi Zohar , Sasha Levin Subject: [PATCH 5.5 132/399] IMA: Check IMA policy flag Date: Fri, 21 Feb 2020 08:37:37 +0100 Message-Id: <20200221072415.299614924@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072402.315346745@linuxfoundation.org> References: <20200221072402.315346745@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lakshmi Ramasubramanian [ Upstream commit c5563bad88e07017e08cce1142903e501598c80c ] process_buffer_measurement() may be called prior to IMA being initialized (for instance, when the IMA hook is called when a key is added to the .builtin_trusted_keys keyring), which would result in a kernel panic. This patch adds the check in process_buffer_measurement() to return immediately if IMA is not initialized yet. Signed-off-by: Lakshmi Ramasubramanian Signed-off-by: Mimi Zohar Signed-off-by: Sasha Levin --- security/integrity/ima/ima_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c index d7e987baf1274..9b35db2fc777a 100644 --- a/security/integrity/ima/ima_main.c +++ b/security/integrity/ima/ima_main.c @@ -655,6 +655,9 @@ void process_buffer_measurement(const void *buf, int size, int action = 0; u32 secid; + if (!ima_policy_flag) + return; + /* * Both LSM hooks and auxilary based buffer measurements are * based on policy. To avoid code duplication, differentiate -- 2.20.1