Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751361AbWBJT7x (ORCPT ); Fri, 10 Feb 2006 14:59:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751363AbWBJT7x (ORCPT ); Fri, 10 Feb 2006 14:59:53 -0500 Received: from smtp.osdl.org ([65.172.181.4]:48030 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751361AbWBJT7w (ORCPT ); Fri, 10 Feb 2006 14:59:52 -0500 Date: Fri, 10 Feb 2006 11:59:21 -0800 (PST) From: Linus Torvalds To: Oliver Neukum cc: Nick Piggin , Andrew Morton , linux@horizon.com, linux-kernel@vger.kernel.org, sct@redhat.com Subject: Re: msync() behaviour broken for MS_ASYNC, revert patch? In-Reply-To: <200602102034.07531.oliver@neukum.org> Message-ID: References: <20060209071832.10500.qmail@science.horizon.com> <43ECDD9B.7090709@yahoo.com.au> <200602102034.07531.oliver@neukum.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1146 Lines: 28 On Fri, 10 Feb 2006, Oliver Neukum wrote: > > Am Freitag, 10. Februar 2006 20:05 schrieb Linus Torvalds: > > So we may have different expectations, because we've seen different > > patterns. Me, I've seen the "events are huge, and you stagger them", so > > that the previous event has time to flow out to disk while you generate > > the next one. There, MS_ASYNC starting IO is _wrong_, because the scale of > > the event is just huge, so trying to push it through the IO subsystem asap > > just makes everything suck. > > Isn't the benefit of starting writing immediately greater the smaller > the area in question? If so, couldn't a heuristic be found to decide whether > to initiate IO at once? Quite possibly. I suspect you could/should take other issues into account too (like whether the queue to the device is busy or bdflush is already working). I wouldn't object to that. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/