Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drm/hisilicon: Fixed pcie resource conflict using the
 general API
To:     Thomas Zimmermann <tzimmermann@suse.de>,
        Xinliang Liu <xinliang.liu@linaro.org>,
        Tian Tao <tiantao6@hisilicon.com>
CC:     <puck.chen@hisilicon.com>, <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, <kraxel@redhat.com>,
        <alexander.deucher@amd.com>, <tglx@linutronix.de>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>
References: <1582264523-61170-1-git-send-email-tiantao6@hisilicon.com>
 <CAKoKPbztX8--gWgLDYJFQX1=Wf1jiFKx+H2_RFN90fxOpr_RdQ@mail.gmail.com>
 <e65e3728-406e-ff9c-a8ef-6829666fa573@suse.de>
From:   "tiantao (H)" <tiantao6@huawei.com>
Message-ID: <4a8ba960-34c5-d044-900d-5cd0e9ec310e@huawei.com>
Date:   Fri, 21 Feb 2020 16:56:05 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <e65e3728-406e-ff9c-a8ef-6829666fa573@suse.de>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sorry,my mistake. I sent the wrong patch, please ignore the patch below

在 2020/2/21 16:52, Thomas Zimmermann 写道:
> Hi
> 
> Am 21.02.20 um 08:06 schrieb Xinliang Liu:
>> Hi tao,
>> Are you sending a wrong patch?
>> Function hibmc_remove_framebuffers is added by your prior reviewing patch.
>> Please send patch based on drm-misc-next branch[1] or linux-next.
> 
> There's drm_fb_helper_remove_conflicting_pci_framebuffers() which
> already implements the functionality. I asked to try using it instead of
> creating an own implementation.
> 
> Best regards
> Thomas
> 
>>
>> Thanks,
>> -Xinliang
>>
>> [1] https://anongit.freedesktop.org/git/drm-misc.git
>>
>> On Fri, 21 Feb 2020 at 13:56, Tian Tao <tiantao6@hisilicon.com
>> <mailto:tiantao6@hisilicon.com>> wrote:
>>
>>      the kernel provide the drm_fb_helper_remove_conflicting_pci_framebuffer
>>      to remvoe the pcie resource conflict,there is no need to driver it
>>      again.
>>
>>      Signed-off-by: Tian Tao <tiantao6@hisilicon.com
>>      <mailto:tiantao6@hisilicon.com>>
>>      ---
>>       drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 22
>>      +++++-----------------
>>       1 file changed, 5 insertions(+), 17 deletions(-)
>>
>>      diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
>>      b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
>>      index 7ebe831..0f7dba7 100644
>>      --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
>>      +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
>>      @@ -47,22 +47,6 @@ static irqreturn_t hibmc_drm_interrupt(int irq,
>>      void *arg)
>>              return IRQ_HANDLED;
>>       }
>>
>>      -static void hibmc_remove_framebuffers(struct pci_dev *pdev)
>>      -{
>>      -       struct apertures_struct *ap;
>>      -
>>      -       ap = alloc_apertures(1);
>>      -       if (!ap)
>>      -               return;
>>      -
>>      -       ap->ranges[0].base = pci_resource_start(pdev, 0);
>>      -       ap->ranges[0].size = pci_resource_len(pdev, 0);
>>      -
>>      -       drm_fb_helper_remove_conflicting_framebuffers(ap,
>>      "hibmcdrmfb", false);
>>      -
>>      -       kfree(ap);
>>      -}
>>      -
>>       static struct drm_driver hibmc_driver = {
>>              .driver_features        = DRIVER_GEM | DRIVER_MODESET |
>>      DRIVER_ATOMIC,
>>              .fops                   = &hibmc_fops,
>>      @@ -343,7 +327,11 @@ static int hibmc_pci_probe(struct pci_dev *pdev,
>>              struct drm_device *dev;
>>              int ret;
>>
>>      -       hibmc_remove_framebuffers(pdev);
>>      +       ret = drm_fb_helper_remove_conflicting_pci_framebuffers(pdev,
>>      +
>>       "hibmcdrmfb");
>>      +       if (ret)
>>      +               return ret;
>>      +
>>
>>              dev = drm_dev_alloc(&hibmc_driver, &pdev->dev);
>>              if (IS_ERR(dev)) {
>>      --
>>      2.7.4
>>
>