Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1674456ybv; Fri, 21 Feb 2020 01:27:26 -0800 (PST) X-Google-Smtp-Source: APXvYqwoBFn0xQsmh0jKiSLm+izeRNRPwg1lInkOM0Cj7qTdFeNOQJdG/ijCi9SuXIyoKfUruanq X-Received: by 2002:a05:6830:2154:: with SMTP id r20mr29003904otd.131.1582277246368; Fri, 21 Feb 2020 01:27:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582277246; cv=none; d=google.com; s=arc-20160816; b=GQW7KzkWcKRcUocJkf1GiRWWaHHsOcPQqB7i8WDW4E7qBr+roT3HKk/pz8femWQx+F zbqZn/BAzk33UNThduQSQDQZF2jUmnwT/2x3F1fcrMqWiz60YsdY3xQHOepQSAkNZpzH +Tjrj1XeBZDHyPnHo5WuoUrb2ePfSDaC9C4VxrRpjIi6artNoFGVHRkSOLr6+ZxNl9YK rA//59pVKuUGXNTD3FXSCt79cOhjIfjVI9FhSRsafN6QDDhOKaSeo1BVz6TSxlubXxI3 fA64APQc9ixcZsYCePH590SpPRDex9eKD6ijmdn9h5xVggY0d/oNvaO8OCQzhnpbLsPh erYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=jEYac9KRo0XcqNgnxbCyVuBSwcCZGg1S60WLwnwaoVs=; b=Tr//mb9VFw4AWN/4tS5/LTUk0J7Qp1XDSf0lOrmf6pPmcZur74yC8TOiAa23imrHCu PJ9sjZq2FYWkb6WjN9X765MtqL2dp+IMvV5WBUmzGkMwaXWpk+HDqDxFX0KY94YD770L z3bh0AEFi0o/YXDi3X/TMxJdZZxQPA6ZALMqnGqLGZDcRZ1sKS/oOJ+NnJehpHMIPi++ Lx0NlEPTrIX2rXAa1kXj2BBkhaaGcv5tnJJ80b3yh9TuR1UxST5BLJeCglqD/PoWmgqw ciQx+GmBvJF8tw7d/IS4UEkUvroO+j0sV3QJF2J+gaGjAizivoL7mDjWxo0i88Uor1Mm Np2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xZzl7uv6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 94si1166531otw.297.2020.02.21.01.27.14; Fri, 21 Feb 2020 01:27:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xZzl7uv6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727470AbgBUJZp (ORCPT + 99 others); Fri, 21 Feb 2020 04:25:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:39110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726853AbgBUJZn (ORCPT ); Fri, 21 Feb 2020 04:25:43 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 26B5120722; Fri, 21 Feb 2020 09:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582277142; bh=3OdwtR+kNO4djZW2+oyAKDoEMYvTKrgiyYMXvaf9vDY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xZzl7uv6QnP2tWpNeRwsIcxrU6CkkJWUOY6Tz6qPcgDthCeLoENBn4hZ4okqakAVO ps7hKcvPVDfX3cF5YHpXwVJHGiPiwfEees9nUaIy2HWHY6xTggiRjACU0Zcf+neoP6 Fo5v2YdTboR/aA7j7KF5p9OFdL6DznoAnS38/b1Q= Date: Fri, 21 Feb 2020 10:25:40 +0100 From: Greg Kroah-Hartman To: Saravana Kannan Cc: "Rafael J. Wysocki" , kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] driver core: Call sync_state() even if supplier has no consumers Message-ID: <20200221092540.GA71325@kroah.com> References: <20200221080510.197337-1-saravanak@google.com> <20200221080510.197337-2-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200221080510.197337-2-saravanak@google.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 21, 2020 at 12:05:08AM -0800, Saravana Kannan wrote: > The initial patch that added sync_state() support didn't handle the case > where a supplier has no consumers. This was because when a device is > successfully bound with a driver, only its suppliers were checked to see > if they are eligible to get a sync_state(). This is not sufficient for > devices that have no consumers but still need to do device state clean > up. So fix this. > > Fixes: fc5a251d0fd7ca90 (driver core: Add sync_state driver/bus callback) Should be: Fixes: fc5a251d0fd7 ("driver core: Add sync_state driver/bus callback") > Signed-off-by: Saravana Kannan So this needs to go to 5.5 also, right? thanks, greg k-h