Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 3/5] sched/pelt: Remove unused runnable load average
To:     Vincent Guittot <vincent.guittot@linaro.org>, mingo@redhat.com,
        peterz@infradead.org, juri.lelli@redhat.com, rostedt@goodmis.org,
        bsegall@google.com, mgorman@suse.de, linux-kernel@vger.kernel.org
Cc:     pauld@redhat.com, parth@linux.ibm.com, valentin.schneider@arm.com,
        hdanton@sina.com
References: <20200214152729.6059-1-vincent.guittot@linaro.org>
 <20200214152729.6059-4-vincent.guittot@linaro.org>
From:   Dietmar Eggemann <dietmar.eggemann@arm.com>
Message-ID: <e115029f-d577-ba31-e8b1-bb0d1a3f0f80@arm.com>
Date:   Fri, 21 Feb 2020 10:57:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200214152729.6059-4-vincent.guittot@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 14/02/2020 16:27, Vincent Guittot wrote:

[...]

fdef CONFIG_SMP
> @@ -2940,15 +2913,12 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se,
>  		u32 divider = LOAD_AVG_MAX - 1024 + se->avg.period_contrib;
>  
>  		se->avg.load_avg = div_u64(se_weight(se) * se->avg.load_sum, divider);
> -		se->avg.runnable_load_avg =
> -			div_u64(se_runnable(se) * se->avg.runnable_load_sum, divider);
>  	} while (0);
>  #endif
>  
>  	enqueue_load_avg(cfs_rq, se);
>  	if (se->on_rq) {
>  		account_entity_enqueue(cfs_rq, se);
> -		enqueue_runnable_load_avg(cfs_rq, se);
>  	}

Nit pick: No curly brackets needed anymore.

[...]