Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1745139ybv; Fri, 21 Feb 2020 02:47:02 -0800 (PST) X-Google-Smtp-Source: APXvYqxuDmSWoapz8I9GKhA9XkUJyTSAf1lyqTAAkk8IOgUYeUzlmUxVlG3F6FiC5AwRKK5VR9UK X-Received: by 2002:a9d:53c2:: with SMTP id i2mr25889533oth.43.1582282021954; Fri, 21 Feb 2020 02:47:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582282021; cv=none; d=google.com; s=arc-20160816; b=ohmMUUaRgXi3YZw0Mgwq6QBINHkrVkiVx+kRTApFgut7zu4VqjA9VRFAcsx0wfR8Yk cd3uoyhYWIoE6XPOajrnyLvPwN6NMAzxI3maWBaFDWjjkI+MOkAKGGWhmM0kyBXRJz/H YOzEQwn2kfLLdN45l90h30jdzJvjsXdPhh8S4qfm9Jm2DOAJF7qSXh2wp6oBOwsNEWJd A7RVpH3AZqLTf2R3AYx2Ds/rXQBZ38L1RkmJvPEP9XDdsO5/JLKAzwzbIxwCvZ1p3SmM 0oOdbxW5Rr4zSUvfPexIJnPXqLunAOfEpqwPzvSTEyjXxoI3FyTPbzd8KL7u4HOuzQ+3 60bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=87rvoP4LgyiyWEyHZqv99cJAkSGQ17/JjLlyOM0tU1M=; b=Ne1pt0dVV1SNRWdA+DhUTScLgm9zctLhpDIuab4SDWLTueLnnR0lyzOfv+TIevgK4G 9aoO59i9hCYK8gKUHuFesO6mYXfIezCKFLFwJ3s7kO7/sg6ev67o5SEUaBcMLf5k+9tI cC6EwLK7i9ZKe/WoJbWqf9cY1xY9Ot3Z2K58PVkx1VQolBz3JTIaosXL3giILTRNXenF Wawfif8myatjknwnjXNN9YH2W4hnOzNQJU44gdHHKQlsvlsoUmYd/ZYLd/XdnkXj6xwU MITU+jpD7kL0Ro2MH7kF/iVsjbk1iUT/jqh0LlQXVPqFsixNtL5A8d61lMNo7qFCkT4W uyMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7si1217617otp.11.2020.02.21.02.46.49; Fri, 21 Feb 2020 02:47:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728103AbgBUKpD (ORCPT + 99 others); Fri, 21 Feb 2020 05:45:03 -0500 Received: from foss.arm.com ([217.140.110.172]:36426 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727077AbgBUKpD (ORCPT ); Fri, 21 Feb 2020 05:45:03 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7B45C31B; Fri, 21 Feb 2020 02:45:02 -0800 (PST) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 63E163F68F; Fri, 21 Feb 2020 02:45:00 -0800 (PST) Date: Fri, 21 Feb 2020 10:44:54 +0000 From: Lorenzo Pieralisi To: Boqun Feng Cc: linux-pci@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michael Kelley , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Sasha Levin , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Andrew Murray , Bjorn Helgaas Subject: Re: [PATCH v3 0/3] PCI: hv: Generify pci-hyperv.c Message-ID: <20200221104454.GA8595@e121166-lin.cambridge.arm.com> References: <20200210033953.99692-1-boqun.feng@gmail.com> <20200221023344.GJ69864@debian-boqun.qqnc3lrjykvubdpftowmye0fmh.lx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200221023344.GJ69864@debian-boqun.qqnc3lrjykvubdpftowmye0fmh.lx.internal.cloudapp.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 21, 2020 at 10:33:44AM +0800, Boqun Feng wrote: > Ping ;-) > > Any suggestion or plan on this patchset? Hi, I shall have a look shortly, thanks. Lorenzo > Thanks and Regards, > Boqun > > On Mon, Feb 10, 2020 at 11:39:50AM +0800, Boqun Feng wrote: > > Hi, > > > > This is the first part for virtual PCI support of Hyper-V guest on > > ARM64. The whole patchset doesn't have any functional change, but only > > refactors the pci-hyperv.c code to make it more arch-independent. > > > > Previous version: > > v1: https://lore.kernel.org/lkml/20200121015713.69691-1-boqun.feng@gmail.com/ > > v2: https://lore.kernel.org/linux-arm-kernel/20200203050313.69247-1-boqun.feng@gmail.com/ > > > > Changes since v2: > > > > * Rebased on 5.6-rc1 > > > > * Reword commit logs as per Andrew's suggestion. > > > > * It makes more sense to have a generic interface to set the whole > > msi_entry rather than only the "address" field. So change > > hv_set_msi_address_from_desc() to hv_set_msi_entry_from_desc(). > > Additionally, make it an inline function as per the suggestion > > of Andrew and Thomas. > > > > * Add the missing comment saying the partition_id of > > hv_retarget_device_interrupt must be self. > > > > * Add the explanation for why "__packed" is needed for TLFS > > structures. > > > > I've done compile and boot test of this patchset, also done some tests > > with a pass-through NVMe device. > > > > Suggestions and comments are welcome! > > > > Regards, > > Boqun > > > > Boqun Feng (3): > > PCI: hv: Move hypercall related definitions into tlfs header > > PCI: hv: Move retarget related structures into tlfs header > > PCI: hv: Introduce hv_msi_entry > > > > arch/x86/include/asm/hyperv-tlfs.h | 41 +++++++++++++++++++++++++++ > > arch/x86/include/asm/mshyperv.h | 8 ++++++ > > drivers/pci/controller/pci-hyperv.c | 43 ++--------------------------- > > 3 files changed, 52 insertions(+), 40 deletions(-) > > > > -- > > 2.24.1 > >