Return-Path: <linux-kernel-owner+willy=40w.ods.org-S932191AbWBJUjo@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932191AbWBJUjo (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 10 Feb 2006 15:39:44 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932186AbWBJUjo
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 10 Feb 2006 15:39:44 -0500
Received: from mailhub.sw.ru ([195.214.233.200]:21031 "EHLO relay.sw.ru")
	by vger.kernel.org with ESMTP id S932185AbWBJUjn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Feb 2006 15:39:43 -0500
Message-ID: <43ECFA46.3050001@sw.ru>
Date: Fri, 10 Feb 2006 23:40:38 +0300
From: Kirill Korotaev <dev@sw.ru>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; ru-RU; rv:1.2.1) Gecko/20030426
X-Accept-Language: ru-ru, en
MIME-Version: 1.0
To: "Eric W. Biederman" <ebiederm@xmission.com>
CC: linux-kernel@vger.kernel.org, vserver@list.linux-vserver.org,
       Herbert Poetzl <herbert@13thfloor.at>,
       "Serge E. Hallyn" <serue@us.ibm.com>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>, Dave Hansen <haveblue@us.ibm.com>,
       Arjan van de Ven <arjan@infradead.org>,
       Suleiman Souhlal <ssouhlal@FreeBSD.org>,
       Hubertus Franke <frankeh@watson.ibm.com>,
       Cedric Le Goater <clg@fr.ibm.com>, Kyle Moffett <mrmacman_g4@mac.com>,
       Greg <gkurz@fr.ibm.com>, Linus Torvalds <torvalds@osdl.org>,
       Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>,
       Rik van Riel <riel@redhat.com>, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
       Andrey Savochkin <saw@sawoct.com>, Kirill Korotaev <dev@openvz.org>,
       Andi Kleen <ak@suse.de>,
       Benjamin Herrenschmidt <benh@kernel.crashing.org>,
       Jeff Garzik <jgarzik@pobox.com>,
       Trond Myklebust <trond.myklebust@fys.uio.no>,
       Jes Sorensen <jes@sgi.com>
Subject: Re: [RFC][PATCH 20/20] proc: Update /proc to support multiple pid
 spaces.
References: <m11wygnvlp.fsf@ebiederm.dsl.xmission.com>	<m1vevsmgvz.fsf@ebiederm.dsl.xmission.com>	<m1lkwomgoj.fsf_-_@ebiederm.dsl.xmission.com>	<m1fymwmgk0.fsf_-_@ebiederm.dsl.xmission.com>	<m1bqxkmgcv.fsf_-_@ebiederm.dsl.xmission.com>	<m17j88mg8l.fsf_-_@ebiederm.dsl.xmission.com>	<m13biwmg4p.fsf_-_@ebiederm.dsl.xmission.com>	<m1y80ol1gh.fsf_-_@ebiederm.dsl.xmission.com>	<m1u0bcl1ai.fsf_-_@ebiederm.dsl.xmission.com>	<m1psm0l170.fsf_-_@ebiederm.dsl.xmission.com>	<m1lkwol133.fsf_-_@ebiederm.dsl.xmission.com>	<m1hd7cl0yp.fsf_-_@ebiederm.dsl.xmission.com>	<m1d5i0l0ua.fsf_-_@ebiederm.dsl.xmission.com>	<m18xsol0p9.fsf_-_@ebiederm.dsl.xmission.com>	<m14q3cl0mk.fsf_-_@ebiederm.dsl.xmission.com>	<m1zml4jlzk.fsf_-_@ebiederm.dsl.xmission.com>	<m1vevsjlxa.fsf_-_@ebiederm.dsl.xmission.com>	<m1r76gjlua.fsf_-_@ebiederm.dsl.xmission.com>	<m1mzh4jlrl.fsf_-_@ebiederm.dsl.xmission.com>	<m1irrsjlnn.fsf_-_@ebiederm.dsl.xmission.com> <m1ek2gjlgh.fsf_-_@ebiederm.dsl.xmission.com>
In-Reply-To: <m1ek2gjlgh.fsf_-_@ebiederm.dsl.xmission.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1529
Lines: 36

Hello,

> This patch does a couple of things.
> - It splits proc into proc and proc_sysinfo
> - It adds pspace support to proc
> - It adds getattr methods to ensure proc has the proper hard link count.
> - It increases the size of a couple of buffers by one to avoid buffer overflow
> - It moves /proc/mounts and /proc/loadavg into the proc filesystem from proc_sysinfo
> 
> Sorry for the big patch.  When I start feeding this changes seriously I will
> split this patch.
> 
> The split of /proc into mutliple filesystems works well however it comes
> with one downsides.  There are now some directories where cd -P <subdir>/..
> is not a noop.  Basically it is doing the equivalent of following symlinks
> into an internal kernel mount.  It is well defined and safe behaviour but
> I'm not certain if it is desirable.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>

This one is really ugly.
And it is also controversial to your own idea of having separate 
namespaces, but introduces a pointer to proc_mnt in pspace.

You have many namespaces to which task_struct refers.
Do you want proc to work in any configuration of namespaces?
Then you can't have pointers to proc_mnt from namespaces.
Well, I understand that proc is the most painfull for you... yeah...

Kirill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/