Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1785214ybv; Fri, 21 Feb 2020 03:27:59 -0800 (PST) X-Google-Smtp-Source: APXvYqytYC5syygIrJAUqRu/Fg60buJ91H6ZGi915w8yUL5V7fu8nAwz7Sq0dyatqApZW7SdGvMA X-Received: by 2002:a9d:6184:: with SMTP id g4mr26207242otk.223.1582284479126; Fri, 21 Feb 2020 03:27:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582284479; cv=none; d=google.com; s=arc-20160816; b=kfupvIymTPGFZx7UknPoptKi2CFZ6ajfmVTo31q2gxKwNpvz++ddLiZFLeA+e24zz+ 5NsNcW0501ZtO3hHjcqE2jx3vXmqKyya9EfU70JU4+m/fxVzAj4Sjq1eDbN73MUoTYnd PNqkSBRedoG87Il1ZyzDEJFunKi7ois4lHU6Y9V/FXOXMlBBcJkkQ0TH8JW53Mlt4PZd lEvLT/zYbCBGy/tHgZIiZUUzK4FyFlDKvVXGJvuF4GCQERfXIRn4GIbPZfvtpegHcQLq nahvqTn/d0y49YgO6/1UZEB1ozQnsLx311FPigJuNl2VyAhXMZu1CMO5FaoD08GDGEte ygOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=Ho6wZMX8qLHipLihEaU5SCXs4HqK1+rvVl2GBlxkV28=; b=seXjngaTJgpIrlXktfz/H2XylQcb7NxUvr/LQJ/oLC+6UDtBmQzoIw588fo1Wr2CJ8 iL/Hy8PnaB3NzPSawBdA7XoIsqfI29jc51f1SI+qfUbVG7/JsxW1yFaebacfTmqPPkRR yOZeerz6JWrFj32migo/LerAVRejLpJsW7jwOrUlhQmU6ME98M8KOfL3RRoxhzIQCh/i pY5Xmgmlu9D4DWKe1Fei2BweXhJ51c1E92C9FN4SYWOkuyE9kqqg4ayf+dntKmRfz6+w 62rkvekq8npeFMTfTW06o601ceiQo0k/vVgQfOwN/hf+qCO9Kt5TXWl/zV5KrevZI+77 UaOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@isovalent-com.20150623.gappssmtp.com header.s=20150623 header.b=Rlb6YHpD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f5si1286408otp.129.2020.02.21.03.27.42; Fri, 21 Feb 2020 03:27:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@isovalent-com.20150623.gappssmtp.com header.s=20150623 header.b=Rlb6YHpD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727141AbgBUL1Y (ORCPT + 99 others); Fri, 21 Feb 2020 06:27:24 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45792 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbgBUL1Y (ORCPT ); Fri, 21 Feb 2020 06:27:24 -0500 Received: by mail-wr1-f65.google.com with SMTP id g3so1608084wrs.12 for ; Fri, 21 Feb 2020 03:27:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ho6wZMX8qLHipLihEaU5SCXs4HqK1+rvVl2GBlxkV28=; b=Rlb6YHpDPsOHCT/5Aq+PoY+c+yfNFB3uMTnFGqhvRhPm/D5NrdKzM2J4yQZgdKqvmx R3mnvee3YG//8uDOK6/gczMozK6zfg7E/WaLz1cTmuQA1EjTlNw+gnZVC8kRrK4hoX8O zQbdVR2pLVrnL8k6j6S2Q9RAaef0UQNxFqRGWx6Emo3FwOQUhNoXB5MbNebYDQ+n6jRP nToI6ez0LqEUnco25hj/dxmMpLh9JlG50ygHNaC4JWxAsnVW47V1MAXRpzpNVjz+QlaG oPHGFpzAi02xmB2wYd9gVJwG0LXWot9zDHJ9VvSz9hwf2DEUlAage1mxQbjNvaSyjMuz bSOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ho6wZMX8qLHipLihEaU5SCXs4HqK1+rvVl2GBlxkV28=; b=bg0qFtdAEG1AD7pfzBAWjHNdu4jJ7f5PrA+7xr+KnpYNFKWvYtvnkGWRllwes7Edi0 PivONJTb3E15Dy4VFDQH+YUPhc7IATtkFwTIzRram75gnLsUC4lxQw295XLnjASjUyn8 JX1eNU6dId6NmaGFVGR6WW3Ccc84E1fk6wxmVN+/koNYIVcGkeLxaTvNnKJIx56xjAuN QRNuwpHMvQTasq6GsOnZDcmBTgHH7TXXlyf2hH7O1CBJkn8eaJj9CYf//4ga37bTDDVr CfTJrOUX8sTfBFdmHQgj9MjbJsEScv9uVGxSk7Yip5FFsemuJsmyR3txxPIU8y/GzdXd TlNg== X-Gm-Message-State: APjAAAWAcwooe8E957cKEIFbvUZRhThja+nW1WAcOc9s4kPjeMbhUY8q k+xfBMbc9EVmG3THg6vJwjw89w== X-Received: by 2002:a5d:474d:: with SMTP id o13mr47350622wrs.309.1582284440977; Fri, 21 Feb 2020 03:27:20 -0800 (PST) Received: from [192.168.1.23] ([91.143.66.155]) by smtp.gmail.com with ESMTPSA id v15sm3768573wrf.7.2020.02.21.03.27.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Feb 2020 03:27:20 -0800 (PST) Subject: Re: [PATCH bpf-next v2 1/5] bpftool: Move out sections to separate functions To: Michal Rostecki , bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Quentin Monnet , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , "David S. Miller" , Jesper Dangaard Brouer , John Fastabend , "open list:KERNEL SELFTEST FRAMEWORK" References: <20200221031702.25292-1-mrostecki@opensuse.org> <20200221031702.25292-2-mrostecki@opensuse.org> From: Quentin Monnet Message-ID: Date: Fri, 21 Feb 2020 11:27:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200221031702.25292-2-mrostecki@opensuse.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2020-02-21 04:16 UTC+0100 ~ Michal Rostecki > Remove all calls of print_end_then_start_section function and for loops > out from the do_probe function. Instead, provide separate functions for > each section (like i.e. section_helpers) which are called in do_probe. > This change is motivated by better readability. > > Signed-off-by: Michal Rostecki Thanks! Reviewed-by: Quentin Monnet