Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932188AbWBJVP4 (ORCPT ); Fri, 10 Feb 2006 16:15:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932203AbWBJVP4 (ORCPT ); Fri, 10 Feb 2006 16:15:56 -0500 Received: from smtp.osdl.org ([65.172.181.4]:1714 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932188AbWBJVPz (ORCPT ); Fri, 10 Feb 2006 16:15:55 -0500 Date: Fri, 10 Feb 2006 13:15:29 -0800 (PST) From: Linus Torvalds To: Andrew Morton cc: oliver@neukum.org, nickpiggin@yahoo.com.au, linux@horizon.com, linux-kernel@vger.kernel.org, sct@redhat.com Subject: Re: msync() behaviour broken for MS_ASYNC, revert patch? In-Reply-To: <20060210121130.57db39bc.akpm@osdl.org> Message-ID: References: <20060209071832.10500.qmail@science.horizon.com> <43ECDD9B.7090709@yahoo.com.au> <200602102034.07531.oliver@neukum.org> <20060210121130.57db39bc.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 694 Lines: 20 On Fri, 10 Feb 2006, Andrew Morton wrote: > > Yes, it would make sense to run balance_dirty_pages_ratelimited() inside > msync_pte_range(). So pdflush will get poked if we hit > background_dirty_ratio threshold, or we go into caller-initiated writeout > if we hit dirty_ratio. > > But it's not completely trivial, because I don't think we want to be doing > blocking writeback with mmap_sem held. Why not just do it once, at the end? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/