Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200214152729.6059-1-vincent.guittot@linaro.org>
 <20200214152729.6059-4-vincent.guittot@linaro.org> <e115029f-d577-ba31-e8b1-bb0d1a3f0f80@arm.com>
In-Reply-To: <e115029f-d577-ba31-e8b1-bb0d1a3f0f80@arm.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Fri, 21 Feb 2020 12:56:40 +0100
Message-ID: <CAKfTPtDiVVS-HhwESxjXAkzrhZD_qv=xdcNimTtLGtVjM-OLZQ@mail.gmail.com>
Subject: Re: [PATCH v2 3/5] sched/pelt: Remove unused runnable load average
To:     Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Phil Auld <pauld@redhat.com>, Parth Shah <parth@linux.ibm.com>,
        Valentin Schneider <valentin.schneider@arm.com>,
        Hillf Danton <hdanton@sina.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 21 Feb 2020 at 10:58, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>
> On 14/02/2020 16:27, Vincent Guittot wrote:
>
> [...]
>
> fdef CONFIG_SMP
> > @@ -2940,15 +2913,12 @@ static void reweight_entity(struct cfs_rq *cfs_rq, struct sched_entity *se,
> >               u32 divider = LOAD_AVG_MAX - 1024 + se->avg.period_contrib;
> >
> >               se->avg.load_avg = div_u64(se_weight(se) * se->avg.load_sum, divider);
> > -             se->avg.runnable_load_avg =
> > -                     div_u64(se_runnable(se) * se->avg.runnable_load_sum, divider);
> >       } while (0);
> >  #endif
> >
> >       enqueue_load_avg(cfs_rq, se);
> >       if (se->on_rq) {
> >               account_entity_enqueue(cfs_rq, se);
> > -             enqueue_runnable_load_avg(cfs_rq, se);
> >       }
>
> Nit pick: No curly brackets needed anymore.
>

good catch

> [...]