Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 21 Feb 2020 12:05:19 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Guido =?UTF-8?B?R8O8bnRoZXI=?= <agx@sigxcpu.org>
Cc:     Tomas Novotny <tomas@novotny.cz>, Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        "Angus Ainslie (Purism)" <angus@akkea.ca>,
        Marco Felsch <m.felsch@pengutronix.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: vcnl4000: Export near level property for
 proximity sensor
Message-ID: <20200221120519.43b72007@archlinux>
In-Reply-To: <4a8075acde807225a2d9aeb4164fff881013bbe2.1581947007.git.agx@sigxcpu.org>
References: <cover.1581947007.git.agx@sigxcpu.org>
        <4a8075acde807225a2d9aeb4164fff881013bbe2.1581947007.git.agx@sigxcpu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 17 Feb 2020 14:44:47 +0100
Guido G=C3=BCnther <agx@sigxcpu.org> wrote:

> When an object can be considered close to the sensor is hardware
> dependent. Allowing to configure the property via device tree
> allows to configure this device specific value.
>=20
> This is useful for e.g. iio-sensor-proxy to indicate to userspace
> if an object is close to the sensor.
>=20
> Signed-off-by: Guido G=C3=BCnther <agx@sigxcpu.org>

I'd like this to sit for a while on the mailing list and hopefully get
some input from others.

However, it needs documentation and I think this should be in the
generic docs, or at least proximity specific ones.

Documentation/ABI/testing/sysfs-bus-iio-proximity would be the obvious
place.

Thanks,

Jonathan

> ---
>  drivers/iio/light/vcnl4000.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>=20
> diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
> index 38fcd9a26046..7111118e0fda 100644
> --- a/drivers/iio/light/vcnl4000.c
> +++ b/drivers/iio/light/vcnl4000.c
> @@ -83,6 +83,7 @@ struct vcnl4000_data {
>  	struct mutex vcnl4000_lock;
>  	struct vcnl4200_channel vcnl4200_al;
>  	struct vcnl4200_channel vcnl4200_ps;
> +	uint32_t near_level;
>  };
> =20
>  struct vcnl4000_chip_spec {
> @@ -342,6 +343,26 @@ static const struct vcnl4000_chip_spec vcnl4000_chip=
_spec_cfg[] =3D {
>  	},
>  };
> =20
> +
> +static ssize_t vcnl4000_read_near_level(struct iio_dev *indio_dev,
> +					uintptr_t priv,
> +					const struct iio_chan_spec *chan,
> +					char *buf)
> +{
> +	struct vcnl4000_data *data =3D iio_priv(indio_dev);
> +
> +	return sprintf(buf, "%u\n", data->near_level);
> +}
> +
> +static const struct iio_chan_spec_ext_info vcnl4000_ext_info[] =3D {
> +	{
> +		.name =3D "near_level",
> +		.shared =3D IIO_SEPARATE,
> +		.read =3D vcnl4000_read_near_level,
> +	},
> +	{ /* sentinel */ }
> +};
> +
>  static const struct iio_chan_spec vcnl4000_channels[] =3D {
>  	{
>  		.type =3D IIO_LIGHT,
> @@ -350,6 +371,7 @@ static const struct iio_chan_spec vcnl4000_channels[]=
 =3D {
>  	}, {
>  		.type =3D IIO_PROXIMITY,
>  		.info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW),
> +		.ext_info =3D vcnl4000_ext_info,
>  	}
>  };
> =20
> @@ -439,6 +461,10 @@ static int vcnl4000_probe(struct i2c_client *client,
>  	dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n",
>  		data->chip_spec->prod, data->rev);
> =20
> +	if (device_property_read_u32(&client->dev, "near-level",
> +				     &data->near_level) < 0)
> +		data->near_level =3D 0;
> +
>  	indio_dev->dev.parent =3D &client->dev;
>  	indio_dev->info =3D &vcnl4000_info;
>  	indio_dev->channels =3D vcnl4000_channels;