Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1855945ybv; Fri, 21 Feb 2020 04:39:58 -0800 (PST) X-Google-Smtp-Source: APXvYqx83/j098L1KycfFirj37tIT4uFRA1SFlKKSEzmZ+Os7vH7MTYfvUOxo+BWW16AHyh4JS2o X-Received: by 2002:aca:190b:: with SMTP id l11mr1868526oii.65.1582288797933; Fri, 21 Feb 2020 04:39:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582288797; cv=none; d=google.com; s=arc-20160816; b=QcmPOXYnhnp8HQhnCSt3of6TIAS6rovtDzQDVW7+eved9kXXCyKRPnle49fCNiW3Uz 7qcY9VF7mqqw9stpkXhuQ9U8rOrySs+fTq+NBJmVG8Fy3wWPqp+O6FE9/QTB1hz1Iz1o NshrL/Zl4dRjjGNAfev3ES8M/EWbF5sXhLuUeXqeNi2XMzzPXXjxJWGVj03lE/QAh7Q3 32pJrXqJwII5ab8dKX8DSUpei1xBrSNcPJMx3QXG9BGDkluK0Ue4yz0pYSaTdV45HnO6 stg3flVxCVDYSsmcM2JvgUItZMR/h2kQeW1rtbfRFjYc2QR+Y4TAQxgM8i134Diw04wL h7CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=rg1KZbDSkhH74dOPI/JOnH7VFh+PUdIuYD67KSYSHhw=; b=oFr0PLvI7oD1QFIICTBR0taYb9lqU/D73jLaizm30S939wlAjQRoDFljkf8H+dT3uo nCqAeH1UBiSSr7z4ewYH5+PzAuiuKrogh3cxm8Q/Y0cZwHjTi2wgRApgza4LhWR0uDDK 3lXy5fDei4hMZuvLPkai9BoTT4WsO8rK+NFNDo93UMZnj8ebO7XJPWjBF9axFTQ5BBJ3 iO4O7RIUxb9dK5jblSaVtgJoXLupKsrAMdIi75S8FehppQNkcbPIGKrP6C8crbRCAVEY cs96EH4RHQImgAJ7CLRp4h8/B05q+QAfiLXob0AHr4VIJz8Dyb3hjCfmZxO7hgou1EUa Ttzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j25si724918oij.242.2020.02.21.04.39.45; Fri, 21 Feb 2020 04:39:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727720AbgBUMiR (ORCPT + 99 others); Fri, 21 Feb 2020 07:38:17 -0500 Received: from foss.arm.com ([217.140.110.172]:38454 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726976AbgBUMiQ (ORCPT ); Fri, 21 Feb 2020 07:38:16 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0AF8230E; Fri, 21 Feb 2020 04:38:16 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 780EA3F68F; Fri, 21 Feb 2020 04:38:15 -0800 (PST) Date: Fri, 21 Feb 2020 12:38:13 +0000 From: Mark Brown To: Marek Szyprowski Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Chanwoo Choi , MyungJoo Ham , Sebastian Reichel Subject: Re: [PATCH 1/3] regulator: max14577: Add proper dt-compatible strings Message-ID: <20200221123813.GB5546@sirena.org.uk> References: <20200220145127.21273-1-m.szyprowski@samsung.com> <20200220165614.GD3926@sirena.org.uk> <964b8c4c-36ca-203d-e62b-4a8fc970e23d@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f2QGlHpHGjS2mn6Y" Content-Disposition: inline In-Reply-To: <964b8c4c-36ca-203d-e62b-4a8fc970e23d@samsung.com> X-Cookie: Dead? No excuse for laying off work. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --f2QGlHpHGjS2mn6Y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 21, 2020 at 11:44:03AM +0100, Marek Szyprowski wrote: > On 20.02.2020 17:56, Mark Brown wrote: > > Why would we want to encode the particular way Linux happens to > > represent regulators on a MFD into the DT binding? It's not clear that > > this is a generic thing (another OS might choose to have a separate > > object for each regulator with no parent for example) and the compatible > > isn't adding any information we didn't have already knowing about the > > parent device. > Well, that's how the bindings for max14577/max77836 are defined: > Documentation/devicetree/bindings/mfd/max14577.txt > I've only fixed regulator, charger and extcon drivers to match the cells= =20 > created by the current mfd driver. We could just remove the compatible strings from the binding documentation, they won't do any harm if we don't use them. --f2QGlHpHGjS2mn6Y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5PzzUACgkQJNaLcl1U h9A8Ngf/SfRefh9o1XBTE2v/15NpjtrE65kGU09QEQ1tkHy4YEO5itYQeNBOU92n mwdRrsqe1dh5P303HYqqLL6NPr85ZRfH5dSAVrUVEymN8kmBbjDnRlk5erYMqWUo ZGqe1H85+7ncnoVN+p9OhazcrhGgDYiOI0Jh2W8xmoOkkdnEIfsE+izIpEK/qyhS Xa3M0XrzGs2NKZxn9l3Cd6/2V/5sKuAuwT3nt65q5LZ1Qciz2Yt+Iuj2g3+ig37/ oiVbnUIP2/vtkHxO9ofdoaTTTkx2yXT4SXXaMWioB0OHLd3vxM26LY/F6CWtAMMF phTmMf8zdhw7NSHZpCFFEdHiuy+9ww== =AD14 -----END PGP SIGNATURE----- --f2QGlHpHGjS2mn6Y--