Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <0f2c5adb37454dacbd57d65ba8743bb6092876ff.camel@perches.com>
Subject: Re: [trivial PATCH] cifs: Use #define in cifs_dbg
From:   Joe Perches <joe@perches.com>
To:     =?ISO-8859-1?Q?Aur=E9lien?= Aptel <aaptel@suse.com>,
        Steve French <sfrench@samba.org>
Cc:     linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Date:   Fri, 21 Feb 2020 05:55:56 -0800
In-Reply-To: <87eeuo5a2y.fsf@suse.com>
References: <862518f826b35cd010a2e46f64f6f4cfa0d44582.camel@perches.com>
         <87eeuo5a2y.fsf@suse.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.34.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2020-02-21 at 14:44 +0100, Aur?lien Aptel wrote:
> Joe Perches <joe@perches.com> writes:
> > +			cifs_dbg(VFS, "bogus file nlink value %u\n",
> > +				 fattr->cf_nlink);
> 
> Good catch :)
> I realize that 1 is VFS but this should probably be FYI.

change it as you please.

fyi:

Perhaps commit f2f176b41 ("CIFS: add ONCE flag for cifs_dbg type")
may have increased object size quite a bit as it now tests
an external variable.