Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2082395ybv;
        Fri, 21 Feb 2020 08:34:08 -0800 (PST)
X-Google-Smtp-Source: APXvYqxZiELPymZYgX6TzxoG/5WbcoTNEr95KJA9s+TvWYrsSqnsom7vLWd2KgZWdQB2R1gRqQCH
X-Received: by 2002:a9d:53cb:: with SMTP id i11mr29716424oth.158.1582302847974;
        Fri, 21 Feb 2020 08:34:07 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1582302847; cv=none;
        d=google.com; s=arc-20160816;
        b=ppJOSSrre0VXpVAJm5imFkYbTNWA0NDf3SO3+VgGW09/8qYoeqMFrPMWl8v64xR5tX
         kFwOpFNSB4nIBGY0GUuIYJz4S2wreDV83UKmBB9HGA/l0l6L6Dmv/XHqU3Bz/i7Uiote
         l1eMhde3y97S/SDcbNr8VkdRPum/lo4iYlXaowuVJxUqqDiICG9Nlux5c8Wdh0dGxJZz
         b75lDi3pMkHVZAalKs9F6H+yTA7bQhC+IwO64LnkCVIekSQe17vGnV+fPXfYYdG5tVuM
         58jHn2wGcFDYwDuSrFMEop+XqHRfGMNhZRxMH4EAIwhH38mYvmCNUye7+1cD9myUoY0P
         BdfQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-transfer-encoding:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date;
        bh=+PcjjKDZjNdSN0zOw+oNIKKyBF25uj76JPDj/jTZaUc=;
        b=KcpAIcrThe/1CCfOci6pPEwW+Ax0xlTCZZ4MqroqJwx8YVlLq8RFieVh0L6czI0qYQ
         QxN+cCR/wE/FLObmDUOjNwK+RQfkT9yKGmoQ6AOzW3UJ7Nun1ZQQlH7CWUQ2MXJRO9pq
         rasogM34AA5yLq7085Ip/Mw6Oy5URN94Ju0vJLoB9D+suh8K4Sbb6zb9aGTx6gAPMvCt
         tbW1k8/V0fOq+pOxZaXu+O0XisuaHFcOZOVywbYe2dIJU/e9qQd77ppS2wZMakcDzfJS
         h+Wb/8lgdhekISJkdoEEgKmTpHr/R+iViMwFl0SXEdigo+fuyhMY6/WN0T7wTtfSYUyd
         WOaA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id r21si1607324ota.204.2020.02.21.08.33.51;
        Fri, 21 Feb 2020 08:34:07 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727648AbgBUQdn (ORCPT <rfc822;tanxianhu@gmail.com> + 99 others);
        Fri, 21 Feb 2020 11:33:43 -0500
Received: from metis.ext.pengutronix.de ([85.220.165.71]:38513 "EHLO
        metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726132AbgBUQdm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 21 Feb 2020 11:33:42 -0500
Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5])
        by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
        (Exim 4.92)
        (envelope-from <ukl@pengutronix.de>)
        id 1j5BFB-0002cI-1H; Fri, 21 Feb 2020 17:33:37 +0100
Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89)
        (envelope-from <ukl@pengutronix.de>)
        id 1j5BF8-00081h-K4; Fri, 21 Feb 2020 17:33:34 +0100
Date:   Fri, 21 Feb 2020 17:33:34 +0100
From:   Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v1] lib/vsprintf: update comment about
 simple_strto<foo>() functions
Message-ID: <20200221163334.w7pocmbbw4ymimlc@pengutronix.de>
References: <20200221085723.42469-1-andriy.shevchenko@linux.intel.com>
 <20200221145141.pchim24oht7nxfir@pengutronix.de>
 <CAHp75VfR+X6Mw8ywKNW5mTomzmuHSM8ecQUhxtM=LUkWaSe9CA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHp75VfR+X6Mw8ywKNW5mTomzmuHSM8ecQUhxtM=LUkWaSe9CA@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5
X-SA-Exim-Mail-From: ukl@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 21, 2020 at 05:27:49PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 21, 2020 at 4:54 PM Uwe Kleine-K?nig
> <u.kleine-koenig@pengutronix.de> wrote:
> > On Fri, Feb 21, 2020 at 10:57:23AM +0200, Andy Shevchenko wrote:
> > > The commit 885e68e8b7b1 ("kernel.h: update comment about simple_strto<foo>()
> > > functions") updated a comment regard to simple_strto<foo>() functions, but
> > > missed similar change in the vsprintf.c module.
> > >
> > > Update comments in vsprintf.c as well for simple_strto<foo>() functions.
> 
> ...
> 
> > > - * This function is obsolete. Please use kstrtoull instead.
> > > + * This function has caveats. Please use kstrtoull instead.
> 
> > I wonder if we instead want to create a set of functions that is
> > versatile enough to cover kstrtoull and simple_strtoull. i.e. fix the
> > rounding problems (that are the caveats, right?) and as calling
> > convention use an errorvalued int return + an output-parameter of the
> > corresponding type.
> 
> It wouldn't be possible to apply same rules to both. They both are
> part of existing ABI.

The idea is to creat a sane set of functions, then convert all users to
the sane one and only then strip the strange functions away. (Userspace)
ABI isn't affected, is it?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |