Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 21 Feb 2020 09:19:12 -0800
From:   Richard Cochran <richardcochran@gmail.com>
To:     min.li.xe@renesas.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/2] ptp: Add a ptp clock driver for IDT
 82P33 SMU.
Message-ID: <20200221171912.GA5673@localhost>
References: <1582234109-6296-1-git-send-email-min.li.xe@renesas.com>
 <20200221115128.GA1692@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200221115128.GA1692@localhost>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Feb 21, 2020 at 03:51:28AM -0800, Richard Cochran wrote:
> > +	channel->ptp_clock = ptp_clock_register(&channel->caps, NULL);
> > +
> > +	if (IS_ERR(channel->ptp_clock)) {
> > +		err = PTR_ERR(channel->ptp_clock);
> > +		channel->ptp_clock = NULL;
> > +		return err;
> > +	}
> 
> The function, ptp_clock_register(), can also return NULL.  Please
> handle that case as well.
> 
> > +
> > +	if (!channel->ptp_clock)
> > +		return -ENOTSUPP;

Duh!  Never mind that last comment!

Thanks,
Richard