Subject: Re: 2.6.16-rc2-mm1 -- BUG: warning at
	drivers/ieee1394/ohci1394.c:235/get_phy_reg()
From: Lee Revell <rlrevell@joe-job.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net, Andrew Morton <akpm@osdl.org>,
       Miles Lane <miles.lane@gmail.com>, linux-kernel@vger.kernel.org
In-Reply-To: <43ED3046.6020407@s5r6.in-berlin.de>
References: <a44ae5cd0602101207s4b2d61d7nc6705067b7913322@mail.gmail.com>
	 <20060210122131.4b98cfb4.akpm@osdl.org>
	 <43ED3046.6020407@s5r6.in-berlin.de>
Content-Type: text/plain
Date: Fri, 10 Feb 2006 21:30:39 -0500
Message-Id: <1139625039.19342.49.camel@mindpipe>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1064
Lines: 24

On Sat, 2006-02-11 at 01:31 +0100, Stefan Richter wrote:
> Andrew Morton wrote:
> > Miles Lane <miles.lane@gmail.com> wrote:
> >>BUG: warning at drivers/ieee1394/ohci1394.c:235/get_phy_reg()
> > 
> > That's a -mm-only warning telling you that get_phy_reg() is doing a
> > one-millisecond-or-more busywait while local interrupts are disabled.
> 
> Same with set_phy_reg, ohci_soft_reset, ohci_hw_csr_reg. At least the 
> callers of ohci_hw_csr_reg (in particular, csr_highlevel.host_reset, 
> furthermore csr_highlevel.add_host) could fairly easily be converted to 
> a workqueue job or perhaps moved to the nodemgr thread. I have not 
> checked the other offending functions yet.

In fact I'm pretty sure we have seen reports on the linux-audio-user
list of apps reporting underruns when a 1394 drive is accessed.

Lee

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/