Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2324441ybv; Fri, 21 Feb 2020 13:18:32 -0800 (PST) X-Google-Smtp-Source: APXvYqyVPCOeAY1wAzAyaXCurBezMTR8HZzUQcNqWUekWmkSKXiKwjb5dX3C0iMUgltpolZri6CR X-Received: by 2002:aca:4ace:: with SMTP id x197mr3813786oia.23.1582319912840; Fri, 21 Feb 2020 13:18:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582319912; cv=none; d=google.com; s=arc-20160816; b=e3mwmTs58GyXoKPFtXQTRKO00oPeld59+Nh/GsGrux+uIh1M/Us9GR/Z0/1iutbBts i5vFHcfeI7uZ6y4nMRtHEvAMQzVx0zCAwN6RtBgSxBd7q5LiMtjFuEhTNCzmbNpyWt6O eEtOHV4+ksJmU25QWXZo8pQy9bsyOP/qZpDtEF8/bJjoNnx1kzA6OaICeuTbVdg/NQle BmQ7nyksPYoBsEB8O8R1yKF9eOA0gBX5PiwN4rXSu3unH64yNRxkoURDaKDlWYUiKTWv 8RZJtHv8f6mnH9f8qgoP41X7B0wI/+N2M1IM/VWzv9Zv7mkjL8utZjV34LFfWSqSRNQm ESig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=u7kNHlZ+H/mIMvxs7sr7Rst/3NZA7rT8YmZ3expKvIs=; b=H0+opT9oxcEdvkf5dHCf0rLL9rST/kQBATNYJ8Hjc0B9ZBtMdTacX7fKyPIuLWDU7D Kb0Z+WvZs7Z5X2aq2sWB6tc0zSMI8D0Mzj4qKk28HOW0wwp5ZaUToJfoGU8w5baN93eM NpXya+/VxiPmBnZ/ACnLvQm5mcjUtMeE+MhE1HaQZaIAhjnLM7TavyA0vPnCUBjZCZZn I7mi2NEoaTfd2VCbK4K7KgRPUcwm5xwhDXY/ay4TPl/MTCaydQ6trt3dQk3Y6Sbga4vM F+iX2UJKfVvp6pwD1S0x+E6BNPzuYJzbua4xHiFTPbGUFS70AJHsjOaXQIOTqilP2NZW zkDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d22si2074024oti.316.2020.02.21.13.18.20; Fri, 21 Feb 2020 13:18:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727912AbgBUVSB (ORCPT + 99 others); Fri, 21 Feb 2020 16:18:01 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:46596 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726683AbgBUVSB (ORCPT ); Fri, 21 Feb 2020 16:18:01 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 73F1420083; Fri, 21 Feb 2020 22:17:57 +0100 (CET) Date: Fri, 21 Feb 2020 22:17:56 +0100 From: Sam Ravnborg To: Kevin Tang Cc: airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, mark.rutland@arm.com, orsonzhai@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhang.lyra@gmail.com, baolin.wang@linaro.org Subject: Re: [PATCH RFC v3 0/6] Add Unisoc's drm kms module Message-ID: <20200221211756.GB3456@ravnborg.org> References: <1582271336-3708-1-git-send-email-kevin3.tang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582271336-3708-1-git-send-email-kevin3.tang@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=AmJ3NbpF4YMwtd5JfE4A:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kevin. On Fri, Feb 21, 2020 at 03:48:50PM +0800, Kevin Tang wrote: > ChangeList: > v1: > 1. only upstream modeset and atomic at first commit. > 2. remove some unused code; > 3. use alpha and blend_mode properties; > 3. add yaml support; > 4. remove auto-adaptive panel driver; > 5. bugfix > > v2: > 1. add sprd crtc and plane module for KMS, preparing for multi crtc&encoder > 2. remove gem drivers, use generic CMA handlers > 3. remove redundant "module_init", all the sub modules loading by KMS > > v3: > 1. multi crtc&encoder design have problem, so rollback to v1 > > Kevin Tang (6): > dt-bindings: display: add Unisoc's drm master bindings > drm/sprd: add Unisoc's drm kms master > dt-bindings: display: add Unisoc's dpu bindings > drm/sprd: add Unisoc's drm display controller driver > dt-bindings: display: add Unisoc's mipi dsi&dphy bindings > drm/sprd: add Unisoc's drm mipi dsi&dphy driver > > .../devicetree/bindings/display/sprd/dphy.yaml | 78 ++ > .../devicetree/bindings/display/sprd/dpu.yaml | 85 ++ > .../devicetree/bindings/display/sprd/drm.yaml | 38 + > .../devicetree/bindings/display/sprd/dsi.yaml | 101 ++ Good to see you are using DT Schema format. Consider to drop the sprd directory and then use filename with "sprd-" prefix. sprd.yaml sprd-dphy.yaml sprd-dpu.yaml sprd-dsi.yaml Sam