Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2341089ybv; Fri, 21 Feb 2020 13:42:10 -0800 (PST) X-Google-Smtp-Source: APXvYqyr7boUUAwU5shhzidpqRaigDak1kC5Ody1i9f6mLERQ1GL0T1xKahOLC/6J9vm5gfT/D8t X-Received: by 2002:a9d:7083:: with SMTP id l3mr28677295otj.193.1582321330367; Fri, 21 Feb 2020 13:42:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582321330; cv=none; d=google.com; s=arc-20160816; b=xSdQrwLmlOKCq0eHoHe4sWJuPt1jYh76xm9bU4CjrospYQp0WLhoc3g3EcvgF64Zey l5XGKzZ6BC6mHIOqYs4FSCe0cOjcuUNbsbkGbXksygGMpSqLg8XInczCGNg72gomtL8+ d/Ze0Cvzc78aCA1DCal8m2pEit2uWd8PNCvi0EmHn37nMVziwssd7yZ7Zf9zZZtHDYb5 U/k56HCzK77e+Y7cQB+O87NCo9T8jxFpoH7nUwgQKYcbih+b6P3Ifc21yeRSl6ZT6Ain OWa6a1OgkQScKCHsZbYWuC+7tgocomq8twGON4dk/pha9nrP/a5lYDsZoHsfBXPZOFt4 EQ3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=cMGR/haZssRaKZCfRU9VEkqweupYhb6lMTnB3ZGmDGo=; b=HKDVwoOyGCerKIO/+/JvwZ1vOtIitFaamqSO2Y8omG/yfhdxrJa26AAjw3bjwv9hYn diZ3pRSKM41oHRtqaQiJ3Psc5+dTh6dyjEUWnQ4xFMhzqbfHKF7dK6IEO5q0l8dVh7QT nXN/Ieo1LZfG1dSclsYyN2WeQWcNoG3Jm/Wk9ncW+sohlLti8l9YO9/M3zUsbjmSRNCY HZW23tc4LAD6xXxMlMGdy2lB7XI5XyauogYJDYDUOHVkj2pO8F/k5MXeg20GYVQEjXdM /kfvb5f0Ji/Y1ALua8g3kfvbzL2vyW+nayxCUmUbcQ7k96SMDv3Bpgjp+d9xbkfI7SqW om4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j11si1408912oie.254.2020.02.21.13.41.57; Fri, 21 Feb 2020 13:42:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728387AbgBUVls (ORCPT + 99 others); Fri, 21 Feb 2020 16:41:48 -0500 Received: from mga09.intel.com ([134.134.136.24]:53356 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726683AbgBUVls (ORCPT ); Fri, 21 Feb 2020 16:41:48 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Feb 2020 13:41:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,469,1574150400"; d="scan'208";a="437084627" Received: from vcostago-desk1.jf.intel.com (HELO vcostago-desk1) ([10.54.70.26]) by fmsmga006.fm.intel.com with ESMTP; 21 Feb 2020 13:41:45 -0800 From: Vinicius Costa Gomes To: Po Liu , "davem\@davemloft.net" , "hauke.mehrtens\@intel.com" , "gregkh\@linuxfoundation.org" , "allison\@lohutok.net" , "tglx\@linutronix.de" , "hkallweit1\@gmail.com" , "saeedm\@mellanox.com" , "andrew\@lunn.ch" , "f.fainelli\@gmail.com" , "alexandru.ardelean\@analog.com" , "jiri\@mellanox.com" , "ayal\@mellanox.com" , "pablo\@netfilter.org" , "linux-kernel\@vger.kernel.org" , "netdev\@vger.kernel.org" Cc: "simon.horman\@netronome.com" , Claudiu Manoil , Vladimir Oltean , Alexandru Marginean , Xiaoliang Yang , Roy Zang , Mingkai Hu , Jerry Huang , Leo Li , Po Liu Subject: Re: [v1,net-next, 1/2] ethtool: add setting frame preemption of traffic classes In-Reply-To: <20191127094517.6255-1-Po.Liu@nxp.com> References: <20191127094517.6255-1-Po.Liu@nxp.com> Date: Fri, 21 Feb 2020 13:43:33 -0800 Message-ID: <87a75br4ze.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Po Liu writes: > IEEE Std 802.1Qbu standard defined the frame preemption of port > traffic classes. This patch introduce a method to set traffic > classes preemption. Add a parameter 'preemption' in struct > ethtool_link_settings. The value will be translated to a binary, > each bit represent a traffic class. Bit "1" means preemptable > traffic class. Bit "0" means express traffic class. MSB represent > high number traffic class. > > If hardware support the frame preemption, driver could set the > ethernet device with hw_features and features with NETIF_F_PREEMPTION > when initializing the port driver. > > User can check the feature 'tx-preemption' by command 'ethtool -k > devname'. If hareware set preemption feature. The property would > be a fixed value 'on' if hardware support the frame preemption. > Feature would show a fixed value 'off' if hardware don't support > the frame preemption. > > Command 'ethtool devname' and 'ethtool -s devname preemption N' > would show/set which traffic classes are frame preemptable. > > Port driver would implement the frame preemption in the function > get_link_ksettings() and set_link_ksettings() in the struct ethtool_ops. > Any updates on this series? If you think that there's something that I could help, just tell. Cheers, -- Vinicius