Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <67d927c6161b15664b4a912ad34fc3a147109760.camel@surriel.com>
Subject: Re: [PATCH 2/2] mm,thp,compaction,cma: allow THP migration for CMA
 allocations
From:   Rik van Riel <riel@surriel.com>
To:     Zi Yan <ziy@nvidia.com>
Cc:     linux-kernel@vger.kernel.org, kernel-team@fb.com,
        akpm@linux-foundation.org, linux-mm@kvack.org, mhocko@kernel.org,
        vbabka@suse.cz, mgorman@techsingularity.net, rientjes@google.com,
        aarcange@redhat.com
Date:   Fri, 21 Feb 2020 17:35:15 -0500
In-Reply-To: <FF5B51C0-8D6E-47AB-82C8-020D5C522502@nvidia.com>
References: <cover.1582321645.git.riel@surriel.com>
         <3289dc5e6c4c3174999598d8293adf8ed3e93b57.1582321645.git.riel@surriel.com>
         <FF5B51C0-8D6E-47AB-82C8-020D5C522502@nvidia.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-N3fCwb3Sg4Ms25pOkexS"
User-Agent: Evolution 3.34.3 (3.34.3-1.fc31) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-N3fCwb3Sg4Ms25pOkexS
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2020-02-21 at 17:31 -0500, Zi Yan wrote:
> On 21 Feb 2020, at 16:53, Rik van Riel wrote:
>=20
> > +++ b/mm/compaction.c
> > @@ -894,12 +894,12 @@ isolate_migratepages_block(struct
> > compact_control *cc, unsigned long low_pfn,
> >=20
> >  		/*
> >  		 * Regardless of being on LRU, compound pages such as
> > THP and
> > -		 * hugetlbfs are not to be compacted. We can
> > potentially save
> > -		 * a lot of iterations if we skip them at once. The
> > check is
> > -		 * racy, but we can consider only valid values and the
> > only
> > -		 * danger is skipping too much.
> > +		 * hugetlbfs are not to be compacted most of the time.
> > We can
> > +		 * potentially save a lot of iterations if we skip them
> > at
> > +		 * once. The check is racy, but we can consider only
> > valid
> > +		 * values and the only danger is skipping too much.
> >  		 */
>=20
> Maybe add =E2=80=9Cwe do want to move them when allocating contiguous mem=
ory
> using CMA=E2=80=9D to help
> people understand the context of using cc->alloc_contig?

I can certainly do that.

I'll wait for feedback from other people to see if
more changes are wanted, and plan to post v2 by
Tuesday or so :)

--=20
All Rights Reversed.

--=-N3fCwb3Sg4Ms25pOkexS
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAl5QWyMACgkQznnekoTE
3oNG4Qf+NIlz59enImNBYGxlLc+a6Zw6OUfHlPKtL3xXWApRER8KxyzqehnAaDHD
2SyRCoaOObt30qL9telaoqfinbnZP57ud4cpuUrhZ6R/EPYvhWmPzOCuy/ON8n1q
J3+SPHSHIdpO0yLqECbkjh8yqqcgeH4MRzvAkUlJ5sl7zLzMUcXLM4lAMRIPP3bE
t3GEAVk32mZlYWVowBgYbqTXOPdvha/nJpqpQVOHqLXKDxho/GgXmBzBxqk/JTPd
HOHmd9VCOgdmMiylg+s+WVaEP4iGJkE+QrtywHtKVwvYCyOdcTp5d6vAK0Dv85a3
2CU5VojKKKWQL74efpSrnIrmMdGGqQ==
=/pq0
-----END PGP SIGNATURE-----

--=-N3fCwb3Sg4Ms25pOkexS--