Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2441376ybv; Fri, 21 Feb 2020 15:59:48 -0800 (PST) X-Google-Smtp-Source: APXvYqzZU9CWUc6Dh85K35bwN/xTqsXyUao44l9p9yeGPGv5TqWN89NypDek5V1T0/C49KEvFfqJ X-Received: by 2002:a05:6808:5d1:: with SMTP id d17mr4250977oij.129.1582329588700; Fri, 21 Feb 2020 15:59:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582329588; cv=none; d=google.com; s=arc-20160816; b=cqM8vQeB0DfP+O3YTRMlOWF3bbl/5Ekbfbxr6ONlK1afEafzQd7BmSJgBmYTZiI2dR uZJ8AwfJbuHwvAxm6zHpZfb4NAZEwsN4KjyPO4SbIczCfndisulO0Aj4UqB/a8q2t31w YLiyrmq2b+4eQL4y2UrOSkWMF+Wh6mIthKjs8Azoj0G5jQBLb7HCrU3fXBVnSK6Y9Lpx pOnCsxXU+V+wvJ5QRDS1/sr+G5XJMkHBiVCbVspvSHQb2MNstyArm7cULfV2el637qVf xMv9BbIbOEkl/qWTmoT3mrEMSC3ShYRfX3HJGXWM10479JcokdxExEJONN9YeA+F8UKG 7HxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:date:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=n0vjHVM2DuhbpPYoxUKATWLMuk00e4mnD7YQoWp4vUk=; b=jwcWXSsXK5AADAaE7ZHijrCzNQcLwETljMi4rbR9UIfYHxD40Z5BS26oK6AWLjLQOG N2SX83xTjdTna+uOy1jcIYG1YA2KUPDZvPsG/0m83GRbe5cndJmlkR1FhPOGeMbrDDiO Gh9JdgO7MZq0VjIH3TC3unGszpNvVxhxWYlCUcF/xeV9RQqoFbrSN7al9Fip9h0lOnwM nszgO9Nx7DSA8wbuKcJhra6C2B/8/jyVoOTnYovxRPKVDZCZmTQ2rVlJwFXIm68yggGu asIyhGEaNO5JS9ZbL3lF6hmECaO+9oN2t4q0uw0zFJItReY+z/U3/zfSgbVf759thO6f yDzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="OIc0H/6F"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k205si1578513oib.64.2020.02.21.15.59.36; Fri, 21 Feb 2020 15:59:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="OIc0H/6F"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729798AbgBUX5x (ORCPT + 99 others); Fri, 21 Feb 2020 18:57:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:35302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726802AbgBUX5x (ORCPT ); Fri, 21 Feb 2020 18:57:53 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92B862068F; Fri, 21 Feb 2020 23:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582329472; bh=n0vjHVM2DuhbpPYoxUKATWLMuk00e4mnD7YQoWp4vUk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=OIc0H/6FEBoyV45z3mlrdQOZGlTjYb5cKOX8tyqwAiMmkIlY4O9/GD+thIk3aXxsG jIjtFlVnom2DIHf7DacvmaOFcDdyLjsT6f8EY9Pmpo3a9lwbkeFP/VA7/hGESogbek ZcPYRqs8Jucy3hrPeOGTK7yh2xCobn+qyOSRBAc4= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1582266716-19821-1-git-send-email-Anson.Huang@nxp.com> References: <1582266716-19821-1-git-send-email-Anson.Huang@nxp.com> Subject: Re: [PATCH] clk: imx: pll14xx: Return error if pll type is invalid From: Stephen Boyd Cc: Linux-imx@nxp.com To: Anson Huang , festevam@gmail.com, kernel@pengutronix.de, leonard.crestez@nxp.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, peng.fan@nxp.com, ping.bai@nxp.com, s.hauer@pengutronix.de, shawnguo@kernel.org, yuehaibing@huawei.com Date: Fri, 21 Feb 2020 15:57:51 -0800 Message-ID: <158232947182.258574.584668677246692139@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Anson Huang (2020-02-20 22:31:56) > When pll type is invalid, ONLY output error message is NOT enough, > should return error immediately. >=20 > Signed-off-by: Anson Huang > --- Reviewed-by: Stephen Boyd