Message-ID: <43EDA546.7020103@s5r6.in-berlin.de>
Date: Sat, 11 Feb 2006 09:50:14 +0100
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040914
MIME-Version: 1.0
To: Andrew Morton <akpm@osdl.org>
CC: Lee Revell <rlrevell@joe-job.com>, miles.lane@gmail.com,
       linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net,
       Dave Jones <davej@redhat.com>
Subject: Re: 2.6.16-rc2-mm1 -- BUG: warning at drivers/ieee1394/ohci1394.c:235/get_phy_reg()
References: <a44ae5cd0602101207s4b2d61d7nc6705067b7913322@mail.gmail.com>	<20060210122131.4b98cfb4.akpm@osdl.org>	<1139624931.19342.46.camel@mindpipe> <20060210203715.57b39b0d.akpm@osdl.org>
In-Reply-To: <20060210203715.57b39b0d.akpm@osdl.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 927
Lines: 21

Andrew Morton wrote:
>>>That's a -mm-only warning telling you that get_phy_reg() is doing a
>>>one-millisecond-or-more busywait while local interrupts are disabled.
...
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16-rc2/2.6.16-rc2-mm1/broken-out/debug-warn-if-we-sleep-in-an-irq-for-a-long-time.patch

So that's why when I heard of this issue the first time, it was about 
Redhat/ Fedora Core kernels. But even though this issue is very old, no 
bug report got through to linux1394-devel until December 2005.

BTW, why not swap the order of expressions:
		WARN_ON(!(warned++) && in_irq()); 	\
-- 
Stefan Richter
-=====-=-==- --=- -=-==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/