Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751304AbWBKJEI (ORCPT ); Sat, 11 Feb 2006 04:04:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751310AbWBKJEI (ORCPT ); Sat, 11 Feb 2006 04:04:08 -0500 Received: from smtp.osdl.org ([65.172.181.4]:4062 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751304AbWBKJEF (ORCPT ); Sat, 11 Feb 2006 04:04:05 -0500 Date: Sat, 11 Feb 2006 01:03:06 -0800 From: Andrew Morton To: Stefan Richter Cc: rlrevell@joe-job.com, miles.lane@gmail.com, linux-kernel@vger.kernel.org, linux1394-devel@lists.sourceforge.net, davej@redhat.com Subject: Re: 2.6.16-rc2-mm1 -- BUG: warning at drivers/ieee1394/ohci1394.c:235/get_phy_reg() Message-Id: <20060211010306.796cd1e2.akpm@osdl.org> In-Reply-To: <43EDA546.7020103@s5r6.in-berlin.de> References: <20060210122131.4b98cfb4.akpm@osdl.org> <1139624931.19342.46.camel@mindpipe> <20060210203715.57b39b0d.akpm@osdl.org> <43EDA546.7020103@s5r6.in-berlin.de> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 454 Lines: 11 Stefan Richter wrote: > > BTW, why not swap the order of expressions: > WARN_ON(!(warned++) && in_irq()); \ Because then it'd generate a warning every 4 billionth time through. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/