Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 22 Feb 2020 00:02:18 -0700
From:   Nathan Chancellor <natechancellor@gmail.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     Arvind Sankar <nivedita@alum.mit.edu>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
        Michael Matz <matz@suse.de>, Fangrui Song <maskray@google.com>
Subject: Re: [PATCH 2/2] x86/boot/compressed: Remove unnecessary sections
 from bzImage
Message-ID: <20200222070218.GA27571@ubuntu-m2-xlarge-x86>
References: <20200109150218.16544-1-nivedita@alum.mit.edu>
 <20200109150218.16544-2-nivedita@alum.mit.edu>
 <20200222050845.GA19912@ubuntu-m2-xlarge-x86>
 <20200222065521.GA11284@zn.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200222065521.GA11284@zn.tnic>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Feb 22, 2020 at 07:55:21AM +0100, Borislav Petkov wrote:
> On Fri, Feb 21, 2020 at 10:08:45PM -0700, Nathan Chancellor wrote:
> > On Thu, Jan 09, 2020 at 10:02:18AM -0500, Arvind Sankar wrote:
> > > Discarding the sections that are unused in the compressed kernel saves
> > > about 10 KiB on 32-bit and 6 KiB on 64-bit, mostly from .eh_frame.
> > > 
> > > Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
> > > ---
> > >  arch/x86/boot/compressed/vmlinux.lds.S | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S
> > > index 508cfa6828c5..12a20603d92e 100644
> > > --- a/arch/x86/boot/compressed/vmlinux.lds.S
> > > +++ b/arch/x86/boot/compressed/vmlinux.lds.S
> > > @@ -73,4 +73,9 @@ SECTIONS
> > >  #endif
> > >  	. = ALIGN(PAGE_SIZE);	/* keep ZO size page aligned */
> > >  	_end = .;
> > > +
> > > +	/* Discard all remaining sections */
> > > +	/DISCARD/ : {
> > > +		*(*)
> > > +	}
> > >  }
> > > -- 
> > > 2.24.1
> > > 
> > 
> > This patch breaks linking with ld.lld:
> > 
> > $ make -j$(nproc) -s CC=clang LD=ld.lld O=out.x86_64 distclean defconfig bzImage
> > ld.lld: error: discarding .shstrtab section is not allowed
> 
> Well, why is it not allowed? And why isn't the GNU linker complaining?

No idea, unfortunately I am not a linker expert and the patch that
changes this in lld does not really explain why it adds this
restriction:

https://github.com/llvm/llvm-project/commit/1e799942b37d04f30b73f6a9e792d551dadafeea

CC'ing Fangrui as I don't know George's email and he is usually
responsive to ld.lld issues/questions.

Cheers,
Nathan