Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 22 Feb 2020 11:05:45 +0100
From:   Thomas Bogendoerfer <tbogendoerfer@suse.de>
To:     Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v4] leds: add SGI IP30 led support
Message-Id: <20200222110545.fc96683543cb0dd538e5be82@suse.de>
In-Reply-To: <49524a9a-910a-9f1a-bc10-d78080a16d46@gmail.com>
References: <20200221111120.28799-1-tbogendoerfer@suse.de>
        <49524a9a-910a-9f1a-bc10-d78080a16d46@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 21 Feb 2020 21:31:04 +0100
Jacek Anaszewski <jacek.anaszewski@gmail.com> wrote:


> > +	if (num == 0)
> > +		data->cdev.name = "white:indicator";
> > +	else
> > +		data->cdev.name = "red:indicator";
> 
> Why indicator? Whereas it sounds quite generic it is used in the LED
> subsystem specifically for naming indicator LEDs, that are often
> found on flash LED controllers and are designed to indicate camera
> sensor activity.

ok, ic.

> If it is on the front panel of SGI Octane workstations then its
> function is perhaps well known?

the red LED is clearly a fault led. The white LED will be switch on
after system diagnostic was successfull. Nothing from common.h really
fits that, maybe status ?

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 36809 (AG N?rnberg)
Gesch?ftsf?hrer: Felix Imend?rffer