Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Michael Walle <michael@walle.cc>
To:     olteanv@gmail.com
Cc:     andrew@lunn.ch, davem@davemloft.net, devicetree@vger.kernel.org,
        f.fainelli@gmail.com, linux-kernel@vger.kernel.org,
        mark.rutland@arm.com, netdev@vger.kernel.org, robh+dt@kernel.org,
        shawnguo@kernel.org, vivien.didelot@gmail.com,
        Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v2 net-next/devicetree 5/5] arm64: dts: fsl: ls1028a: enable switch PHYs on RDB
Date:   Sat, 22 Feb 2020 12:41:36 +0100
Message-Id: <20200222114136.595-1-michael@walle.cc>
In-Reply-To: <20200219151259.14273-6-olteanv@gmail.com>
References: <20200219151259.14273-6-olteanv@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

> Link the switch PHY nodes to the central MDIO controller PCIe endpoint
> node on LS1028A (implemented as PF3) so that PHYs are accessible via
> MDIO.
> 
> Enable SGMII AN on the Felix PCS by telling PHYLINK that the VSC8514
> quad PHY is capable of in-band-status.
> 
> The PHYs are used in poll mode due to an issue with the interrupt line
> on current revisions of the LS1028A-RDB board.
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
> Signed-off-by: Alex Marginean <alexandru.marginean@nxp.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
> Changes in v2:
> None.
> 
>  .../boot/dts/freescale/fsl-ls1028a-rdb.dts    | 51 +++++++++++++++++++
>  1 file changed, 51 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> index afb55653850d..9353c00e46a7 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts
> @@ -194,6 +194,57 @@
>  	status = "disabled";
>  };
>  
> +&enetc_mdio_pf3 {
> +	/* VSC8514 QSGMII quad PHY */
> +	qsgmii_phy0: ethernet-phy@10 {
> +		reg = <0x10>;
> +	};
> +
> +	qsgmii_phy1: ethernet-phy@11 {
> +		reg = <0x11>;
> +	};
> +
> +	qsgmii_phy2: ethernet-phy@12 {
> +		reg = <0x12>;
> +	};
> +
> +	qsgmii_phy3: ethernet-phy@13 {
> +		reg = <0x13>;
> +	};
> +};
> +
> +&mscc_felix_port0 {
> +	status = "okay";
status should be the last property, correct?

-michael

> +	label = "swp0";
> +	managed = "in-band-status";
> +	phy-handle = <&qsgmii_phy0>;
> +	phy-mode = "qsgmii";
> +};
> +
> +&mscc_felix_port1 {
> +	status = "okay";
> +	label = "swp1";
> +	managed = "in-band-status";
> +	phy-handle = <&qsgmii_phy1>;
> +	phy-mode = "qsgmii";
> +};
> +
> +&mscc_felix_port2 {
> +	status = "okay";
> +	label = "swp2";
> +	managed = "in-band-status";
> +	phy-handle = <&qsgmii_phy2>;
> +	phy-mode = "qsgmii";
> +};
> +
> +&mscc_felix_port3 {
> +	status = "okay";
> +	label = "swp3";
> +	managed = "in-band-status";
> +	phy-handle = <&qsgmii_phy3>;
> +	phy-mode = "qsgmii";
> +};
> +
>  &sai4 {
>  	status = "okay";
>  };
> -- 
> 2.17.1