Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751310AbWBKKq1 (ORCPT ); Sat, 11 Feb 2006 05:46:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751314AbWBKKq1 (ORCPT ); Sat, 11 Feb 2006 05:46:27 -0500 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:32452 "EHLO ebiederm.dsl.xmission.com") by vger.kernel.org with ESMTP id S1751310AbWBKKq0 (ORCPT ); Sat, 11 Feb 2006 05:46:26 -0500 To: Kirill Korotaev Cc: linux-kernel@vger.kernel.org, vserver@list.linux-vserver.org, Herbert Poetzl , "Serge E. Hallyn" , Alan Cox , Dave Hansen , Arjan van de Ven , Suleiman Souhlal , Hubertus Franke , Cedric Le Goater , Kyle Moffett , Greg , Linus Torvalds , Andrew Morton , Greg KH , Rik van Riel , Alexey Kuznetsov , Andrey Savochkin , Kirill Korotaev , Andi Kleen , Benjamin Herrenschmidt , Jeff Garzik , Trond Myklebust , Jes Sorensen Subject: Re: [RFC][PATCH 04/20] pspace: Allow multiple instaces of the process id namespace References: <43ECF803.8080404@sw.ru> From: ebiederm@xmission.com (Eric W. Biederman) Date: Sat, 11 Feb 2006 03:43:42 -0700 In-Reply-To: <43ECF803.8080404@sw.ru> (Kirill Korotaev's message of "Fri, 10 Feb 2006 23:30:59 +0300") Message-ID: User-Agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 842 Lines: 23 Kirill Korotaev writes: >> + >> +static inline int pspace_task_visible(struct pspace *pspace, struct > task_struct *tsk) >> +{ >> + return (tsk->pspace == pspace) || >> + ((tsk->pspace->child_reaper.pspace == pspace) && >> + (tsk->pspace->child_reaper.task == tsk)); > <<< the logic with child_reaper which can be somehow partly inside pspace... and > this check is not that abvious. This is the check for what shows up in /proc. Given that is how I have explicitly documented things to work, (the init process straddles the boundary) I fail to see how it is not obvious. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/