Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <645fcbdfdd1321ff3e0afaafe7eccfd034e57748.camel@bonedaddy.net>
Subject: Re: [PATCH 0/1] coredump: Fix null pointer dereference when
 kernel.core_pattern is "|"
From:   Paul Wise <pabs3@bonedaddy.net>
To:     Matthew Ruffell <matthew.ruffell@canonical.com>,
        viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Neil Horman <nhorman@tuxdriver.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jakub Wilk <jwilk@jwilk.net>
In-Reply-To: <20200220051015.14971-1-matthew.ruffell@canonical.com>
References: <20200220051015.14971-1-matthew.ruffell@canonical.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-NVKkbFdhyq8AeNl+7/qp"
Date:   Sat, 22 Feb 2020 22:17:14 +0800
MIME-Version: 1.0
User-Agent: Evolution 3.34.1-4 
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-NVKkbFdhyq8AeNl+7/qp
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2020-02-20 at 18:10 +1300, Matthew Ruffell wrote:

> A user was setting their kernel.core_pattern to "|" to disable coredumps

Hmm, that doesn't seem to be the right way to do that :)

> and encountered the following null pointer dereference

Thanks for forwarding that. I've bounced your mails to a few extra
folks, please include them in CC in future. Neil last touched the
coredump pipe stuff before me, Jakub reported the spaces in
core_pattern issue and Andrew merged my patch.

The patch seems like a reasonable approach but I don't have much
experience with Linux kernel internals.

--=20
bye,
pabs

https://bonedaddy.net/pabs3/

--=-NVKkbFdhyq8AeNl+7/qp
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEYQsotVz8/kXqG1Y7MRa6Xp/6aaMFAl5RN+cACgkQMRa6Xp/6
aaOyWg//b4T0PTtUcImVqaVTd4AamfBETQG8e6Sg0dzSUWam1aubpGwPOtjVCLu9
fn0DxK44nMiksq9PO7m/9Fkg1PxgurzVvMNY7J/gO1qAH5xsZ5FJlnj5obCzTabt
dZSKmSKMMX80tMLq7HuXPHgGKQmHJofGf4Kl4pFb25KZQuP7S/z5B4q8PT2Z5875
EvJqbDUONam2EfUdLUgWTPEzfyoPy6WNajc4qjLNlG4HbRMkRaVqfdAK/R6uKjoH
gVu1yd0j+FPfez4G4q1ZEoFiIdvf0LbzV8C6gfz/f9VN1ND8kQQSWWOVhQk35eAI
umqUd1Z3/9N7/Ut16XnG7tyzAxkdFeBjrPsEbr85PX/X1/rCOnyg6uHyiovyAGrj
tbJE4ZzX9YUJ28ezsGWlviCJjfO+KmSy7M/fuEdVVOdcBrSMN8QRoO9b1W9ijRFF
URaUp077Fr+Z5wkGmuzQJUzb19XvPDa+aeeExRP1t6Wmn3urrB3+igMczTNfosYX
ejTZPYmZn4gsYsS7CDhYaXLJw8FoBIfebC0Af6ij1G0Qly5hJmJgwOHNjpborpV4
ezxssrXO55xVa40B/dIkOUvSys4hqgk4IVHMj/iSjtg1TJ1ceEReUBueiotUAQqk
tQAcdjuD6oJFOzS7d+g4XoRsC6X+crCpTzwJxppU+UJTgY4oiIs=
=klPT
-----END PGP SIGNATURE-----

--=-NVKkbFdhyq8AeNl+7/qp--