Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp526978ybv; Sat, 22 Feb 2020 08:36:39 -0800 (PST) X-Google-Smtp-Source: APXvYqxyJAWiZJxJre/zauQhePwfLsxnoKH0udxiQW/zaLR1LW6hNl4/if+cDQwDpe1A06xPR6b+ X-Received: by 2002:aca:100e:: with SMTP id 14mr6787697oiq.88.1582389399440; Sat, 22 Feb 2020 08:36:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582389399; cv=none; d=google.com; s=arc-20160816; b=Ci6gnOdR3fuTdAo2oe2Ilp1A0Sm/RPDaSPdoOOigWJAIjzY0MNA+MBH3cN7rQsDram CBeodQ04fWIj0XUSm+2bY0Qw6ML42tc6ZMHYE8RQQRNr++gCrukQ9YHS2xjuRZWMNE0G nb2kzaXR/9Vi863GVWGAzd/4J24O+ojd0sS9tuPfsgV9uwFpXgJk3kQRqDhmP+vZuoWF lCAnBNKGZGMnb8n0FvcCdRfkgJwhZhWP4M5NqkVyhHk9mjix8Ai4C3dGbse6M1VUMztd /twsXMlRkM7/ZP0N1LWk8F1lA99vX5dZ71z7hdRCTVt+2z4DiTMgJGRMciYm65ZEqsuz AmBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=dgr2+PYADNum4DteZn/qV6ZF6PBZFAZDhG/JhZudkKM=; b=PkVTlcFdeo5X5qWnHxw4JTSc/u8hzWeRzb8IF3FdVtd/Sw/AQjn9bV4tz0BC+3UxZT 9HoAMBYSITGdSLmf4Yp8yCkipuSTxzYess94MuD2RHYSu5NoosTcL3am9RIeJTgSimr0 uo0B2pTUzEvmZqIsYJtF3RCufUpbI+cH8QwqkLkP2HWfY9SqhU+pgbX4+0uHYIrYs1Ud vOChbDpuFyAp1R0BtOEdJi9iNM71xT5WOkqDARzAiLHHYVXSF8rsffmhrvVNOcxM2ROL KDc8QV9IqJv6DFFJRR5pQK5N4jRRCSGaMyGpUXLFS0UB1UhLFMBoksK0mzLMV0e/h2VX HQkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Jt5uKsl7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m20si3545662otf.143.2020.02.22.08.36.26; Sat, 22 Feb 2020 08:36:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Jt5uKsl7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726603AbgBVQgP (ORCPT + 99 others); Sat, 22 Feb 2020 11:36:15 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:51515 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725976AbgBVQgP (ORCPT ); Sat, 22 Feb 2020 11:36:15 -0500 Received: by mail-wm1-f67.google.com with SMTP id t23so4892408wmi.1; Sat, 22 Feb 2020 08:36:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dgr2+PYADNum4DteZn/qV6ZF6PBZFAZDhG/JhZudkKM=; b=Jt5uKsl7aK76WTz8N51DcSYAaSAFHEfV/VI+mB4cQfkv75wz5VKof7odueKIzHoO5b AfhRpmBCWHqq4YksJaQGdID2Tbjwi1Px1xVac+m3NHcNMxQZZb4PuhoqoULFItikYiC5 qFPj/O7QWoeCeqUYYfmTLJj1PYLlIIlWevFTOKR6esofDvxGY9D0POtSKIC62H/bg9sI iIN80kDIpbTS+fRAPIqCWzDC+Yt5odLpDTB080zxOj+L935H8XC9lKBf96N5W+btgb/T AENOMhaGWfaZppZK+DnHCgTJJfdat2eXtbss2Tsn//wuFagF8NIfJuDaYUkfZtz8uGbc ++Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=dgr2+PYADNum4DteZn/qV6ZF6PBZFAZDhG/JhZudkKM=; b=LgyCVmD+1asIK7DPJVXuM2N1jdvprys76nB11qdBLw9dczFv98cDCnMTidxTxEhWXD 2TJPAyskJIiCiZYXikiVkv9D94t3lS+n5kdJODa7aTL+3kH03ZFr6pF4JiKAzqWKHLNV 6iEAzVNw7qOk2VBnqkso8o+VAxgx0fX416kUx1jXQCxJR4dxj67GpYWjkIj+BiqRKfKx t572sjAH63AmytDzgYJIL+qW6XjNx4gVJ45fb2brbpIgZr/Qjw7/roNdgXCfnOoaXdT7 YXpE0/oXCXXDrsYKlBlQt40A39DBjWB+EKSa0l/D+FPvEpjab78O1rDFpj0w8LuiUGZh fKRA== X-Gm-Message-State: APjAAAVXbSkpjrIITjOZl63jyHXTTAQ+3h9+e5QqrT416dkkJQCnrW6O 4vO0yMI+k1VJSjTapSQJ+BvP6rzG X-Received: by 2002:a05:600c:290e:: with SMTP id i14mr10834180wmd.24.1582389371979; Sat, 22 Feb 2020 08:36:11 -0800 (PST) Received: from [192.168.1.23] (affo138.neoplus.adsl.tpnet.pl. [95.49.144.138]) by smtp.gmail.com with ESMTPSA id h2sm9409509wrt.45.2020.02.22.08.36.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Feb 2020 08:36:11 -0800 (PST) Subject: Re: [PATCH v4] leds: add SGI IP30 led support To: Thomas Bogendoerfer Cc: Pavel Machek , Dan Murphy , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org References: <20200221111120.28799-1-tbogendoerfer@suse.de> <49524a9a-910a-9f1a-bc10-d78080a16d46@gmail.com> <20200222110545.fc96683543cb0dd538e5be82@suse.de> From: Jacek Anaszewski Autocrypt: addr=jacek.anaszewski@gmail.com; prefer-encrypt=mutual; keydata= xsFNBFWjfaEBEADd66EQbd6yd8YjG0kbEDT2QIkx8C7BqMXR8AdmA1OMApbfSvEZFT1D/ECR eWFBS8XtApKQx1xAs1j5z70k3zebk2eeNs5ahxi6vM4Qh89vBM46biSKeeX5fLcv7asmGb/a FnHPAfQaKFyG/Bj9V+//ef67hpjJWR3s74C6LZCFLcbZM0z/wTH+baA5Jwcnqr4h/ygosvhP X3gkRzJLSFYekmEv+WHieeKXLrJdsUPUvPJTZtvi3ELUxHNOZwX2oRJStWpmL2QGMwPokRNQ 29GvnueQdQrIl2ylhul6TSrClMrKZqOajDFng7TLgvNfyVZE8WQwmrkTrdzBLfu3kScjE14Q Volq8OtQpTsw5570D4plVKh2ahlhrwXdneSot0STk9Dh1grEB/Jfw8dknvqkdjALUrrM45eF FM4FSMxIlNV8WxueHDss9vXRbCUxzGw37Ck9JWYo0EpcpcvwPf33yntYCbnt+RQRjv7vy3w5 osVwRR4hpbL/fWt1AnZ+RvbP4kYSptOCPQ+Pp1tCw16BOaPjtlqSTcrlD2fo2IbaB5D21SUa IsdZ/XkD+V2S9jCrN1yyK2iKgxtDoUkWiqlfRgH2Ep1tZtb4NLF/S0oCr7rNLO7WbqLZQh1q ShfZR16h7YW//1/NFwnyCVaG1CP/L/io719dPWgEd/sVSKT2TwARAQABzS1KYWNlayBBbmFz emV3c2tpIDxqYWNlay5hbmFzemV3c2tpQGdtYWlsLmNvbT7Cwa8EEwEIAEICGwMHCwkIBwMC AQYVCAIJCgsDFgIBAh4BAheAAhkBFiEEvx38ClaPBfeVdXCQvWpQHLeLfCYFAl5O5twFCRIR arsAIQkQvWpQHLeLfCYWIQS/HfwKVo8F95V1cJC9alAct4t8JhIgEACtWz3zR5uxaU/GozHh iZfiyUTomQpGNvAtjjZE6UKO/cKusCcvOv0FZbfGDajcMIU8f3FUxJdybrY86KJ9a3tOddal KtB2of3/Ot/EIQjpQb28iLoY8AWnf9G4LQZtoXHiUcOAVPkKgCFnz1IENK3uvyCB9c9//KhE cRZkeAIE2sTmcI4k7/dNHpRI4nha/ZytPwTdM3BjAfxxQI5nMLptm1ksEBI7W1SDOnY3dG2J QWmqpxIefjgyiy0aU+jAw1x3RdZrokVD8OCJiJM8+Z36imarEzqIRQLh+sDNLfV3wEaBn/HU 0Vj6VrRyW2K0jAYToRFD3Ay/eGSfOOAEr/LoMr3NBTDkRLEWdOozllOwADEY9wH0BLHMp2WI hXGOStNiroIEhW2/E0udFJo9b3VoOWKWl+zcUP/keLxVUCXhpmeS7VpSkqsrCVqTVkEc8AXq xhJXeIQJC/XRpCYFc3pFUlVCFViF1ZU2OzE8TndRzzD8e/9ETrJ1GAYa78tNopYhY6AbGlv4 U01nIC93bK07O4IhtBAKsiUz3JPX/KA/dXJOC86qP373cVWVYPvZW+KOya9/7rz0MGR1az9G HqJB7q7DVcCQKt9Egae/goznnXbET6ivCNKbqkH3n/JpiPIxkaXVrbn3QlVtzYpROsS/pCOp 5Evig7kql5L0aYJIZs4zBFsKioYWCSsGAQQB2kcPAQEHQFCKEG5pCgebryz66pTa9eAo+r8y TkMEEnG8UR5oWFt3wsIbBBgBCAAgFiEEvx38ClaPBfeVdXCQvWpQHLeLfCYFAlsKioYCGwIA rwkQvWpQHLeLfCaNIAQZFggAHRYhBBTDHErITmX+em3wBGIQbFEb9KXbBQJbCoqGACEJEGIQ bFEb9KXbFiEEFMMcSshOZf56bfAEYhBsURv0pdvELgD/U+y3/hsz0bIjMQJY0LLxM/rFY9Vz 1L43+lQHXjL3MPsA/1lNm5sailsY7aFBVJxAzTa8ZAGWBdVaGo6KCvimDB8GFiEEvx38ClaP BfeVdXCQvWpQHLeLfCbuOg/+PH6gY6Z1GiCzuYb/8f7D0NOcF8+md+R6KKiQZij/6G5Y7lXQ Bz21Opl4Vz/+39i5gmfBa9LRHH4ovR9Pd6H0FCjju4XjIOJkiJYs2HgCCm6nUxRJWzPgyMPS VbqCG2ctwaUiChUdbS+09bWb2MBNjIlI4b8wLWIOtxhyn25Vifm0p+QR5A2ym4bqJJ9LSre1 qM8qdPWcnExPFU4PZFYQgZ9pX1Jyui73ZUP94L7/wg1GyJZL3ePeE4ogBXldE0g0Wq3ORqA9 gA/yvrCSyNKOHTV9JMGnnPGN+wjBYMPMOuqDPC/zcK+stdFXc6UbUM1QNgDnaomvjuloflAx aYdblM26gFfypvpFb8czcPM+BP6X6vWk+Mw9+8vW3tyK9lSg+43OjIWlBGPpO9aLZsYYxAqv J5iSxcbbOLb5q8wWct6U7EZ1RnuOfVInoBttrlYvdWtcI/5NQTptkuB/DyRhrxBJc/fKzJ4w jS2ikcWe0FnxrQpcE2yqoUIFaZMdd/Cx9bRWAGZG087t5dUHJuMnVVcpHZFnHBKr8ag1eH/K tFdDFtyln5A/f9O22xsV0pyJni7e2z7lTBitrQFG69vnVGJlHbBE2dR4GddZqAlVOUbtEcE7 /aMk4TrCtx0IyOzQiLA81aaJWhkD3fRO8cDlR4YQ3F0aqjYy8x1EnnhhohHOwU0EVaN9oQEQ AMPNymBNoCWc13U6qOztXrIKBVsLGZXq/yOaR2n7gFbFACD0TU7XuH2UcnwvNR+uQFwSrRqa EczX2V6iIy2CITXKg5Yvg12yn09gTmafuoIyKoU16XvC3aZQQ2Bn3LO2sRP0j/NuMD9GlO37 pHCVRpI2DPxFE39TMm1PLbHnDG8+lZql+dpNwWw8dDaRgyXx2Le542CcTBT52VCeeWDtqd2M wOr4LioYlfGfAqmwcwucBdTEBUxklQaOR3VbJQx6ntI2oDOBlNGvjnVDzZe+iREd5l40l+Oj TaiWvBGXkv6OI+wx5TFPp+BM6ATU+6UzFRTUWbj+LqVA/JMqYHQp04Y4H5GtjbHCa8abRvBw IKEvpwTyWZlfXPtp8gRlNmxYn6gQlTyEZAWodXwE7CE+KxNnq7bPHeLvrSn8bLNK682PoTGr 0Y00bguYLfyvEwuDYek1/h9YSXtHaCR3CEj4LU1B561G1j7FVaeYbX9bKBAoy/GxAW8J5O1n mmw7FnkSHuwO/QDe0COoO0QZ620Cf9IBWYHW4m2M2yh5981lUaiMcNM2kPgsJFYloFo2XGn6 lWU9BrWjEoNDhHZtF+yaPEuwjZo6x/3E2Tu3E5Jj0VpVcE9U1Zq/fquDY79l2RJn5ENogOs5 +Pi0GjVpEYQVWfm0PTCxNPOzOzGR4QB3BNFvABEBAAHCwZMEGAEIACYCGwwWIQS/HfwKVo8F 95V1cJC9alAct4t8JgUCXk7nGAUJEhFq9wAhCRC9alAct4t8JhYhBL8d/ApWjwX3lXVwkL1q UBy3i3wmVBwP/RNNux3dC513quZ0hFyU6ZDTxbiafprLN2PXhmLslxPktJgW/xO5xp16OXkW YgNI/TKxj3+oSu+MhEAhAFA2urFWHyqedfqdndQTzbv4yqNuyhGupzPBWNSqqJ2NwKJc9f2R wqYTXVYIO+6KLa32rpl7xvJISkx06s70lItFJjyOf6Hn1y5RBMwQN9hP2YxLhYNO3rmlNSVy 7Z/r95lZTDnnUCuxBZxnjx/pMHJ8LZtKY0t7D0esA+zYGUrmoAGUpNWEBP+uSL+f8rhjSAL0 HgoRL39ixg5Bm0MzJn9z3or++Pl5bRnSvHy6OKh7rzTjCwaGoZD+6LHBwPFPlmInX1H+yHrX lu1uPAdqG5xcsZAZFTxBRMEnYu1yYebDSA9x+iulggMZQcWC2GvHCaKIpKcFY8XCxk7Hbl5c 8hcPKWOy16NLO6Y66Ws4kMedXuNUHe4zBLVlRbcYUdgT9Brw8nxmxu3KhEVsJkwOpXLUDuzo hQNfg9em95lpAK+VOTocke8PSESy3GbEtmoMueW3caSeDHb5dRP6WrndaYhEOzAA/KjuPU7J LMXOABOMIq+R38y7e2B3TnVDCrccdZDseFPUWmH0cGCGihH/j2UZG+PImrSDCh3h5MedVHGo sI62tmWm0q6lrljwSZmMZ30w1QaGmdFpI3Q6V+nZ7TZldI3x Message-ID: <7bd606df-a5b6-6f05-43ef-b6691e16be94@gmail.com> Date: Sat, 22 Feb 2020 17:36:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200222110545.fc96683543cb0dd538e5be82@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/22/20 11:05 AM, Thomas Bogendoerfer wrote: > On Fri, 21 Feb 2020 21:31:04 +0100 > Jacek Anaszewski wrote: > > >>> + if (num == 0) >>> + data->cdev.name = "white:indicator"; >>> + else >>> + data->cdev.name = "red:indicator"; >> >> Why indicator? Whereas it sounds quite generic it is used in the LED >> subsystem specifically for naming indicator LEDs, that are often >> found on flash LED controllers and are designed to indicate camera >> sensor activity. > > ok, ic. > >> If it is on the front panel of SGI Octane workstations then its >> function is perhaps well known? > > the red LED is clearly a fault led. We have fault in common LED names, so you can go for it. > The white LED will be switch on > after system diagnostic was successfull. Nothing from common.h really > fits that, maybe status ? I think that "system" would be OK. There are some LED drivers and DT bindings that use "system" in the LED names. I even proposed that also in the initial versions of my patch set standardizing LED naming but dropped it afterwards, since it its use was not clear. But now we have good use case for it. And one more thing: please add definitions for LEDs in your driver like: #define IP30_LED_SYSTEM 0 #define IP30_LED_FAULT 1 and use them instead of bare 0 and 1 numbers. -- Best regards, Jacek Anaszewski