Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 22 Feb 2020 11:14:13 -0700
From:   Nathan Chancellor <natechancellor@gmail.com>
To:     Arvind Sankar <nivedita@alum.mit.edu>
Cc:     Fangrui Song <maskray@google.com>, Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
        Michael Matz <matz@suse.de>
Subject: Re: [PATCH] x86/boot/compressed: Fix compressed kernel linking with
 lld
Message-ID: <20200222181413.GA22627@ubuntu-m2-xlarge-x86>
References: <20200222164419.GB3326744@rani.riverdale.lan>
 <20200222171859.3594058-1-nivedita@alum.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200222171859.3594058-1-nivedita@alum.mit.edu>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Feb 22, 2020 at 12:18:59PM -0500, Arvind Sankar wrote:
> Commit TBD ("x86/boot/compressed: Remove unnecessary sections from
> bzImage") discarded unnecessary sections with *(*). While this works
> fine with the bfd linker, lld tries to also discard essential sections
> like .shstrtab, .symtab and .strtab, which results in the link failing
> since .shstrtab is required by the ELF specification. .symtab and
> .strtab are also necessary to generate the zoffset.h file for the
> bzImage header.
> 
> Since the only sizeable section that can be discarded is .eh_frame,
> restrict the discard to only .eh_frame to be safe.
> 
> Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
> ---
> Sending as a fix on top of tip/x86/boot.
> 
>  arch/x86/boot/compressed/vmlinux.lds.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S
> index 12a20603d92e..469dcf800a2c 100644
> --- a/arch/x86/boot/compressed/vmlinux.lds.S
> +++ b/arch/x86/boot/compressed/vmlinux.lds.S
> @@ -74,8 +74,8 @@ SECTIONS
>  	. = ALIGN(PAGE_SIZE);	/* keep ZO size page aligned */
>  	_end = .;
>  
> -	/* Discard all remaining sections */
> +	/* Discard .eh_frame to save some space */
>  	/DISCARD/ : {
> -		*(*)
> +		*(.eh_frame)
>  	}
>  }
> -- 
> 2.24.1
> 

FWIW:

Tested-by: Nathan Chancellor <natechancellor@gmail.com>