Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 22 Feb 2020 22:51:48 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Tudor.Ambarus@microchip.com
Cc:     j.neuschaefer@gmx.net, linux-mtd@lists.infradead.org,
        miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: Simplify loop in spi_nor_read_id()
Message-ID: <20200222215148.GH2031@latitude>
References: <20200218151034.24744-1-j.neuschaefer@gmx.net>
 <5604429.rq6fcmI4QA@localhost.localdomain>
 <20200221162248.GG2031@latitude>
 <5932130.I5bQ6OmJFL@localhost.localdomain>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="f5QefDQHtn8hx44O"
Content-Disposition: inline
In-Reply-To: <5932130.I5bQ6OmJFL@localhost.localdomain>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--f5QefDQHtn8hx44O
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 21, 2020 at 04:50:37PM +0000, Tudor.Ambarus@microchip.com wrote:
> > > >         const struct flash_info *info;
>=20
> how about getting rid of this local variable? Use in the function somethi=
ng=20
> like:
>=20
>                 if (spi_nor_ids[i].id_len &&
>                     !memcmp(spi_nor_ids[i].id, id, spi_nor_ids[i].id_len)
>                     return &spi_nor_ids[i];

Looks alright. I'll do it.


Jonathan

--f5QefDQHtn8hx44O
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAl5RomwACgkQCDBEmo7z
X9sidA/+KODzFXuvWxA8h7iWt7fwRHNOLy8V6aH2LXuZO47xrV6uiSZaKlIzTCeB
ujAf9Y3AYVzZyOekRzS1q4+z7HWvETAKtuYgCCcYVH5kGBDFasrkce3FdyZ3UrmC
XwkemdAKKZ2v2OsRrJmZ6pY1OL15Rb3CqcSrUKyyy9gOD6dupWRuIgKaUV1VW9mX
iN6KHKFDY7uQ1vVER+nfmszzlsGom1AdSdeuQtc5i+/34ZzqpyFWEbjOBUEwCqvu
XTBvALkZylx76T/+VttVIlnY66q6SWYJVAXC+uPuDVFXcvHnyEa7yZowRBwPLn0A
d/PyRn8x1Ar1wSAVbKNjVTKYMW4b5p7azNaCG0moZT2G2C53w+iuQDKHYEZYko5P
WkhNl1nUz1B83SyCae/2kQ59ALYsF56Jpbn5u290X5yx2l4LFuv+he6G8mvZnoPV
ikzs6gkTMqdhHgZywnL6rAb0AFL2RmYj8nyyZnqQWjVJXTbBgV1z8rpqCh/8LBkv
PZky2ADuRSqAeZj346s8c8hpsLDigRsuP6MPsT4o2+51b3ULp7oqTBLosm9kWNh9
tmLVoPw43ENPc4ggITB5btYIPN2YtLZKUaTy11loX9uLgnlKHESyE43mjEPZvpe2
nbVla5UTzJNEEGU+aCcEIBDFdsY67cjE+r+5IcHdz7c34TaErEs=
=NxnP
-----END PGP SIGNATURE-----

--f5QefDQHtn8hx44O--