Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 23 Feb 2020 11:20:44 +0100
From:   =?utf-8?Q?Ond=C5=99ej?= Jirman <megous@megous.com>
To:     Lars Melin <larsm17@gmail.com>
Cc:     linux-usb@vger.kernel.org, Oliver Neukum <oneukum@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Support Castles Vega5000 PoS terminal USB
Message-ID: <20200223102044.odcmcxdk45egxu5i@core.my.home>
Mail-Followup-To: Lars Melin <larsm17@gmail.com>, linux-usb@vger.kernel.org,
        Oliver Neukum <oneukum@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20200222233202.237967-1-megous@megous.com>
 <9d9263a0-cddb-0efb-46a5-1d223a8232e3@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9d9263a0-cddb-0efb-46a5-1d223a8232e3@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello,

On Sun, Feb 23, 2020 at 10:08:04AM +0700, Lars Melin wrote:
> On 2/23/2020 06:32, Ondrej Jirman wrote:
> > This terminal's USB port needs NO_UNION_NORMAL quirk to work with
> > cdc-acm driver.
> > 
> > Signed-off-by: Ondrej Jirman <megous@megous.com>
> > ---
> >   drivers/usb/class/cdc-acm.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> > index 62f4fb9b362f1..8577441c81a4d 100644
> > --- a/drivers/usb/class/cdc-acm.c
> > +++ b/drivers/usb/class/cdc-acm.c
> > @@ -1739,6 +1739,9 @@ static const struct usb_device_id acm_ids[] = {
> >   	{ USB_DEVICE(0x22b8, 0x2d9a),   /* modem + AT port + diagnostics + NMEA */
> >   	.driver_info = NO_UNION_NORMAL, /* handle only modem interface          */
> >   	},
> > +	{ USB_DEVICE(0x0ca6, 0xa050), /* Castles Technology VEGA 5000 */
> > +	.driver_info = NO_UNION_NORMAL, /* reports zero length descriptor */
> > +	},
> >   	{ USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */
> >   	.driver_info = NO_UNION_NORMAL, /* union de
> 
> This quirk is in the driver since almost a year ago.

You're right. Thank you.

I held to the patch for way too long, and didn't notice someone else patched
it in the meantime.

regards,
	o.

> br
> /Lars
>