Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1389018ybv; Sun, 23 Feb 2020 05:35:49 -0800 (PST) X-Google-Smtp-Source: APXvYqyEHxUDDEsji/0d5ZkrkIs16LXjq/BfBKoVB0JIMnFzNIUCTgB0Z7VbFn8T9LO2ObPpqOra X-Received: by 2002:aca:1704:: with SMTP id j4mr8847538oii.12.1582464949904; Sun, 23 Feb 2020 05:35:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582464949; cv=none; d=google.com; s=arc-20160816; b=ACmYxn3WGS7BrfGJsTx2OEebtghwfi2ov6EmN2XYhvRkiIoXgolcMWSPPCukOyzR5z 6Qa2Okw/MvGD2SgtFgAb534O+yVQ9AOK7tBL80rKOtlN7A749/T2k5qcAy8ZwouTFKpK bgG2TOT/qNhNhv7bdaTlNsJg/XITLKdvHBN9VhzB5JTVhZcLa1G5EDZDUM5sAWIwBp1Z PPnWYZ+aThemK083EMPsv5LBl/75ZajdqSZkQnjR0mlNQCsySiHZttq9NIiKENBes90S KH43PpcYVbAIDio0qbs1IAh+FrQYCEYUmsy/wMDYU/iFL7ShxLhRk6Je35AHYDvXSIAH SEYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:mail-followup-to:message-id:subject:to:from :date:dkim-signature; bh=tDzRQPR0WhQl/Ac+WMIo0Zwgwywqh41sph1/p6h5V7U=; b=s0mbMC1xNy9lYwX5o12gHqgfZMh5hpqIwPsFyj/nL5oS0rGV0ANYho0z5/g8R7X4BZ dhN0bdhT08Ek2lBkGTCRk2xin6/gQR54vEaTPiFaU9yjPe5SJp+fgMuWanmcMbtbNjQQ cv0PL63mT829MXOruNgPADO883ccW2lFiQTA9dRHQp6j1HmNiT27PrmYZiQizSref1wa H9TkRJPj/WxCGUcCtlyFaV9rl/71IItYwx9o9fLTVJaCMR07cK8kw0QeOB/WSvj3s3mN ouVZLJ3eIJuLLcwh/tp9KFIg4pNDJIo0xxn9agSm3xAj8XAAy4T1azqzPrnAuFlHi+94 J81g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@megous.com header.s=mail header.b=GNXtzobt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=megous.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g18si4580083otp.61.2020.02.23.05.35.37; Sun, 23 Feb 2020 05:35:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@megous.com header.s=mail header.b=GNXtzobt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=megous.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727033AbgBWNfT (ORCPT + 99 others); Sun, 23 Feb 2020 08:35:19 -0500 Received: from vps.xff.cz ([195.181.215.36]:42976 "EHLO vps.xff.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726208AbgBWNfT (ORCPT ); Sun, 23 Feb 2020 08:35:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1582464917; bh=6VpUk0yfA5m3J1dhx2/b9+a44uEwfNvyw0oTvOwyDQ8=; h=Date:From:To:Subject:References:X-My-GPG-KeyId:From; b=GNXtzobtRQPe3S+1nOVOlPHRI/Ge3Segzb4xN/kEe/qKGExn1bm5nxfwvFQY0lNyy FTGLhJiA07xtjUTLNaUfDOQnsSHB1Q91iYt9YyquDI04pFGGH3Hy0X1cwlpJV+2hq0 FhgOh997uamzbxcmGs3pi4m1VIpMtVeMN6BrbbAs= Date: Sun, 23 Feb 2020 14:35:17 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: linux-sunxi@googlegroups.com, Jacek Anaszewski , Pavel Machek , Dan Murphy , Rob Herring , Chen-Yu Tsai , Maxime Ripard , Mark Rutland , Lee Jones , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/4] Add support for charger LED for AXP813 and TBS A711 Tablet Message-ID: <20200223133517.hfqrg5dta2xk4zj3@core.my.home> Mail-Followup-To: linux-sunxi@googlegroups.com, Jacek Anaszewski , Pavel Machek , Dan Murphy , Rob Herring , Chen-Yu Tsai , Maxime Ripard , Mark Rutland , Lee Jones , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20200223131435.681620-1-megous@megous.com> <20200223132730.6g7tnm2f263oubhv@core.my.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200223132730.6g7tnm2f263oubhv@core.my.home> X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 23, 2020 at 02:27:30PM +0100, megous hlavni wrote: > On Sun, Feb 23, 2020 at 02:14:31PM +0100, megous hlavni wrote: > > The tablet has a charger LED exposed on the top. This LED is controlled > > by AXP813 PMIC. Add support for enabling the LED and using it either > > for charging indication (handled by PMIC automatically) or for other uses > > via user control. > > Dang, I just noticed someone sent a similar driver recently, although I had this > one prepared for quite some time (since 2017) in my tree. I guess I should have > sent it earlier. > > Please ignore. Though the meaning of "recently" is a bit relative. The other work was sent in a year ago. Here's a reference: https://lore.kernel.org/patchwork/cover/1042764/ > regards, > o. > > > > Please take a look. > > > > thank you and regards, > > Ondrej Jirman > > > > Ondrej Jirman (4): > > dt-bindings: leds: Add a binding for AXP813 charger led > > leds: axp20x: Support charger LED on AXP20x like PMICs > > ARM: dts: axp813: Add charger LED > > ARM: dts: sun8i-a83t-tbs-a711: Enable charging LED > > > > .../devicetree/bindings/leds/leds-axp20x.yaml | 24 ++ > > arch/arm/boot/dts/axp81x.dtsi | 5 + > > arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 + > > drivers/leds/Kconfig | 7 + > > drivers/leds/Makefile | 1 + > > drivers/leds/leds-axp20x.c | 240 ++++++++++++++++++ > > drivers/mfd/axp20x.c | 3 + > > 7 files changed, 284 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/leds/leds-axp20x.yaml > > create mode 100644 drivers/leds/leds-axp20x.c > > > > -- > > 2.25.1 > >