Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1643134ybv; Sun, 23 Feb 2020 11:30:40 -0800 (PST) X-Google-Smtp-Source: APXvYqxKu4fRBgZPZm6wlJm1XQ9o1w7Ohan9xVFgg/gMRfu3+8syOk29QM4oAjRMLgnFtTXTx36x X-Received: by 2002:aca:54cc:: with SMTP id i195mr10001436oib.126.1582486240615; Sun, 23 Feb 2020 11:30:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582486240; cv=none; d=google.com; s=arc-20160816; b=lYjjSGIpLTKi8c6C88No9ZWicKbuLG8fIaUYmUUcJNSlJ0MVBysN7vnMZAtH51GKr1 nmpYf2wipXPGZ2i+9yJRf7cYNYkNsk0Ymj3E5GLXcDALhsKwhgZ1Cvt+KByIg3yJ+dCc EAjVKxOoawHXSLcF4tbIaO5hWETET6Gho8jjDo1VRygBmQfKL1x+3pkmSdiKh3DE6KNZ RWDz9mXOe3ZpqrfffPZqSnmrJ6unTThIWlCZsV4cIcD4PJ+nxMGrj1MHEecjBBDYyq0k c10whHfbMJnukkw9KN9orjbnmM3HMC7bHZ9xnyR1DJqTplqW8rb9lJO2P1KQjS1iBZEU a2Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=RhhpRCJlYf25MmZyBgc3Pp0XW3iOzPwN7/XSkUBeGb8=; b=hoXPwHXIyRFzQk9CopYOvuB3Jhq2P+TX/QxnAySOs8+5KahE04CyBzmTH2/oi/w5CW O+V0XkMGC8F5wLswE9h6VZkehjTgqecmERGimwiZuYILXGAYGGT/n1OjPtbV1zJTW2to NI6dgWpzkX++IemAPLdWmM0w5lopfs4XvQ8UbSZPhYUbYe8U8olK1ZjgrR48x4haYdfw x/a3muPXXzg8pJad0hi3bQ1f+VbUTiJwQBmrVMZ8rbSHlghRPwqEAicnV6napSZtBJvk xa6EhEwFwi+78pKI2vu6B6ef0lfQgyZPbIq6OduejuFog3Px7pRO2LIcoXQ9+wGT3t8j zWgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11si3958767oic.20.2020.02.23.11.30.28; Sun, 23 Feb 2020 11:30:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727290AbgBWTaL (ORCPT + 99 others); Sun, 23 Feb 2020 14:30:11 -0500 Received: from foss.arm.com ([217.140.110.172]:51440 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727229AbgBWTaJ (ORCPT ); Sun, 23 Feb 2020 14:30:09 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5239611FB; Sun, 23 Feb 2020 11:30:09 -0800 (PST) Received: from e107158-lin.cambridge.arm.com (e107158-lin.cambridge.arm.com [10.1.195.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F37B13F6CF; Sun, 23 Feb 2020 11:30:07 -0800 (PST) From: Qais Yousef To: Thomas Gleixner Cc: "Paul E . McKenney" , Qais Yousef , "James E.J. Bottomley" , Helge Deller , Richard Fontana , Armijn Hemel , Greg Kroah-Hartman , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 10/15] parisc: Replace cpu_up/down with add/remove_cpu Date: Sun, 23 Feb 2020 19:29:37 +0000 Message-Id: <20200223192942.18420-11-qais.yousef@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200223192942.18420-1-qais.yousef@arm.com> References: <20200223192942.18420-1-qais.yousef@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The core device API performs extra housekeeping bits that are missing from directly calling cpu_up/down. See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and serialization during LPM") for an example description of what might go wrong. This also prepares to make cpu_up/down a private interface for anything but the cpu subsystem. Acked-by: Helge Deller Signed-off-by: Qais Yousef CC: "James E.J. Bottomley" CC: Helge Deller CC: Richard Fontana CC: Armijn Hemel CC: Greg Kroah-Hartman CC: Thomas Gleixner CC: linux-parisc@vger.kernel.org CC: linux-kernel@vger.kernel.org --- Helge, this now uses add_cpu() which you should be CCed on. I wasn't sure if I can keep your Ack or remove it in this case. Please let me know if you need more clarification. arch/parisc/kernel/processor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/parisc/kernel/processor.c b/arch/parisc/kernel/processor.c index 13f771f74ee3..7f2d0c0ecc80 100644 --- a/arch/parisc/kernel/processor.c +++ b/arch/parisc/kernel/processor.c @@ -212,7 +212,7 @@ static int __init processor_probe(struct parisc_device *dev) #ifdef CONFIG_SMP if (cpuid) { set_cpu_present(cpuid, true); - cpu_up(cpuid); + add_cpu(cpuid); } #endif -- 2.17.1