Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1783779ybv; Sun, 23 Feb 2020 15:18:48 -0800 (PST) X-Google-Smtp-Source: APXvYqztubttvmb+2xe0Mn67AkxPUAuv+3EGYrU9xNQMmFcg2rhlZHyw/5QIqybDkqYHJqliXm9o X-Received: by 2002:a9d:4c8e:: with SMTP id m14mr36003189otf.245.1582499928205; Sun, 23 Feb 2020 15:18:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582499928; cv=none; d=google.com; s=arc-20160816; b=0gC7dUEzq207wtxPFsnDEBzRLH3oScl2RDEFZBT77dycqQRBTm7lwTx4nS10mxWDL8 78KqINr4pWLmed1uyxVv+tc1m/pSsiAs5qL2/3fXc10gjgNthSUj2qePkL9uVwqkfQ6t zJGySyxhFDlppIPmR671abS/jSfkqYGA26pVTlekE//El5h9L8jkf1IsGD2m72o5eOmk J6h3LrZYkFUnvScZiaWd81FMjwDThsK58WhZk2AHSBbXgu0duFyGAiinfmMa3WgQ5TOU fHCZ2b890xvBOqAMpKWYrD9NLvJkTyutEB+AtiIQcTApQDbkHmhORZ+CJ+3376Q9PlOx JsLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fPUr8jCY8JIDce77aHKLu0kesj5mi5yI8K5HlZIk77s=; b=bop/ziViVryz35759AhIRAwQMVeLRSRSlntfCPvRxf1hij6A+E+7wLt3WCALHi+YTB 1hmU7NCLaLrTYkWJE4Tc95xWeI99a6YPc5FWUfkjm1i6LHDW6Gxib8IVFBZHZkbDRyDy 67mbNEtW7N5tsQ7BBDNgVhc6oil9rK0caVH8OIocni/diBmiIoV2+fFDr6cua4XuNZQt Cw5AUzkYoQV0aa8AR1LjIjxCgthh9YTCO1Z6QDOIuqBqK0hqbP0mJtIWO0Cf0cKrHGzR BqajOHoupgzjnOVw/5kNyZSqw/SJ1mJjv4AbW0rqF90hsUhfep1OicbJx6fyFYqr5qPW haWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=umWQtF4r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a6si4094388oia.33.2020.02.23.15.18.36; Sun, 23 Feb 2020 15:18:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=umWQtF4r; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727619AbgBWXSR (ORCPT + 99 others); Sun, 23 Feb 2020 18:18:17 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:38961 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727394AbgBWXSL (ORCPT ); Sun, 23 Feb 2020 18:18:11 -0500 Received: by mail-wr1-f68.google.com with SMTP id y11so8225777wrt.6; Sun, 23 Feb 2020 15:18:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fPUr8jCY8JIDce77aHKLu0kesj5mi5yI8K5HlZIk77s=; b=umWQtF4rQ643Qg1LiBfMBoOhKtVIL5uLVM5lEckOEZTF4gFu93yUOZqUT2SSb79R6N NbsX2uOQCz3H6bKZ/2Ht9YiHeP5bHRxfeCpxWOYKuz3FhMEZgnd7O4/x+72Y8TbrhSDk B+JDguRpue+4HBlYQ6OO7qtJ606wfHWf95eKi47/FdVq0IoOyRbz1EZ7wmp0GjuLMvbq jld1eUMgJMKReDoqZ+I9U7dD/yPB8VEl68LZrwovEVCWPJ+U68q0FES6/ZA6yUR8uJnd THp2YnDws/QDxvFIjAVkx+FwvDvdggLHZzCznpEduCVtBuq0k4AlsHN3HbVne4GXbZK9 Cb9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fPUr8jCY8JIDce77aHKLu0kesj5mi5yI8K5HlZIk77s=; b=kj3fjDniI4wiQM3rFoi3Z5EAZiUpLMQMzNtH5W9GJBZh6xZvodFGNYG1Y+VgP59PDJ PD/5nEb5JhsQ9v9uTfnvAYDFJDl48mgsBGlp2xWRE++84QblEWLrEVYZ13/5xS54l+9t xLmUomEt4I4/j/qptKVafnziC42Kw4rFllhSou+4TWB+Ds4xgfKAyYqeaxAzcB7/T/Jv uBIWbk9qDkkXtDYWRc/HuQ6wNZwDYvaFr+6ybwLkGal5+kSibhJ2ymoihUX/Nhqkc9xL R7KG6/4SGSm3feTc9VlqDv4MvLlfU1UtMgL1HwwmMwL2kd97FN6K40d2hLgXtwfPdYH8 ApuA== X-Gm-Message-State: APjAAAVhwm5aIJiH5XTJHhtPDt1VqDwkNG3loX1lVruWguegXmZREZHC YTlLj7tN3ouhFAFUB5GP2g== X-Received: by 2002:a5d:638f:: with SMTP id p15mr61891483wru.402.1582499889294; Sun, 23 Feb 2020 15:18:09 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id q6sm8968203wrf.67.2020.02.23.15.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2020 15:18:08 -0800 (PST) From: Jules Irenge To: boqun.feng@gmail.com Cc: jbi.octave@gmail.com, linux-kernel@vger.kernel.org, Gerrit Renker , "David S. Miller" , Jakub Kicinski , dccp@vger.kernel.org (open list:DCCP PROTOCOL), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) Subject: [PATCH 14/30] dccp: Add missing annotation for dccp_child_process() Date: Sun, 23 Feb 2020 23:16:55 +0000 Message-Id: <20200223231711.157699-15-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200223231711.157699-1-jbi.octave@gmail.com> References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at dccp_child_process() warning: context imbalance in dccp_child_process() - unexpected unlock The root cause is the missing annotation at dccp_child_process() Add the missing __releases(child) annotation Signed-off-by: Jules Irenge --- net/dccp/minisocks.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/dccp/minisocks.c b/net/dccp/minisocks.c index 25187528c308..c5c74a34d139 100644 --- a/net/dccp/minisocks.c +++ b/net/dccp/minisocks.c @@ -216,6 +216,7 @@ EXPORT_SYMBOL_GPL(dccp_check_req); */ int dccp_child_process(struct sock *parent, struct sock *child, struct sk_buff *skb) + __releases(child) { int ret = 0; const int state = child->sk_state; -- 2.24.1