Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1783816ybv; Sun, 23 Feb 2020 15:18:51 -0800 (PST) X-Google-Smtp-Source: APXvYqxUhKHF8tQO1M1x5k1Znv6PZ7/lZnuLaZc1YGtwZT1gKbu8wu/2FYyLSsegslboXB3wCXTC X-Received: by 2002:a9d:7a89:: with SMTP id l9mr35812047otn.228.1582499931796; Sun, 23 Feb 2020 15:18:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582499931; cv=none; d=google.com; s=arc-20160816; b=wXve5rWOlKJgZL3BVsPLDageIPFyHWxEtXQLSaWpDdUGB1ASEeNuX1MXxDBsFS27hS PrfSQRGzPpymj8Um8COJ/HN9gya9caOPLevMEJAPQV1iYWRRrTjwnCYGjNYj7DMdD14I uk6zymZ2XOtCctreT2cg1X37K/eBCv+EGzNHwZyBW/UHoZT3+octudIF2xjcuhcoXWIk mKkKrUzDUfYbtPkvrDT/ZJXeL65bpz5n+D7IdvTzeXuP5f8O9qLmlVLnHqFpFK3S7GHD EHDsEEGThLhlNVXUzfpud/70d/AqVsw6p0Tmy0jytGlAIS7/sz/SfojaUjAQtBoH0aCx WbPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WXi0tRYl5HmKRjz98V0jZ+F+bayiPek8dE5Nz6vBIVU=; b=MiQd73OfVuM3RiSNIvMCvzkevWPR1MqQNyUFSIDsgOj64zUz3q3qpzTkteMbYYHIS3 nG3UNOPFvvyaqNEjqzbYTTshuIHVFQshgLefVKfWot25WtxfFabduwzoc4rAAq+7gWpk qI694RwapTX50xOo+M3rSsmr7JWk2mVfHZmzQxcUNfHS4DtXzQj0pPovo43n8gqrfTWK yejaSsTIfNI2e1reGny+MynuSiW0UFndDiNSuhTT2kf5EmiKhARIJTw0A8/fjEmQcD7T QoMdHNOPfn+tkgBpGLIVA33h1yaw9sEQHBXL/7NhJBzpyu6OCF32BPlkjavkNQ7tg/Ca kjmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MUMjaQgN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l23si4812929otj.302.2020.02.23.15.18.40; Sun, 23 Feb 2020 15:18:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MUMjaQgN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727655AbgBWXST (ORCPT + 99 others); Sun, 23 Feb 2020 18:18:19 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:41867 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727483AbgBWXSN (ORCPT ); Sun, 23 Feb 2020 18:18:13 -0500 Received: by mail-wr1-f68.google.com with SMTP id c9so8237296wrw.8; Sun, 23 Feb 2020 15:18:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WXi0tRYl5HmKRjz98V0jZ+F+bayiPek8dE5Nz6vBIVU=; b=MUMjaQgNz202BO5dopV9PRfH5QcbJltxKRYAfAJ4Ls/9Vu0lUJZwY/Ta99BgWyvSCI G1hWYn0horqZeGZyMi8T9F97h9iehT+9xxENJwQSg/Ov2PPRO1wSwSKurT00PmVcCf6Z wOGpLQKPSaFOTRDlZgKIUEgDr0gLCVgZT9gc85Gj3Gj/vZ98CZkoHevnC1KWVeujip9R ksZrgF7WKqtLZf2Jqiq1/mwww17ieDgOWaaZn97pj+Exvt6kfoAnSjgxsN0l/iRAO2Nw oTvGEfrunxYKPBngTT/dQ4IgpM/zs7maVxGbi3jmW6sB36ue1XWGyUw0t41ts6coQw65 pnrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WXi0tRYl5HmKRjz98V0jZ+F+bayiPek8dE5Nz6vBIVU=; b=Px4NBEpLFbdN+v0xfOQQfLHxHchH7nzeG/o2d0BcKVHmQD5RDEMZ77Es2cHnOXLAWx EwI1V+U34s9lVv9NlhX/cyXFKErrqDJKI4oU6AyuQoFyRnPwS0JIi8YjSXscUZ/VPwWj Qcofsu6ycEcuk2potYMOrS5gJjgIDPcJMq6Iw28rKHUzejPzgnYI9TQAs6Xu9/5CmliI Gi0h60e0VIOzcIC7N7mjSmHbt09wBqO6Vf2RjYrbKahXEKbpWk3q3wFacmW192frJv+H PN2ww9SMwvWWZ2HCaPxXKrKxt3QMKymFG45dMVyUHlWSroaIeSTqE+SRnJ6Uw+z+LEBN ynHA== X-Gm-Message-State: APjAAAXoYHr8nImbrKR97jJXiQytWHxxoq+zmr2rzDyb3h/7VU8L1Q05 x1Qwd9f6Bv7vkq5LMk8Rui+Pnm1p/L18 X-Received: by 2002:adf:ce87:: with SMTP id r7mr62130426wrn.245.1582499891874; Sun, 23 Feb 2020 15:18:11 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id q6sm8968203wrf.67.2020.02.23.15.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2020 15:18:11 -0800 (PST) From: Jules Irenge To: boqun.feng@gmail.com Cc: jbi.octave@gmail.com, linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Allison Randal , Steffen Klassert , Jens Axboe , Hannes Reinecke , Kirill Tkhai , Eric Dumazet , Thomas Gleixner , Pankaj Bharadiya , Arnd Bergmann , Qian Cai , netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) Subject: [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() Date: Sun, 23 Feb 2020 23:16:56 +0000 Message-Id: <20200223231711.157699-16-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200223231711.157699-1-jbi.octave@gmail.com> References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning unix_wait_for_peer() warning: context imbalance in unix_wait_for_peer() - unexpected unlock The root cause is the missing annotation at unix_wait_for_peer() Add the missing annotation __releases(&unix_sk(other)->lock) Signed-off-by: Jules Irenge --- net/unix/af_unix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 62c12cb5763e..cbd7dc01e147 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -1207,6 +1207,7 @@ static int unix_dgram_connect(struct socket *sock, struct sockaddr *addr, } static long unix_wait_for_peer(struct sock *other, long timeo) + __releases(&unix_sk(other)->lock) { struct unix_sock *u = unix_sk(other); int sched; -- 2.24.1