Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1784406ybv; Sun, 23 Feb 2020 15:19:48 -0800 (PST) X-Google-Smtp-Source: APXvYqwjY6TrwavUAQkeckLmhzu85rDQYzJaBFAlMYbos3aZhirParrJMEelsf+NuvXN6Y5q5KIu X-Received: by 2002:a05:6808:18:: with SMTP id u24mr10648450oic.10.1582499988467; Sun, 23 Feb 2020 15:19:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582499988; cv=none; d=google.com; s=arc-20160816; b=N//9A3Ee8dS6Mv19aiDnvhco1TjWzPE2mMUT1+WEvp3gF7Fg9/Y4nBRyQFGh+7BHMR jEjchmozq0wzifG+tE7Z68sg8C0iu4UxFHuADAxLvq4OtD6zPBq8NNT43ugjRu/78bRn xSnj5fqeurFcb744yFHz/xuDuKZgywBZ9x0Mz2IGtxGo32tbHgDDlVmjVbrn1pf+xbtH kvqdI/L6dwe0KlnqDKlMDJgapBiuOYAl+TCWMYUuRCt+VPmGFhZo0K6rLjTJ0I6UfpBo Hqkm24NVWxhxh+W2w4HBpClWLeQrD+2L+l03Pe0OEYqgNCDuTbYuNbzkaU9/bN8yT1yN xbLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2tqXBx3pW2XeZXOKkdshIeGK59QQ2bzYKaVDgcPRkVc=; b=euj3+Y0S1pcIq4L6uaBtmtXx5eGHdlNhL79GXDdz0qpUvd4FlupzoeGDVGXA7qRziN WQA6LfwL1J8wqZBxn77zqL2I2KjOwslMmd1STBLIX9v6iTK9Jv6OoEmB83ZOxiqpauM6 zxmPXUrl9tfGD/3jnSHmjz2vgDKTmPO4Bflmx/LPAYdh6mGhhVuaStioAgb7foApBXZM uK/TQSrT1uXJEc+Z/6zCmJcE8n6VH9VwFiVHrtAoCQWUfkdUc2AcddJiV+a5k5IKnawR 6e7zAtvcf7dejO7uQYmOhq91BdE/RSMLi5ELFruUueTimXmY4MfB1O8n4/x8KA+9ONLe 195Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LC+JynOM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u123si4520221oif.84.2020.02.23.15.19.36; Sun, 23 Feb 2020 15:19:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LC+JynOM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727840AbgBWXSf (ORCPT + 99 others); Sun, 23 Feb 2020 18:18:35 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44121 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727823AbgBWXSe (ORCPT ); Sun, 23 Feb 2020 18:18:34 -0500 Received: by mail-wr1-f68.google.com with SMTP id m16so8206862wrx.11 for ; Sun, 23 Feb 2020 15:18:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2tqXBx3pW2XeZXOKkdshIeGK59QQ2bzYKaVDgcPRkVc=; b=LC+JynOMXP7MA84ZsHt9UdiFMqJsmNa3E/CM7pzdEnxQOO7BSJr9Y66WxMn4kVenGm wKrzp8mp1TZuE0nU4xai5gJ372ngfriF+gj/tRLcUROfsBGRvHck23lLsasm8Ug7ENh5 W4JHollJ9JBHcES90yD8D106jxccdjjnRrAWzrF4z75Y6Nb8WMed+jKYlaYWCvihvuAV zmL68iiOji3Cczzb74zjWOEYbdtu4hTuAAw3RcdSjVfy4z7KCSshP5yUwaiUMuQRh6FX XE2rsMlvncajs3CjxHeVf38/yIOizsa7RlahyEzBO+17rV+P+BWL9MHdm9gDlZOH7+I6 9WVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2tqXBx3pW2XeZXOKkdshIeGK59QQ2bzYKaVDgcPRkVc=; b=hexRP0GPf7RSoI84W0B72foLoWg+LzVbs1Lbq3XMwU0EdTLltef2EBSkyKgTs6qeLW /oPQ0M/lZ3ywX05Ys1NqSGZFKM/aAYg7r6UjyRwYRtZzeUkGGQOrl7pHsT1MNV7pHPRK o/tRH+BbBix1eMxx4MCA7nqiwrsZkhA0qJgd0mEAXywRHmDIX7Mw3LrSB0Lq4YqjcG3X Y8Bi/4lgH1MB1GdWV4Wpt+xVG1wqz4vhv5gcDkrt90inU+Ph6kvhQof9Lpq+T40gbw4F 9uWc0n30F7YWlQ0gbSEJt5TARaFanmIZlPUeTZm0LtUA3of4SBSzjxzfHiFiTSYwv58d b3nA== X-Gm-Message-State: APjAAAWuupv4cfSny13I8K4sYdHEc46LIJSEs2IVvVlG2yh5m4wvlvGz KdXYVpn6qj3tPduaoJGkzIs+2lkj+Fbr X-Received: by 2002:a5d:638f:: with SMTP id p15mr61892440wru.402.1582499911744; Sun, 23 Feb 2020 15:18:31 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id q6sm8968203wrf.67.2020.02.23.15.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2020 15:18:31 -0800 (PST) From: Jules Irenge To: boqun.feng@gmail.com Cc: jbi.octave@gmail.com, linux-kernel@vger.kernel.org, Oded Gabbay , Arnd Bergmann , Greg Kroah-Hartman , Tomer Tayar , Omer Shpigelman , Dalit Ben Zoor Subject: [PATCH 27/30] habanalabs: Add missing annotation for goya_hw_queues_lock() Date: Sun, 23 Feb 2020 23:17:08 +0000 Message-Id: <20200223231711.157699-28-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200223231711.157699-1-jbi.octave@gmail.com> References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at goya_hw_queues_lock() warning: context imbalance in goya_hw_queues_lock() - wrong count at exit The root cause is a missing annotation at goya_hw_queues_lock() Add the missing __acquires(&goya->hw_queues_lock) annotation Signed-off-by: Jules Irenge --- drivers/misc/habanalabs/goya/goya.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c index 7344e8a222ae..8ca7ee57cbc1 100644 --- a/drivers/misc/habanalabs/goya/goya.c +++ b/drivers/misc/habanalabs/goya/goya.c @@ -5073,6 +5073,7 @@ static bool goya_is_device_idle(struct hl_device *hdev, u32 *mask, } static void goya_hw_queues_lock(struct hl_device *hdev) + __acquires(&goya->hw_queues_lock) { struct goya_device *goya = hdev->asic_specific; -- 2.24.1