Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1784605ybv; Sun, 23 Feb 2020 15:20:08 -0800 (PST) X-Google-Smtp-Source: APXvYqx6OGWbOwF0Us36g0UvnmuZQc68gJN9B6uXxm7c2ZgYHrfDNszfIdwF0W6uwqXBEPBNmXIE X-Received: by 2002:a9d:a68:: with SMTP id 95mr36622845otg.87.1582500008026; Sun, 23 Feb 2020 15:20:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582500008; cv=none; d=google.com; s=arc-20160816; b=YuMlz7FYmyfkikGsnnQl2LpcHX5hcQmUwKlDeu0ePhmdlDIOYcllEj2oAmdVEkBuIY js0Vl4gmf5nQF7kGWDWTKIP8Mp/2y1b8U+uCtPgZHenR4wfSqKX4T4GrtbWSZkj6vkjo CtOdf+ESXfoO97WBrJpqvHKg2l3Bbj0UgsTGTiC5dZteu+jF/qG0hP8dYps8Z6Koy0EB 09PotawAf0q01f7pZk07mTzlhqSTihm6eoAPqqx63y+KyuOur+XkW+v6Z9GY+fz9BdiJ gVf5xu82b6StckksIOgJVGub9e/wdEANBNeqCpzIRffV8oiE4MaotWiyv4FbSqNlZPnD YB0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gkM2+ezKKrc7LrYNLVS4ghnKI3fIkVnMRghoo0Y2WuI=; b=YQiD9LCTYiN+pt12t93tASL9n0y1OC2nw+MsW/Ka1uReFchDC2nWETrqD4P4Oj4t7E pdetq6OF5Puc2la6mRfdzO2/q+znlUwY9Amt0+xrmntnvUFMO16FT1sI1BkdAAKUbqGR wcCanpz2Vk8FYWRulJt5E1Mi7lkSWC6sfJZvvqxQrLjilJcgDm1lo/8fpDLmIOnZierz mnsTL6iViZxkNVtqbpoV0lVBWCkLA1qi1e6CJuXrMoVydWWtnbljj5nV3f1Cv/HHXowl i4ZNbvShaeLYW6Na79TPT9Mr3US9gkAI3IFPaU3hEyMvK6FV8BjcHJFTMpNeR1qw05hg tcLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PEOc+u7F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v25si5172118otq.93.2020.02.23.15.19.56; Sun, 23 Feb 2020 15:20:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=PEOc+u7F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727368AbgBWXSI (ORCPT + 99 others); Sun, 23 Feb 2020 18:18:08 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:35760 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727247AbgBWXSB (ORCPT ); Sun, 23 Feb 2020 18:18:01 -0500 Received: by mail-wm1-f68.google.com with SMTP id b17so7457668wmb.0; Sun, 23 Feb 2020 15:18:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gkM2+ezKKrc7LrYNLVS4ghnKI3fIkVnMRghoo0Y2WuI=; b=PEOc+u7FIAVXO7BKIcV6zHe3q3+RFTrdKqBnrtlyXEp1P/r1Rut12oLnsUASVr3X74 YglPSHeqfj84I5v/WMBknfai/b259SxGLmK4Jf9+5ZILgx/+moon/UE4aYSQqLmnvFHv ByQNkn2YQA4h8kPSEOrpL9RTES31Qn3XmYRpB1J1KIDtP6Hma15IVnnLdyyfCSvLaGeK BFW/xiBFiIKmgbE4A3xJUhgNajFeCJTPDe4ANxN8xpqsCw1Z5d9RxJUIlPcxEbzG5xcP YfAGBrscbUThXg8vFjaJlsmMi/Se0zddjydzxs2AsZTVF53C9usQ5GJ/hOvmUG5J7An3 by5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gkM2+ezKKrc7LrYNLVS4ghnKI3fIkVnMRghoo0Y2WuI=; b=TjGG+S4S8QdPAhLAbaMjrIJqNpsQUAHpWNBbYujULQB4MYNTFSFu8YY8ejl6z3Wj1x umWx0gvPJw/2ePnDcQASY41zutp0i9YTkDxw9kyO6PEm0/74sA9ySngOwcFE4Rv8vAvC 46qpjinsV3inRKv1qxGVZDSZFDyc5AFbDjymACg/XhQc6cRaIQl6TamcqcCgs2kfEDW2 yWvwjrR6IFmilnjeBkXYyzfKQUyi3yYM/TMdhSINqN3G4j/kLvNPtqxyRtXznkIbohE2 /k6m6goLoUIcbkp0t5YPWQi70LyrzJumb6WuqSKHQiqi0KBVFCcGLSNSLn+4bornMHkH oSsA== X-Gm-Message-State: APjAAAU3qi+snzyUqB63Xy1sL57+aa87JaqUBdSCqErbCBDI0KSCr+9F SFr+htBScHOcwzLj/ukFOA== X-Received: by 2002:a05:600c:1007:: with SMTP id c7mr17748695wmc.158.1582499879662; Sun, 23 Feb 2020 15:17:59 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id q6sm8968203wrf.67.2020.02.23.15.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2020 15:17:59 -0800 (PST) From: Jules Irenge To: boqun.feng@gmail.com Cc: jbi.octave@gmail.com, linux-kernel@vger.kernel.org, Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , "David S. Miller" , Jakub Kicinski , linux-sctp@vger.kernel.org (open list:SCTP PROTOCOL), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) Subject: [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop() Date: Sun, 23 Feb 2020 23:16:47 +0000 Message-Id: <20200223231711.157699-7-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200223231711.157699-1-jbi.octave@gmail.com> References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at sctp_transport_walk_stop() warning: context imbalance in sctp_transport_walk_stop - wrong count at exit The root cause is the missing annotation at sctp_transport_walk_stop() Add the missing __releases(RCU) annotation Signed-off-by: Jules Irenge --- net/sctp/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 05be67bb0474..fed26a1e9518 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -5340,7 +5340,7 @@ void sctp_transport_walk_start(struct rhashtable_iter *iter) __acquires(RCU) rhashtable_walk_start(iter); } -void sctp_transport_walk_stop(struct rhashtable_iter *iter) +void sctp_transport_walk_stop(struct rhashtable_iter *iter) __releases(RCU) { rhashtable_walk_stop(iter); rhashtable_walk_exit(iter); -- 2.24.1