Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1784899ybv; Sun, 23 Feb 2020 15:20:32 -0800 (PST) X-Google-Smtp-Source: APXvYqyFKlfjC1Cg4un70g9GD10alvRc/kLeQWcW4C4GeRuYhCdmJBKure9FR+xf0cNG2qzAasAG X-Received: by 2002:a9d:6653:: with SMTP id q19mr38767768otm.94.1582500032738; Sun, 23 Feb 2020 15:20:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582500032; cv=none; d=google.com; s=arc-20160816; b=V2AZf+xQBMQt9plDv/FabqRjcIrJ5IamFNeO5Go2l/vO5XuWnh+bpTUqAd9AElnXJQ KHBAO/ShNHm5FTV9Ckd7mvjCaqja9Gkw067mZ3GwU+rfFLNrbgt0s1QPa/dUc1MDk2Rf ltdU1oRrR6aFLiEIJwZd8MZp+wy6/EHWCBrVOm6/WPrHC4bOI17CLpYFqhlGNoWBmjM2 g8OcCSXalBT8KMDV/i/Y7V+862KUZ3PL9/vymcyKiWKu30/IKH0S8OVnaYXgHbH9wxFU jYCxAMeWlryYMNZX8c6uId0eh7jivxnc0orHV8cCvXxJAXm4LBDyFU08pSVyY8IQH0Pb OlzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pyULC8zRDdQ34YS1FTwq1d6c2T2bCIAgmeM9ejfxUJc=; b=THH1KOx0A6XVQPXXtJY0hC53JNYofj/vYBK4bzfSVp9XLUt61UmwhUyvyf1i/BhG0A MjgK4ONcQRpVQUUWRx+plWp4GvlPk4RWEnBpeDX+NN4PCMM1WvAevnYZE6JPS1zOAkUj dhnDuRxfDTOmww3eEFG7SE10dF7Y4/lHrhsKdbs7FTtTcbrtFUmTTWhgVrBWGVI4ax8M J5uOAFXQ73F7Sgwvl5L5Tk5Z+dqMRRJ3stOZAnoHCmCIGA8B6No2OAWhTbqXZOWGIwCp XLcKKDKH33LiF0RbMhoyYjETaPpqFuW1I3VQ3I8M5Yz0X48rARw2f2JTdAsNoTgK0yF4 yDnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dqmHA7Di; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p23si5612150otk.119.2020.02.23.15.20.20; Sun, 23 Feb 2020 15:20:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dqmHA7Di; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727337AbgBWXSH (ORCPT + 99 others); Sun, 23 Feb 2020 18:18:07 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55193 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727180AbgBWXSE (ORCPT ); Sun, 23 Feb 2020 18:18:04 -0500 Received: by mail-wm1-f67.google.com with SMTP id z12so3994992wmi.4; Sun, 23 Feb 2020 15:18:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pyULC8zRDdQ34YS1FTwq1d6c2T2bCIAgmeM9ejfxUJc=; b=dqmHA7Di0z6aZI3DD8tanMjnukyJD16fQbr/5grwhOZtuCqBEYND7nYu4+UmdUsJAx hSJdgFo0+xzAwCJLYtxmAl/EMFGp2kZig+OA9U/Rh3hrYBMavTHWGGNxzkFVVQ4cA6Be 3fW61yP6HjwLvT5IzDfVnEjYvkDY9llWN7EtVmTZiRtocnsO14/e9qqrxnvps0XS3C5b Kxu5hhHUtoZSsGCUxrC+Anz2EOQ+QHv5tsyaELIcxjd+7Kdp5ofgnCIS1g2mY2dmgw0a vaHA4rZU/Im0r5Y8oMpnzyUgFvR6MZxrlHn4+bTYkx+DPFCQO/HEo1dCmtdMzzRlTBE5 BedQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pyULC8zRDdQ34YS1FTwq1d6c2T2bCIAgmeM9ejfxUJc=; b=bg7NH021NDCHwstdyV0qOcNmUSBZUncdOnQ6mCdswSl0SCABSphPJvx6Pe+zaXyy5m AMhXoPRkgAut54iQppsEQH+KpacZY9n/AbGVAJIapwBmDUXbbalJJmVToxycODv/jX34 8dRrSxDkRosHMV/PJr2CIo9eng/TvuhxvxlJFP6Rb1GwWoc2GWTsFJ8JSqucIE7P0okE WZ706ZKNCnDo1oEjrQVSEQtoI6BHmPJ7LK6iXgFnEAvRTvuYUxbYwqWJsQwNNmQtctOj YVPBDEc0vZBn1QOMTWr+cFcQU8VuOW90594Dw3QMy7Liu3Ah6exfSFezkfGbysBVGqq5 o7Jw== X-Gm-Message-State: APjAAAWsotMFdNipyEvzTW5EWzlCuz4vwpS89LAW2+J2OxiOQZXrsjxt 3Ilhye8/wOIhKCSS4VzTnO5qhS9qOGe/ X-Received: by 2002:a1c:e108:: with SMTP id y8mr17169102wmg.147.1582499882949; Sun, 23 Feb 2020 15:18:02 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id q6sm8968203wrf.67.2020.02.23.15.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2020 15:18:02 -0800 (PST) From: Jules Irenge To: boqun.feng@gmail.com Cc: jbi.octave@gmail.com, linux-kernel@vger.kernel.org, Ralf Baechle , "David S. Miller" , Jakub Kicinski , linux-hams@vger.kernel.org (open list:NETROM NETWORK LAYER), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) Subject: [PATCH 08/30] netrom: Add missing annotation for nr_info_start() Date: Sun, 23 Feb 2020 23:16:49 +0000 Message-Id: <20200223231711.157699-9-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200223231711.157699-1-jbi.octave@gmail.com> References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at nr_info_start() warning: context imbalance in nr_info_start() - wrong count at exit The root cause is the missing annotation at nr_info_start() Add the missing __acquires(&nr_list_lock) Signed-off-by: Jules Irenge --- net/netrom/af_netrom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c index 58d5373c513c..8be06e61ff03 100644 --- a/net/netrom/af_netrom.c +++ b/net/netrom/af_netrom.c @@ -1230,6 +1230,7 @@ static int nr_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) #ifdef CONFIG_PROC_FS static void *nr_info_start(struct seq_file *seq, loff_t *pos) + __acquires(&nr_list_lock) { spin_lock_bh(&nr_list_lock); return seq_hlist_start_head(&nr_list, *pos); -- 2.24.1