Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1785094ybv; Sun, 23 Feb 2020 15:20:50 -0800 (PST) X-Google-Smtp-Source: APXvYqzEOF/kNd5si1cUDq9sbmVN/jwo0oZt+jARN10ZcrQHTcc1Nb7oqG05IHzz1GYjMQ7n6Gfc X-Received: by 2002:a9d:ecc:: with SMTP id 70mr36669820otj.182.1582500050184; Sun, 23 Feb 2020 15:20:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582500050; cv=none; d=google.com; s=arc-20160816; b=Eu6A08t+7IRUVXsggRZbNxonvsJ3fEDaoEVS4AETWLrGlGznthTXRXBKYshp9svfeY CrKbSojJ2nDIbD0KfykkCKpWROItaQJbrCc+BdUcVdMQ0mHoF902blRSBp88eYO9oF69 uJ6+rDyijXs+/nJZKnekW1HBFqpSzUaAemTMVXjLDpr4hpOtp2IllO2KkwlXTeSUc64q Jjf8tBdKzfR6SFTEkYu4ZWAd5HgD2KZre5NFp68I72dc6KdQ3yNQMyzhj6odzymZ906I lJjlk8kbMH8gq+baZpy4MCUl+ZSI7byxRfFUlx9rIvBV4aC26ps+8TtYo67zaL6MqmwP iFeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/CARPq6Rx4M0QkZy9yfp02dz/1hPE7n1aRAR3+33T8o=; b=qbLQS7n4z9xUJX0f/DblR1QK0xeAKIYvvWfg6wRjQ+RIzd/K2jvgHWexOqhlpwoabv lBbe5/DWdlpZrMOewZjTV99QwHJCoNpPFlXNrCel42IfgI01jbtxiMM+myUiUnFd9bMk pxpw9i04mi5w4q/QRblXRmigNy2ATOrtl+1DYzsldeDoJzxzm38KT2cRKuR0KS+HPh77 Ca0Vqm0AGd8sZEgUJ+5nS9MBRahSXCgri1SWknbSr4rY4dTnKlin2VTYOywFK5TcVfYw TZyJ1PW152zVb4mjbriyulsTYg3ohKeOJOwGNTr1WNzSN3ETe8IcJ1yUtQ143O04j5QP tEzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ne0ORNqT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 9si4331941oiq.104.2020.02.23.15.20.38; Sun, 23 Feb 2020 15:20:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ne0ORNqT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727869AbgBWXUE (ORCPT + 99 others); Sun, 23 Feb 2020 18:20:04 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:40234 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727228AbgBWXSA (ORCPT ); Sun, 23 Feb 2020 18:18:00 -0500 Received: by mail-wm1-f66.google.com with SMTP id t14so7446662wmi.5; Sun, 23 Feb 2020 15:17:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/CARPq6Rx4M0QkZy9yfp02dz/1hPE7n1aRAR3+33T8o=; b=Ne0ORNqTPVSAJEg0AsCd2tNIKwEsrr+t1mduNCkvQZZ2W3YYRCdk+38h7fmWJ5/bfl /Pmqo7PItFTHvAyKn5UJQehAjYWz9wYqAGSz8X7Mmpgdppc1X7DDm1tJeM+RQXb2pvkD hcJ1J2nGiCtP6ycFmbE5B7otjueLorYatqQBm9R/db1GnUvCUm7J3sAFXrcU0ccu/1Nt lUR0CBOqRsjxtJDe5VJ789bg0f0dgk+QVV1nvKS2fddWZ7gyz590HnNefX50pC83A+0d zYgGpx61P5DLFgFqEUCMH1Be76UqymOO6UqHajZLhYvFdVX7XiMxxy7pdYsEu6EB42Z0 XCeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/CARPq6Rx4M0QkZy9yfp02dz/1hPE7n1aRAR3+33T8o=; b=eQalb1ae4UtMXba3YdXPOS8LmqkUB7Kir7r3AoPGf7iVxDxg17n2t0iX7o0zq9y1eG 0egEbMXD2EGStkhCF3/4dM3WMi3u/jNonTi2Sky/EsgN9lNpcgr27UNVudQjS2iVNh9P xv3DY4lSREbTi09dWmYIEeJY9yWzbRX34kvkJT6SdlwkbzPDCB12aC/cUfYnUPHvNt5S iCHEJPu/rO7BarbyLqVZKYEaFTBMqlYAjVJCoD71QZFdZFalDIkEc1lDuGV01kPBZsUt E9YONjW6mbmSenHiV2oQ77z7jCmZLZawUJz+MWScQfAfqsddTeQ9dJr9n1N9nNbL9Ymn MDlA== X-Gm-Message-State: APjAAAW7+YTY3Z58O5bz4PHny7elPLBzm4bWUuU8jdY3OoQi9oelLI6S jSzNmKYSjZD5hNGT3RWGWnOC18wzznhS X-Received: by 2002:a05:600c:114d:: with SMTP id z13mr17896219wmz.105.1582499878574; Sun, 23 Feb 2020 15:17:58 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id q6sm8968203wrf.67.2020.02.23.15.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2020 15:17:58 -0800 (PST) From: Jules Irenge To: boqun.feng@gmail.com Cc: jbi.octave@gmail.com, linux-kernel@vger.kernel.org, Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , "David S. Miller" , Jakub Kicinski , linux-sctp@vger.kernel.org (open list:SCTP PROTOCOL), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) Subject: [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start() Date: Sun, 23 Feb 2020 23:16:46 +0000 Message-Id: <20200223231711.157699-6-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200223231711.157699-1-jbi.octave@gmail.com> References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at sctp_transport_walk_start() warning: context imbalance in sctp_transport_walk_start - wrong count at exit The root cause is the missing annotation at sctp_transport_walk_start() Add the missing __acquires(RCU) annotation Signed-off-by: Jules Irenge --- net/sctp/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 1b56fc440606..05be67bb0474 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -5333,7 +5333,7 @@ int sctp_get_sctp_info(struct sock *sk, struct sctp_association *asoc, EXPORT_SYMBOL_GPL(sctp_get_sctp_info); /* use callback to avoid exporting the core structure */ -void sctp_transport_walk_start(struct rhashtable_iter *iter) +void sctp_transport_walk_start(struct rhashtable_iter *iter) __acquires(RCU) { rhltable_walk_enter(&sctp_transport_hashtable, iter); -- 2.24.1