Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1785210ybv; Sun, 23 Feb 2020 15:20:59 -0800 (PST) X-Google-Smtp-Source: APXvYqyDL7TyDe6mcts+c85BWHPddE71bfZzZK4KYiNlZ+vCppCCmerEyMFeFP0UN/Pfy1zW9fND X-Received: by 2002:a54:4006:: with SMTP id x6mr10530363oie.145.1582500059018; Sun, 23 Feb 2020 15:20:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582500059; cv=none; d=google.com; s=arc-20160816; b=nFLMIkkDy9vp7lYiaudNcv5uczgP7zyboPf+sjCTNqIrujndZSmpXmOL6xxmxlyBN4 4KYm1Rfij3/sFwcNlvc8XhwgmKdatvD+QgtZ9PwJB4m7ICTuDMngEQC7Uv1R8BZ2QyJp mx7juaX9bKq8sNH7OogaDhRI+oD7V4hxGlshtIl3U1UQepos1zXnULbv4SU/icRlGk9Q mQ5dVZ7qKDI3uL4Tp08LBNQ1NDha6Bj5i3lnIjcpIUe8km7waCpWOhqfi2fathQBc0ck jmGgE1JaKgENxj3CcDC+nkEYLNB7tRB3sDEL83O4ea6eYdPAvc6YDg6BNqTCUcK3Bv0+ 569g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mf++eeayLsVrcTVe6kbYrrnwfp2AEx+dRuICz5iDthY=; b=pf9ytiz4r0SlAPXj+aDcRj21r4EzY9BCyAGmga8mQLspVTX6fX95yD/k7iwfJrTZjT 4lSrp+mCPd4lmBo0dMbHrbZ3YoRjuN/bMi4fiU/fDAd3J0lTNUIk9iKMNzkuyi+RvEFA zHOSWZOJEYuCEh2tvkJX16koy9GqUnN6UauVhb9dxQeldwgiI+z4RRALCHlV2U/zt4EV NwfsQKSeOGTC5QZyIu65192XPR84AG7Efd6eMrT12HPBYOxwgEDfXoElJr/ktIHLBYbE aw1m7TgDewPu4MbLoDosuJZiUPMX2nckALjNdR4/ijqHfnxljmSA+GWhMQ1bFq4gwSGC jpgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=scWgaIOm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v21si5047020otj.282.2020.02.23.15.20.47; Sun, 23 Feb 2020 15:20:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=scWgaIOm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727611AbgBWXTf (ORCPT + 99 others); Sun, 23 Feb 2020 18:19:35 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:39016 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727329AbgBWXSH (ORCPT ); Sun, 23 Feb 2020 18:18:07 -0500 Received: by mail-wm1-f67.google.com with SMTP id c84so7453448wme.4; Sun, 23 Feb 2020 15:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mf++eeayLsVrcTVe6kbYrrnwfp2AEx+dRuICz5iDthY=; b=scWgaIOmdbwqRz8XkqHo3LJ08oQDqJ3XycbTlHUlm8XzHxJhpKqJfSdF0FCZSu+wt+ EJQQ9eT8yxLTRUnQ82BPqcNqNkxMEAa3G67UWTrXc/6+ahq0CKSGNtKwuFHuZWUn9auX azqIYlkeRinAvqOhM7MQ+IOrq13QADRIHzvzY97SyucZERwLddvzN60FbpklkB0dSdLv ovhemh57TsX4vmc06v3yPGdNy7HrzZcO3tRLQc6sqAoPE9izZ+ZK72Vac+wW7Mlq1RBI pYZj6uRzVeaSd4q1+91EHj8tXrUGT5XJdA5Or2jCnSdrSDGCgoIzJeGlzyL9jiYy+K0Q 6XzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mf++eeayLsVrcTVe6kbYrrnwfp2AEx+dRuICz5iDthY=; b=YZgxOHKNdGtkNKx0y7EwNe0j1eDr1jaT/MzddL0NUXyUjiluekSVUOS8HpKIe82cVR XfTPXLM0ixKTfRbpCL1Nx9nUyYBgQLZpKsV8lk1D7wtXruN03rzRHPiZvB075saRtV2a kQb+9HNhGzzyMAyleL4dp5tEJJ64JTfC9jSAhqbkdlQU3HbTR7YNqj2Auu7wSW3EHmq4 72Bj78dlKEj4fqyLypAO8Iudi+LqEPEQa+Z7MQd2ag4AXPQoY/D0eCcmtXsxc4Vo+L42 fExLEOC9Docx3fiDax5MFKS2abQyTQE4c7uGcRxdHEeoAmGyhnpRhP6fmDrKbhsUvUei ykFA== X-Gm-Message-State: APjAAAVaqu/6gv/oMRHtSADsnaeTKKaHlA1XUuri0EuOXzEpqWfjPA0i HX0WsmD7sIxgE8rswUg80PEbwdjGpNRv X-Received: by 2002:a1c:2645:: with SMTP id m66mr17508997wmm.98.1582499886116; Sun, 23 Feb 2020 15:18:06 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id q6sm8968203wrf.67.2020.02.23.15.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2020 15:18:05 -0800 (PST) From: Jules Irenge To: boqun.feng@gmail.com Cc: jbi.octave@gmail.com, linux-kernel@vger.kernel.org, Ralf Baechle , "David S. Miller" , Jakub Kicinski , linux-hams@vger.kernel.org (open list:NETROM NETWORK LAYER), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]) Subject: [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop() Date: Sun, 23 Feb 2020 23:16:52 +0000 Message-Id: <20200223231711.157699-12-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200223231711.157699-1-jbi.octave@gmail.com> References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sparse reports a warning at nr_node_stop() warning: context imbalance in nr_node_stop() - wrong count at exit The root cause is the missing annotation at nr_node_stop() Add the missing __releases(&nr_node_list_lock) annotation Signed-off-by: Jules Irenge --- net/netrom/nr_route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c index fe278fc24153..637a743c060d 100644 --- a/net/netrom/nr_route.c +++ b/net/netrom/nr_route.c @@ -850,6 +850,7 @@ static void *nr_node_next(struct seq_file *seq, void *v, loff_t *pos) } static void nr_node_stop(struct seq_file *seq, void *v) + __releases(&nr_node_list_lock) { spin_unlock_bh(&nr_node_list_lock); } -- 2.24.1