Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <7b86733f81c7e15d81ab14b98c8998011ed54880.camel@neuling.org>
Subject: Re: [RFC PATCH v2 00/12] Reduce ifdef mess in ptrace
From:   Michael Neuling <mikey@neuling.org>
To:     Christophe Leroy <christophe.leroy@c-s.fr>
Cc:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Date:   Mon, 24 Feb 2020 13:15:01 +1100
In-Reply-To: <f62b0f67-c418-3734-0b07-65aea7537a78@c-s.fr>
References: <cover.1561735587.git.christophe.leroy@c-s.fr>
         <f62b0f67-c418-3734-0b07-65aea7537a78@c-s.fr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Christophe,

> Le 28/06/2019 =C3=A0 17:47, Christophe Leroy a =C3=A9crit :
> > The purpose of this series is to reduce the amount of #ifdefs
> > in ptrace.c
> >=20
>=20
> Any feedback on this series which aims at fixing the issue you opened at=
=20
> https://github.com/linuxppc/issues/issues/128 ?

Yeah, sorry my bad. You did all the hard work and I ignored it.

I like the approach and is a long the lines I was thinking. Putting it in a
ptrace subdir, splitting out adv_debug_regs, TM, SPE, Alitivec, VSX.
ppc_gethwdinfo() looks a lot nicer now too (that was some of the worst of i=
t).

I've not gone through it with a fine tooth comb though. There is (rightly) =
a lot
of code moved around which could have introduced some issues.

It applies on v5.2 but are you planning on updating it to a newer base?

Mikey