Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 24 Feb 2020 12:56:18 +0800
From:   Dave Young <dyoung@redhat.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Kairui Song <kasong@redhat.com>, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org, kexec@lists.infradead.org,
        Jerry Hoemann <jerry.hoemann@hpe.com>,
        Baoquan He <bhe@redhat.com>,
        Khalid Aziz <khalid@gonehiking.org>,
        Deepa Dinamani <deepa.kernel@gmail.com>,
        Randy Wright <rwright@hpe.com>,
        Myron Stowe <myron.stowe@redhat.com>
Subject: Re: [RFC PATCH] PCI, kdump: Clear bus master bit upon shutdown in
 kdump kernel
Message-ID: <20200224045618.GA16543@dhcp-128-65.nay.redhat.com>
References: <20191225192118.283637-1-kasong@redhat.com>
 <20200222165631.GA213225@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200222165631.GA213225@google.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Bjorn,
On 02/22/20 at 10:56am, Bjorn Helgaas wrote:
> [+cc Khalid, Deepa, Randy, Dave, Myron]
> 
> On Thu, Dec 26, 2019 at 03:21:18AM +0800, Kairui Song wrote:
> > There are reports about kdump hang upon reboot on some HPE machines,
> > kernel hanged when trying to shutdown a PCIe port, an uncorrectable
> > error occurred and crashed the system.
> 
> Did we ever make progress on this?  This definitely sounds like a
> problem that needs to be fixed, but I don't see a resolution here.
> 

I'm not familar with the PCI details,  but if this only adds a quirk for
kdump use and no other risks added then it should be good to have.

Or we can provide a kernel parameter for the quirk?  Then it is even
limited to only be effective when in-kdump && the-param-is-used

Anyway still prefer to people who know more about this area to evaluate
the risk.

Thanks
Dave