Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <862518f826b35cd010a2e46f64f6f4cfa0d44582.camel@perches.com> <87eeuo5a2y.fsf@suse.com>
In-Reply-To: <87eeuo5a2y.fsf@suse.com>
From:   Steve French <smfrench@gmail.com>
Date:   Sun, 23 Feb 2020 23:58:21 -0600
Message-ID: <CAH2r5mtvkVk4RiZB2pu5aymv0mv-ioV8jc4mhwuF4c3XRpxhJQ@mail.gmail.com>
Subject: Re: [trivial PATCH] cifs: Use #define in cifs_dbg
To:     =?UTF-8?Q?Aur=C3=A9lien_Aptel?= <aaptel@suse.com>
Cc:     Joe Perches <joe@perches.com>, Steve French <sfrench@samba.org>,
        CIFS <linux-cifs@vger.kernel.org>,
        samba-technical <samba-technical@lists.samba.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Seems like a plausible debug (VFS not FYI) msg.   If delete is not
pending, it is a little strange if nlink is 0. merged into
cifs-2.6.git for-next


On Fri, Feb 21, 2020 at 7:46 AM Aur=C3=A9lien Aptel <aaptel@suse.com> wrote=
:
>
> Joe Perches <joe@perches.com> writes:
> > +                     cifs_dbg(VFS, "bogus file nlink value %u\n",
> > +                              fattr->cf_nlink);
>
> Good catch :)
> I realize that 1 is VFS but this should probably be FYI.
>
> Cheers,
> --
> Aur=C3=A9lien Aptel / SUSE Labs Samba Team
> GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
> SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg,=
 DE
> GF: Felix Imend=C3=B6rffer, Mary Higgins, Sri Rasiah HRB 247165 (AG M=C3=
=BCnchen)


--=20
Thanks,

Steve