Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1C4EEC433A2
Subject: Re: [PATCH v6 2/3] soc: qcom: rpmh: Update dirty flag only when data
 changes
To:     Maulik Shah <mkshah@codeaurora.org>, swboyd@chromium.org,
        mka@chromium.org, evgreen@chromium.org, bjorn.andersson@linaro.org
Cc:     linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        agross@kernel.org, dianders@chromium.org, rnayak@codeaurora.org,
        ilina@codeaurora.org
References: <1582277527-19638-1-git-send-email-mkshah@codeaurora.org>
 <1582277527-19638-3-git-send-email-mkshah@codeaurora.org>
From:   Srinivas Rao L <lsrao@codeaurora.org>
Message-ID: <2c25c10d-6e52-4b59-00f8-fb5538a7e5a4@codeaurora.org>
Date:   Mon, 24 Feb 2020 12:13:39 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <1582277527-19638-3-git-send-email-mkshah@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Reviewed-by: Srinivas Rao L <lsrao@codeaurora.org>

Regards,
Srinivas.

On 2/21/2020 3:02 PM, Maulik Shah wrote:
> Currently rpmh ctrlr dirty flag is set for all cases regardless
> of data is really changed or not. Add changes to update it when
> data is updated to newer values.
>
> Also move dirty flag updates to happen from within cache_lock.
>
> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> ---
>   drivers/soc/qcom/rpmh.c | 21 ++++++++++++++++-----
>   1 file changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/soc/qcom/rpmh.c b/drivers/soc/qcom/rpmh.c
> index eb0ded0..83ba4e0 100644
> --- a/drivers/soc/qcom/rpmh.c
> +++ b/drivers/soc/qcom/rpmh.c
> @@ -139,20 +139,27 @@ static struct cache_req *cache_rpm_request(struct rpmh_ctrlr *ctrlr,
>   existing:
>   	switch (state) {
>   	case RPMH_ACTIVE_ONLY_STATE:
> -		if (req->sleep_val != UINT_MAX)
> +		if (req->sleep_val != UINT_MAX) {
>   			req->wake_val = cmd->data;
> +			ctrlr->dirty = true;
> +		}
>   		break;
>   	case RPMH_WAKE_ONLY_STATE:
> -		req->wake_val = cmd->data;
> +		if (req->wake_val != cmd->data) {
> +			req->wake_val = cmd->data;
> +			ctrlr->dirty = true;
> +		}
>   		break;
>   	case RPMH_SLEEP_STATE:
> -		req->sleep_val = cmd->data;
> +		if (req->sleep_val != cmd->data) {
> +			req->sleep_val = cmd->data;
> +			ctrlr->dirty = true;
> +		}
>   		break;
>   	default:
>   		break;
>   	}
>   
> -	ctrlr->dirty = true;
>   unlock:
>   	spin_unlock_irqrestore(&ctrlr->cache_lock, flags);
>   
> @@ -287,6 +294,7 @@ static void cache_batch(struct rpmh_ctrlr *ctrlr, struct batch_cache_req *req)
>   
>   	spin_lock_irqsave(&ctrlr->cache_lock, flags);
>   	list_add_tail(&req->list, &ctrlr->batch_cache);
> +	ctrlr->dirty = true;
>   	spin_unlock_irqrestore(&ctrlr->cache_lock, flags);
>   }
>   
> @@ -323,6 +331,7 @@ static void invalidate_batch(struct rpmh_ctrlr *ctrlr)
>   	list_for_each_entry_safe(req, tmp, &ctrlr->batch_cache, list)
>   		kfree(req);
>   	INIT_LIST_HEAD(&ctrlr->batch_cache);
> +	ctrlr->dirty = true;
>   	spin_unlock_irqrestore(&ctrlr->cache_lock, flags);
>   }
>   
> @@ -456,6 +465,7 @@ static int send_single(struct rpmh_ctrlr *ctrlr, enum rpmh_state state,
>   int rpmh_flush(struct rpmh_ctrlr *ctrlr)
>   {
>   	struct cache_req *p;
> +	unsigned long flags;
>   	int ret;
>   
>   	if (!ctrlr->dirty) {
> @@ -488,7 +498,9 @@ int rpmh_flush(struct rpmh_ctrlr *ctrlr)
>   			return ret;
>   	}
>   
> +	spin_lock_irqsave(&ctrlr->cache_lock, flags);
>   	ctrlr->dirty = false;
> +	spin_unlock_irqrestore(&ctrlr->cache_lock, flags);
>   
>   	return 0;
>   }
> @@ -507,7 +519,6 @@ int rpmh_invalidate(const struct device *dev)
>   	int ret;
>   
>   	invalidate_batch(ctrlr);
> -	ctrlr->dirty = true;
>   
>   	do {
>   		ret = rpmh_rsc_invalidate(ctrlr_to_drv(ctrlr));

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation