Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2223473ybv; Mon, 24 Feb 2020 01:24:10 -0800 (PST) X-Google-Smtp-Source: APXvYqziTSTV21LFqhnB7vsAILthUbBn0l6XhP8quTT8M1vhtJRqC5EM8m99gWym2eMaS8XZjj5X X-Received: by 2002:a05:6830:612:: with SMTP id w18mr40272181oti.160.1582536250532; Mon, 24 Feb 2020 01:24:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1582536250; cv=pass; d=google.com; s=arc-20160816; b=cg/GBlhS3abYGKAQQvzwVp16i/0e3Ovw3sssqnj5aITKMdq7E3+q5PtqAyXtIhIb6L UZeygWgmUVdZuODoyzx5DUaYbV7BTiujA5qc9xkdd6ZIe+oqdWSLXVmtoXkAcKLiAt8P cCXVeAWIgr1cax+uB4D90PkpTHY7pFC8+3BYuz/GpkOPu+j1kmIFa1HVyrbc8ZHA2IiK UByaLAJAFdyzaNh7YArqLsJTFq3ANCLVmdnjBc5SRI4MuSTK5Zw644NWOlppot2wOWcY ueZorXF2wT/AfvJpUoPdDMKdjLA5bN4wbvmB5L47apF/hdCpGiLfVonWIur/hcJ7s/Wm BlbA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=KcLbK273J8pdWk5kpNaxPZjWwPRW+1DLGADvAIl2gOY=; b=iBQagOQd6jxShN6iGCQxweCv/1qtXG8TbZ9sw7aa4fVoCtDvCbN90s5E2cCfDTbBdG bqITnOcOl7M09k3lY9KNQHt3Wq263WGhWMekc5NCGkaa3iepJ2nj5LACffxejKyra1yA v6kyAex4LvNuP22ZSAeOaQnGTBKM9AIORVJoDzcJxZkvUtTznC6CknkEyQlvgkqXW0dD z2noYNKb36W8Qk/5NSP4ckvCcS7+Xf4NjzLXv352Oua+sfY05M+TKlwL4RlUJtpHtu6D ScyBA9KKUIf9/SzYL/OzM/rRK34yW7q3azWn5XfdEA1gh4wqdP7Z5GgYxT1MKy7kteMM tnMA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@silabs.onmicrosoft.com header.s=selector2-silabs-onmicrosoft-com header.b=JCSUQpJX; arc=pass (i=1 spf=pass spfdomain=silabs.com dkim=pass dkdomain=silabs.com dmarc=pass fromdomain=silabs.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d20si5851233oti.311.2020.02.24.01.23.58; Mon, 24 Feb 2020 01:24:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@silabs.onmicrosoft.com header.s=selector2-silabs-onmicrosoft-com header.b=JCSUQpJX; arc=pass (i=1 spf=pass spfdomain=silabs.com dkim=pass dkdomain=silabs.com dmarc=pass fromdomain=silabs.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727421AbgBXJWk (ORCPT + 99 others); Mon, 24 Feb 2020 04:22:40 -0500 Received: from mail-bn8nam11on2075.outbound.protection.outlook.com ([40.107.236.75]:6086 "EHLO NAM11-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727278AbgBXJWj (ORCPT ); Mon, 24 Feb 2020 04:22:39 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VJXt7jd/xxZouvGtG2m6eJ/BgKUMvyoGhmhn/jTQAad7E6rlilZXVj9ypDdKLBn3H0U6hIOLJZheyT6aZVzXL4Vt1kXIvYCLXrvJ8OaXpjp4+MTr5lZizncJshs7yJbqDVminK9JI+td03jIaU1Y/ABbpZIi4ChCkl1aoc1Gep/kE8vcmB4bbQpCGblJez0LG0SFs4nbxOVcrRbcUwQmAMoMYaCV040an5Wz22dLOladu3DhK4sDCl2/r70HtPv4G5Ab/pw7GHK5cgb1OTffYk0IOsEf7t9V+Vd9ekE5BbBWL3Ol/xKMH1kzhJfcyWP9oHaQcGjYrJjoftTcyGWKhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KcLbK273J8pdWk5kpNaxPZjWwPRW+1DLGADvAIl2gOY=; b=DIcisVS9R3mltgglX4udGYAvTjEXkhY+WCKBkTqMnW9nOk1TjZHXTURpVG+floZ3igD3JPO+h2rKcNaJqp/yQ0JZfMhzubnncgrfFOqNSZDBbx/IEjzLPA8iweKi5lww1AW6OgwbvU7UrnLuIDNq4f93vhtcT9dxpOox42X/8iJuxSnEhs7WLud95/YFNJweIsOASr5s/M/A8wbdbNfJqNdpcX83d8qip+EqWKrRHGkrpuzC5mqjF0fHf2AKcpVqJm+3zu7/fQ5q2PrldGb/QZ680vHMo1DyWw1VaP/T2bDi0nRRrgS630DYlDQ2v4mJA7RzE9yh60BNT8/h/ScmHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KcLbK273J8pdWk5kpNaxPZjWwPRW+1DLGADvAIl2gOY=; b=JCSUQpJXaQwqwaelS//h4yLIeETE7BQGVn/geUyARs1YbmyuD1oMiTAedTG/QZFAeUpWiXElF4+v3Z015Qaas8TjOo0I6lVxScIf2eMm1+1FycyT9ytHMpQ59h9irzeIo0miDt/11r1zIbMiTPoW4pwq6ccOvoSajIY6EYQRqKs= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4647.namprd11.prod.outlook.com (2603:10b6:208:262::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.21; Mon, 24 Feb 2020 09:22:36 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::ade4:5702:1c8b:a2b3]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::ade4:5702:1c8b:a2b3%7]) with mapi id 15.20.2750.021; Mon, 24 Feb 2020 09:22:36 +0000 From: =?iso-8859-1?Q?J=E9r=F4me_Pouiller?= To: Kaaira Gupta CC: Greg Kroah-Hartman , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging: wfx: match parentheses alignment Thread-Topic: [PATCH] staging: wfx: match parentheses alignment Thread-Index: AQHV6n/1fjfjb+Ut6UKRnjRXKA1ltqgqEuWA Date: Mon, 24 Feb 2020 09:22:36 +0000 Message-ID: <1761697.Ie2Hvvaxtr@pc-42> References: <20200223193201.GA20843@kaaira-HP-Pavilion-Notebook> In-Reply-To: <20200223193201.GA20843@kaaira-HP-Pavilion-Notebook> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; x-originating-ip: [37.71.187.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 723035f2-c5db-40f7-67f6-08d7b90b1673 x-ms-traffictypediagnostic: MN2PR11MB4647: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:291; x-forefront-prvs: 032334F434 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(396003)(39850400004)(366004)(376002)(346002)(136003)(189003)(199004)(4326008)(6506007)(76116006)(6486002)(91956017)(186003)(6916009)(66446008)(66476007)(66556008)(64756008)(66946007)(86362001)(26005)(33716001)(9686003)(5660300002)(6512007)(478600001)(8936002)(81166006)(81156014)(8676002)(2906002)(316002)(54906003)(71200400001)(39026012);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR11MB4647;H:MN2PR11MB4063.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qMYqFIOPD1qrLZgepEMsDiR+8zjSYCMjvfnV2ZtrStIQaG0RK98hAASrUqEIq5jj7YcNXstZNlPY6nYQ2/iGBM5zy5HFgkE90G9UWWwv0fnEv8VRzHaIMYLVln8OIfLgples7vfoinGf6ZeZIDCs61PXkHd5Sz0Bb8z1NeOeWmc8JfW+CHHeR/4eHdJOoMuGGge0JgIqWZQlu6ngsb+NdaDn+q7vgWvVSpEdoQXOcSQm/CaCXrD4AsFFiugd0zgfGKdLj/xRLPrp840tbAhQ28vAr8tevE9wYXNiF7NlNtfBFirR4ms0lLQnbNVeDjDZXkgOBC+emG/Gje7kLZo3PlDEvpPQVrdQKqzssS9lNZZns88VimXB816PtL5ofwWwcfQeQvYqRVBbYJR5jWRM3Np0gt2ordjCFoL/Vh433EAT3W8DZI6zi6Qvt7XcpeDojz+CXL5jCI8TpLYdOG+lIo3h3GUWWK8aio00WpN6niISM9+UaEBBDKAaLyU7zhaV x-ms-exchange-antispam-messagedata: LCJHsx4uNuVqsnCmds1Dt/0+PMjwF5W+WgExSUp975WurS4PD/Wz5wSic8e6NZtTPjSr3RziZGEoqa+4YlM0B/13MSzC5AHvj2WcMXjG6CeDvGvATui9DtDBLctBjyuxNWUXY5EtnK+8VKVXC3kV4A== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-ID: <4E04A9827DD96342BA833B6FD78F017F@namprd11.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 723035f2-c5db-40f7-67f6-08d7b90b1673 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2020 09:22:36.6186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ptk6FW0GLTEjw5wlB+qemzKnkVQfqoZ45GGVpHnfN/A3T48OwzFf1XcXLjPcb4c/KttclAvOu3LcmuVTZpH2Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4647 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 23 February 2020 20:32:01 CET Kaaira Gupta wrote: >=20 > match next line with open parentheses by giving appropriate tabs. Maybe the body of the commit message should start with a capital letter, else: Reviewed-by: J=E9r=F4me Pouiller >=20 > Signed-off-by: Kaaira Gupta > --- > drivers/staging/wfx/data_tx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.= c > index 20f4740734f2..815fde0913f5 100644 > --- a/drivers/staging/wfx/data_tx.c > +++ b/drivers/staging/wfx/data_tx.c > @@ -300,8 +300,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, st= ruct ieee80211_hdr *hdr, > } >=20 > static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif, > - struct ieee80211_sta *sta, > - struct ieee80211_hdr *hdr) > + struct ieee80211_sta *sta, > + struct ieee80211_hdr *hdr) > { > struct wfx_sta_priv *sta_priv =3D > sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL; > @@ -368,7 +368,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_ra= te *rates) > } >=20 > static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif, > - struct ieee80211_tx_info *tx_info) > + struct ieee80211_tx_info *tx_info) > { > bool tx_policy_renew =3D false; > u8 rate_id; --=20 J=E9r=F4me Pouiller