Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Michael Ellerman <mpe@ellerman.id.au>
To:     Christophe Leroy <christophe.leroy@c-s.fr>,
        Michael Neuling <mikey@neuling.org>
Cc:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 00/12] Reduce ifdef mess in ptrace
In-Reply-To: <5b5d8f61-c9aa-1afd-6001-44a17f00c1a6@c-s.fr>
References: <cover.1561735587.git.christophe.leroy@c-s.fr> <f62b0f67-c418-3734-0b07-65aea7537a78@c-s.fr> <7b86733f81c7e15d81ab14b98c8998011ed54880.camel@neuling.org> <5b5d8f61-c9aa-1afd-6001-44a17f00c1a6@c-s.fr>
Date:   Mon, 24 Feb 2020 21:54:00 +1100
Message-ID: <8736b01cjb.fsf@mpe.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Christophe Leroy <christophe.leroy@c-s.fr> writes:
> Le 24/02/2020 =C3=A0 03:15, Michael Neuling a =C3=A9crit=C2=A0:
>> Christophe,
>>> Le 28/06/2019 =C3=A0 17:47, Christophe Leroy a =C3=A9crit :
>>>> The purpose of this series is to reduce the amount of #ifdefs
>>>> in ptrace.c
>>>
>>> Any feedback on this series which aims at fixing the issue you opened at
>>> https://github.com/linuxppc/issues/issues/128 ?
>>=20
>> Yeah, sorry my bad. You did all the hard work and I ignored it.
>>=20
>> I like the approach and is a long the lines I was thinking. Putting it i=
n a
>> ptrace subdir, splitting out adv_debug_regs, TM, SPE, Alitivec, VSX.
>> ppc_gethwdinfo() looks a lot nicer now too (that was some of the worst o=
f it).
>>=20
>> I've not gone through it with a fine tooth comb though. There is (rightl=
y) a lot
>> of code moved around which could have introduced some issues.
>>=20
>> It applies on v5.2 but are you planning on updating it to a newer base?
>>=20
>
> As you noticed there is a lot of code moved around, and rebasing=20
> produces a lot of conflicts. So I didn't want to spend hours to rebase=20
> and rebase without being sure it was the right approach.
>
> Now that I got a positive feedback I'll consider rebasing it, hopping=20
> that Michael will pick it up.

I would love to.

cheers