Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2417263ybv; Mon, 24 Feb 2020 04:59:47 -0800 (PST) X-Google-Smtp-Source: APXvYqyouwADyoiF4Xt5Un/OCb1GMTDzDlUPmchBOrrsSJZ2937EMxj62M7xR7I4CMU1hv/CAN57 X-Received: by 2002:a9d:806:: with SMTP id 6mr38121662oty.90.1582549186959; Mon, 24 Feb 2020 04:59:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582549186; cv=none; d=google.com; s=arc-20160816; b=mu1R1ZQ83e3Omwik07GpJKg3NVO+R8a6YtCMmJfqUbLoj+J3Exudxz6nSw01X/nRoo VjB8mRK+/ydRSwwMkIIdtK+92SpaGr1LXeD/mxXmohXEA/BNDKPVaxijbFvk3GKp33YF 03c7hFFR2XcuOOhWTqK91JBZfAD2UUZO2BcQpT4JLXCQI51YrGgXiOedIv690smcpCvt u1OeuAgKdzZVqB4b2pgZ+LH+t/rA/DNHfuRlku8iMcHAunWSv80UBYOo3KqS4Ny+To2c ypzg/vI621YkPXo+8OiNSuhU/nLNoalhMUoWhylAUKUKb6LEyMbI7opovK5AtHqMHroI 8q7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MEoIHk1DMNFlUDlS2mHYQ7hw5/edQugGUZCmTbk0oQY=; b=EDJYgXNEVxP71F8qnMtVS1HUk3zUgP3E/iex5icPiw5HBI8BL33vZF77n/M2APP4LW OJviLYtd6bfraROnUmbDuki/70hEEpImogTWZ1kDOkXN/V0ARa5cbNYFENb2PL+Wr3me 7OS+aSVRhs10drGrrFIniyyifb4ouNwuWhuTe3SpSsQgGJFWxwK59FvtaoNuvQhlD6SP xcbte95nazrQBXfpO2d8kKRmQYoOB/GMyTgCacFIPAJZxp+nf4Wy8lZmPiheG7OKAIG2 mRzGKhQ/srQ5gBeLCHmLejYRfUzNR73IZ87bGvoyoWwVZF4keRIDKOnh0S4P92frByPE ZKWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WhmJc4o0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w18si6217462otp.48.2020.02.24.04.59.34; Mon, 24 Feb 2020 04:59:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WhmJc4o0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727700AbgBXM7Q (ORCPT + 99 others); Mon, 24 Feb 2020 07:59:16 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:40378 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727689AbgBXM7P (ORCPT ); Mon, 24 Feb 2020 07:59:15 -0500 Received: by mail-pl1-f193.google.com with SMTP id y1so4032993plp.7 for ; Mon, 24 Feb 2020 04:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MEoIHk1DMNFlUDlS2mHYQ7hw5/edQugGUZCmTbk0oQY=; b=WhmJc4o0Hei2T5dVmOwsPi0dhRuZXdo+2t1CwfjSjQ01c+rVJ3o197eZe9jaivHhsS Af9MO2dlYF1ozNWbTJR0uSnI1yg7VmouHRFRUyrKhDQfFdCuxFZ77K4qjKUuuVDRGXMO pp3f9dsEUX4X9+jPFCr1Fx43GgP4QZIlHNutaxoT2tf8eKnxnwKDoEWy1WxIa1ktJv+n l1fBmEGKoSIwZaIYNWSPhkyugR64Z1osmk2kMcJuru4J5pkgt9iZMyGqtcozwJreizYV /sE7KvwquUjMGUI2hROeGofUGqdk/NaEpiGRy1SQXlw2K9z+AaXNcYQBoCI7EcNiqjjt 8dAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MEoIHk1DMNFlUDlS2mHYQ7hw5/edQugGUZCmTbk0oQY=; b=A2AuXVg42KgOD3jBQ9vbot9YrI6PdD8+6ZUfka+Aj7TUCpBSVe/zX9ailDNUfINdl7 6LKbE/yELmBAWp2AJ4INhoJXPSCwM5uCeCZSCVU1fIokHBbzEalTJSlzLwbjrsIHs9rK /hE8jDGTr4T9Md7lj2y096PkAPpCWFW8p5u8dUSi96YaAd/OqbnbkMneZyLF08DDgfux abntHKyRjEXhTg9BWbikK4PhUmmPpE7j4GLg2D0jVIn0PVRxO/QV+1MHZqgBSiMbdRBH jYLB6KBSy1zFyhdLNyRm5cMP8BzYIat0M0bps4MNYgXXNNnlNi+V4gf9vct4WjlJWLH3 g9NA== X-Gm-Message-State: APjAAAXk5E2PAvPfatGbgWbX30w06FmVJTNV7HlSEaZl7LKYnCUCT7+9 rG3KKHIxr32cufQfRP4/muLWjZABb/4= X-Received: by 2002:a17:902:8341:: with SMTP id z1mr48441653pln.178.1582549154055; Mon, 24 Feb 2020 04:59:14 -0800 (PST) Received: from localhost ([103.195.202.114]) by smtp.gmail.com with ESMTPSA id u13sm12519095pjn.29.2020.02.24.04.59.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2020 04:59:13 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, daniel.lezcano@linaro.org, bjorn.andersson@linaro.org, swboyd@chromium.org, sivaa@codeaurora.org, Andy Gross Cc: Amit Kucheria , linux-pm@vger.kernel.org Subject: [PATCH v6 3/8] drivers: thermal: tsens: use simpler variables Date: Mon, 24 Feb 2020 18:28:50 +0530 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We already dereference the sensor and save it into a variable. Use the variable directly to make the code easier to read. Signed-off-by: Amit Kucheria Reviewed-by: Bjorn Andersson Reviewed-by: Stephen Boyd Link: https://lore.kernel.org/r/6f95b3f0d39433c7e6b01094bdb200a7ac8e9f0d.1582048155.git.amit.kucheria@linaro.org --- drivers/thermal/qcom/tsens-common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c index c2df30a08b9e..1cbc5a6e5b4f 100644 --- a/drivers/thermal/qcom/tsens-common.c +++ b/drivers/thermal/qcom/tsens-common.c @@ -368,7 +368,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data) tsens_set_interrupt(priv, hw_id, UPPER, disable); if (d.up_thresh > temp) { dev_dbg(priv->dev, "[%u] %s: re-arm upper\n", - priv->sensor[i].hw_id, __func__); + hw_id, __func__); tsens_set_interrupt(priv, hw_id, UPPER, enable); } else { trigger = true; @@ -379,7 +379,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data) tsens_set_interrupt(priv, hw_id, LOWER, disable); if (d.low_thresh < temp) { dev_dbg(priv->dev, "[%u] %s: re-arm low\n", - priv->sensor[i].hw_id, __func__); + hw_id, __func__); tsens_set_interrupt(priv, hw_id, LOWER, enable); } else { trigger = true; @@ -392,7 +392,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data) if (trigger) { dev_dbg(priv->dev, "[%u] %s: TZ update trigger (%d mC)\n", hw_id, __func__, temp); - thermal_zone_device_update(priv->sensor[i].tzd, + thermal_zone_device_update(s->tzd, THERMAL_EVENT_UNSPECIFIED); } else { dev_dbg(priv->dev, "[%u] %s: no violation: %d\n", @@ -435,7 +435,7 @@ int tsens_set_trips(void *_sensor, int low, int high) spin_unlock_irqrestore(&priv->ul_lock, flags); dev_dbg(dev, "[%u] %s: (%d:%d)->(%d:%d)\n", - s->hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high); + hw_id, __func__, d.low_thresh, d.up_thresh, cl_low, cl_high); return 0; } -- 2.20.1