Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2614006ybv; Mon, 24 Feb 2020 08:23:34 -0800 (PST) X-Google-Smtp-Source: APXvYqybnlEGWLCchZE+H4AufPEJVOoDjTxGmoqiHYQDQ2wxIaE7lcesib6VrGve5op7g2oN4qiT X-Received: by 2002:a9d:7ccd:: with SMTP id r13mr39481122otn.56.1582561414063; Mon, 24 Feb 2020 08:23:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582561414; cv=none; d=google.com; s=arc-20160816; b=b4AahxGTJBHDACX4ZPBh+VSJBA0rhfTSDokEfoMz4187n3LqqjZC5NzWXRoXBkFDjE JCUTfcHaY/Uy+/1ISHUUJsyeH/MaxrA4LryT9XqrrUVxGjCs+Ceo2pbZKmQmoD3FSzeg mTfvhMVrTeqxZPqXG6/4fwFeiw1UcQlmmY/ehkJU96vfK7pINXi0NnPBgKv1Xk2xZSet GC8K51Wjv3hJDaW5AXOZ1FAtqlUPIGGBDPwQcx4a2Jy6J6lT7NH5z/pqK9h2PE9WP6Q7 CDJX4aSDI7lFLumTdXRqxgn/PqlhZzfG/gxc44K2mtAla6FpEWTBZHg4G27p4QdbsjkB 8C3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=cdH1MvvC7rUuS4KMjyzC13eGx35pprvSgBak/SE0yDY=; b=VWJV/J/bG72Nih94KJXZ5Tvu3YfB4V1v/DO5taC5dLQ8LzPFT43NsLkN9O7aXv+usx 7qtACXQGuma2gmAYeYXroPqVkqsz7Jk795WMm7JOegmgn0Vd9QCUxrMhHejLnRMvxixb OMefOpknuKRqYy8sBlHJCJH+pll/BHcCp4eVTwwQHLauQjsXQbmjIhPHaN04LRA5K5IP dhKJBYzJZjnEeLvmpHY/u9Ideb4AYYiIY7eMNzJMcRk0vqizDBOH7/Fzio7nw9KcI/1C ycjE7EjWxZcuwLH/X0zYb5l6XFEHbnyxcN34mldbzsqrE7rj8rgZDDd/dLKh95sCNYwy E+/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=MlFeKYpd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n14si6551375otk.179.2020.02.24.08.23.20; Mon, 24 Feb 2020 08:23:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=MlFeKYpd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727299AbgBXQXQ (ORCPT + 99 others); Mon, 24 Feb 2020 11:23:16 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:34584 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727378AbgBXQXQ (ORCPT ); Mon, 24 Feb 2020 11:23:16 -0500 Received: by mail-io1-f66.google.com with SMTP id 13so10305085iou.1 for ; Mon, 24 Feb 2020 08:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cdH1MvvC7rUuS4KMjyzC13eGx35pprvSgBak/SE0yDY=; b=MlFeKYpdGaZT6w34tn6UFiEg5Qu4hA9w7O6A9cIiaoRQtKmhSi2DoL/6YteNJlg9YE NgHRstjBoCMp2W8rfpiMDU4KbItudyyg4ytb79MSCjGDGDRRvZzvDYecDvaczbeslPJG ApTtFYFtGhY70jJFfyAFPuvg4WmY24LXDJ5YXmiZArOovzz84VmKp4OppNCjMNF/vwcd FcvV1jIapAwYuxO21y88pG/KN98bbsuiO4xF/gq7+XoIymUrffXa/0s5rijokVIBefHd vvil+w87/K6Imf7715nhMQhuh0DHonMpPezoW7cLQZBe0d0bEAgl/YgPpozox1sV3n+l Tjgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cdH1MvvC7rUuS4KMjyzC13eGx35pprvSgBak/SE0yDY=; b=DNF/dMiqvGuPCom8G5c6Y4WNBnVXkFBUvycgg+nZIo15F7UIaRCASqpsj1qHl/gVaa 8XQX18OaFRPuoWIywy6YistxMupbgYa8I66akpt+BOBB36zgSgCUcSFwHYiiuQ44FfUh zrk4fIQlS8NDFNtQbXn2qgthGtLx/CeF0qM8fzLPf3JZcCGL6Q/TCPrhpSjaJcaovLZ5 joxJP0+xo4PVjsV0O9qIcfGtEqk5TPEIRqep3F0xd/4/U2Z8325OM6OfWn5kVovm4pDn ++R8IQjRPfyd9x+OZpro5lck8bLBKnokCNF+60DM1nP+lBSW2RxKvLNgQp1ULhebvkwV jexQ== X-Gm-Message-State: APjAAAW6BuY9DvPVTGwiqxVMTHqu00LNDONNKhP0VPTtRMvPIUbD5cQX ZF6LuMssSKE7FAbx0J93YtZZeKJ4q+o= X-Received: by 2002:a6b:6108:: with SMTP id v8mr50420904iob.210.1582561394387; Mon, 24 Feb 2020 08:23:14 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id w15sm3115476iow.61.2020.02.24.08.23.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2020 08:23:13 -0800 (PST) Subject: Re: [PATCH] sr_vendor: remove references to BLK_DEV_SR_VENDOR, leave it enabled. To: =?UTF-8?Q?Diego_Elio_Petten=c3=b2?= Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org References: <20200223191144.726-1-flameeyes@flameeyes.com> From: Jens Axboe Message-ID: <28e56c52-1f36-eaf5-0a92-2ffd494472ac@kernel.dk> Date: Mon, 24 Feb 2020 09:23:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200223191144.726-1-flameeyes@flameeyes.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/23/20 12:11 PM, Diego Elio Pettenò wrote: > This kernel configuration is basically enabling/disabling sr driver quirks > detection. While these quirks are for fairly rare devices (very old CD > burners, and a glucometer), the additional detection of these models is a > very minimal amount of code. > > The logic behind the quirks is always built into the sr driver. > > This also removes the config from all the defconfig files that are enabling > this already. Looks fine to me, kind of silly to have that option. Reviewed-by: Jens Axboe Assuming the SCSI tree will pick this up. -- Jens Axboe