Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp2644706ybv; Mon, 24 Feb 2020 08:56:35 -0800 (PST) X-Google-Smtp-Source: APXvYqwLIQKvQoPTlOV1wjvFk8ywwcMPBK/Uy1uHng9qfYAoczV87B9mHpRR91qcyg2f+vAs1mNN X-Received: by 2002:a05:6830:1f0c:: with SMTP id u12mr40105161otg.253.1582563395663; Mon, 24 Feb 2020 08:56:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582563395; cv=none; d=google.com; s=arc-20160816; b=pfnYG/ry7CWSoOiRuIVz226vj+JUi/fgQNbK+uqPgP87ddJqPejv1voK79MIctNu84 Rq7cueGNHSw6vi1wsz06fcITdjc/skySq+Mn0mysUVIYP+zcPF9IbBuO54Jo6kjEphsa KQ6AJxZfZSkLU0+kk95kqUOItz+5xEgM+EmeXpW4ZGZqvY95//B8gr8bQRKBe/4lZ1IW bYnvFR3sKU7wx6UGwW9n7vTZ5+qSx3RFNsGf0l2ZT2Ftsce/PL2bVsRyXnJUnjO+VwFO IRiEKgyYdBl6FkF+2Bk3SvL1KkPZma+0oiMSDUQhHRm456I0cWnhVKUzt5c9oReZXdKc XQaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:to:from:subject:message-id; bh=1OPljnFQzdTE6wPkZUyrQ8FPxkNDrYrK7zgEwcwPnfs=; b=BFh9OI/Cqv3yh555jlfCy7w83161MVPfV3capYruvp3jKO9ftlQpmwt8S+uwGC1zyr EH95IQdsEhE4RqXDoG/6KbizFhf6R33iaAH9d3F0Wd2+vNPsu+is5skge+APfd0H/rud yhlRqHVUeH15orjVDDEBdaEHAGlTQNOdI4p+ks9HMxbfLQhvGS1AGWdhFwwYUW1siU6c dWqLbOIhHX5VPLyNuBC5c5b0IfViAn2VIO4fKJrThQx2mar2TG2Cfuc93x79QIH69uTR TLNpzfO1CPrA0/PkWkOhW8pR3Oul6XX2qu3sR3K2KvwWGKV0VIDP+JNS0ATIIN/q5gSx heqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o206si5183770oih.143.2020.02.24.08.56.23; Mon, 24 Feb 2020 08:56:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727883AbgBXQ4P (ORCPT + 99 others); Mon, 24 Feb 2020 11:56:15 -0500 Received: from smtprelay0042.hostedemail.com ([216.40.44.42]:44148 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727644AbgBXQ4O (ORCPT ); Mon, 24 Feb 2020 11:56:14 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 620EC18224D7C; Mon, 24 Feb 2020 16:56:13 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,,RULES_HIT:41:355:379:599:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6119:7903:9040:9389:10004:10400:10450:10455:10848:11026:11232:11658:11914:12043:12048:12296:12297:12663:12740:12760:12895:13069:13095:13311:13357:13439:14659:14721:19904:19999:21080:21433:21611:21627:21740:30012:30054:30070:30083:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: ray51_362d824f82409 X-Filterd-Recvd-Size: 2679 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Mon, 24 Feb 2020 16:56:12 +0000 (UTC) Message-ID: <9f0d39d5972553b86123873294fc9f9566130036.camel@perches.com> Subject: Re: [PATCH v4] staging: qlge: emit debug and dump at same level From: Joe Perches To: Kaaira Gupta , Manish Chopra , GR-Linux-NIC-Dev@marvell.com, Greg Kroah-Hartman , netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 24 Feb 2020 08:54:43 -0800 In-Reply-To: <20200224164721.GA7214@kaaira-HP-Pavilion-Notebook> References: <20200224082448.GA6826@kaaira-HP-Pavilion-Notebook> <84410699e6acbffca960aa2944e9f5869478b178.camel@perches.com> <20200224164721.GA7214@kaaira-HP-Pavilion-Notebook> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-02-24 at 22:17 +0530, Kaaira Gupta wrote: > On Mon, Feb 24, 2020 at 05:38:09AM -0800, Joe Perches wrote: > > On Mon, 2020-02-24 at 13:54 +0530, Kaaira Gupta wrote: > > > Simplify code in ql_mpi_core_to_log() by calling print_hex_dump() > > > instead of existing functions so that the debug and dump are > > > emitted at the same KERN_ > > [] > > > diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c > > [] > > > @@ -1324,27 +1324,10 @@ void ql_mpi_core_to_log(struct work_struct *work) > > > { > > > struct ql_adapter *qdev = > > > container_of(work, struct ql_adapter, mpi_core_to_log.work); > > > - u32 *tmp, count; > > > - int i; > > > > > > - count = sizeof(struct ql_mpi_coredump) / sizeof(u32); > > > - tmp = (u32 *)qdev->mpi_coredump; > > > - netif_printk(qdev, drv, KERN_DEBUG, qdev->ndev, > > > - "Core is dumping to log file!\n"); > > > > There is no real need to delete this line. > > > > And if you really want to, it'd be better to mention > > the removal in the commit message description. > > > > As is for this change, there is no "debug" and "dump" > > as the commit message description shows, just "dump". > > This patch has already been added to the tree, What tree is that? It's not in -next as of right now. > if I amend the commit now > using git rebase, won't it affect the upstream as the SHA-1 of the > commit and it's children will change? You are sending patches not pull requests. If it's really in an actual tree that people care about, send another patch putting the netif_printk back.